From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 5024E1F601 for ; Tue, 6 Dec 2022 10:03:16 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VrrRdlZr"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235350AbiLFKDM (ORCPT ); Tue, 6 Dec 2022 05:03:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235721AbiLFKCE (ORCPT ); Tue, 6 Dec 2022 05:02:04 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BF5727DF5 for ; Tue, 6 Dec 2022 01:55:07 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id j5-20020a05600c410500b003cfa9c0ea76so12249991wmi.3 for ; Tue, 06 Dec 2022 01:55:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=85G8X2HRfR/saHJz5RlsIx+AHt3kVkEhzuUbq33L40k=; b=VrrRdlZrJ99dVofb9XWJYa0VE14GG2bAQ/gvh4NcQPtGlSxaiR+hXdcNI0TyoTWT7P cyitZRwDra4iTC+anxx/29Vx1roRpfgotXkHgH9ZTWpOW6RRmPAIWMN6Ix/t4ETniUMz q5Tgyy7Ds4xJVOZUQFGJGv8a2H8VzFteFXBA3s1OW7QoyLqIrEP3Q5IGtpNb1EKo+6Cz Wn9is3UjJuyRjQrqRJbEBUYRZ1JcP2Ic8aUUVM5KydMBdT+IW9ytBQsgs5HvlRTGVHFB q3UmQDiR2SktlRlhYZ6c6KjZjwHTvIcTvRvxhZZZGFlC8meZpXR7suGDOSSB7uOYxWcB OtYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=85G8X2HRfR/saHJz5RlsIx+AHt3kVkEhzuUbq33L40k=; b=qINx8Kpo9VckH+d8HEscPdbBYaCLX4GWcYYQ9OgJsAHfPPhP4upra71EOvtUMJW3dm udjeWpBGgO4nEobdcVLhwzunF7xjcpvnQE0FncGU0qP/Ws9vwPwG7hIZVOcy0CyTg0DZ GLwugs+9h+chBY3lnCMx5/v9eLN0qZN6/K8DNKML6DYIfwKxoIwpdjR9zB5J51OKqH7I QpiiUO/nUF975M+IiUBIVlvOiKXkI4MMFibGGv/LuAPKe4FHEKHxYtNppxD4DtJtIfo0 sIQ0uPYNzhwt29zeXg363bcFCQ6kiY+0NCukBuVcFvqltTLONjh3J8j4UCz01b/53d1d kwXQ== X-Gm-Message-State: ANoB5plGyzfdGU8h1Aoluky11J94MAX/7WlSCELn69ylIdKqD4dUBeqZ okpXHFlm6L8yleM8lxkJiCIHkT2ouPQ= X-Google-Smtp-Source: AA0mqf6BeCw+iLVxc1vmEJRNMyCOqH6o/T/8q1DtM5hpBiXgvfcI25aXhoFTD3uBcIIjZqGe4+D7Bg== X-Received: by 2002:a05:600c:1554:b0:3d0:e725:8ab8 with SMTP id f20-20020a05600c155400b003d0e7258ab8mr8036001wmg.122.1670320465937; Tue, 06 Dec 2022 01:54:25 -0800 (PST) Received: from [192.168.1.74] ([31.185.185.212]) by smtp.gmail.com with ESMTPSA id z10-20020a05600c0a0a00b003c70191f267sm28045065wmp.39.2022.12.06.01.54.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Dec 2022 01:54:25 -0800 (PST) From: Phillip Wood X-Google-Original-From: Phillip Wood Message-ID: <30360f4c-91a5-177b-133f-eb7036ed676a@dunelm.org.uk> Date: Tue, 6 Dec 2022 09:54:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Reply-To: phillip.wood@dunelm.org.uk Subject: Re: [PATCH] test-lib.sh: discover "git" in subdirs of "contrib/buildsystems/out" Content-Language: en-US To: Junio C Hamano , =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Cc: Jeff King , Taylor Blau , git@vger.kernel.org, Phillip Wood , Johannes Schindelin References: <663b93ef-0c89-a5f6-1069-b4be97915d20@dunelm.org.uk> <87f22a55-ee84-2f76-7b9b-924a97f44f89@dunelm.org.uk> <221202.86sfhxg2ng.gmgdl@evledraar.gmail.com> <221203.86pmd1dyqn.gmgdl@evledraar.gmail.com> <221206.86zgc1cnc3.gmgdl@evledraar.gmail.com> <221206.86mt81claa.gmgdl@evledraar.gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 06/12/2022 03:52, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Just to add my own digression: I asked in some past thread (which I'm >> too lazy to dig up) why it was the cmake file couldn't just dispatch to >> "make" for most things. Because make is not installed by default on Windows. Our CI job uses msbuild (whatever that is) and when I was playing with Visual Studio last week it was using ninja. >> I.e. it needs to at some level be aware of what it's building for the >> IDE integration, but for say making a "grep.o" there's no reason it >> couldn't be running: >> >> make grep.o >> >> Instead of: >> >> cc -o grep grep.c [...] >> >> which requires duplicating much of the Makefile logic (possibly with >> some Makefile shim to not consider any dependencies in that case). > > That leads to a question at the other extreme. Why does any logic > in CMakeLists.txt even have to exist at all? Whenever it is asked > to make foo, it can be running "make foo" instead of having its own > logic at all. ;-) Yes, if make was available then we wouldn't need to use CMake. Best Wishes Phillip