From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id D77D91F5AD for ; Tue, 7 Apr 2020 17:29:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726483AbgDGR3n (ORCPT ); Tue, 7 Apr 2020 13:29:43 -0400 Received: from smtprelay0050.hostedemail.com ([216.40.44.50]:46752 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726420AbgDGR3m (ORCPT ); Tue, 7 Apr 2020 13:29:42 -0400 X-Greylist: delayed 540 seconds by postgrey-1.27 at vger.kernel.org; Tue, 07 Apr 2020 13:29:42 EDT Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave04.hostedemail.com (Postfix) with ESMTP id 99BEF1800EC46 for ; Tue, 7 Apr 2020 17:20:42 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 62F4D18033F62; Tue, 7 Apr 2020 17:20:41 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: army88_5e3ac7fd8b42 X-Filterd-Recvd-Size: 2612 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA; Tue, 7 Apr 2020 17:20:40 +0000 (UTC) Message-ID: <2e6975d606846c834a387c07ee11cdce52356586.camel@perches.com> Subject: Re: get_maintainer.pl sends bogus addresses to git send-email From: Joe Perches To: Jeff King , Olaf Hering Cc: linux-kernel@vger.kernel.org, git@vger.kernel.org Date: Tue, 07 Apr 2020 10:18:41 -0700 In-Reply-To: <20200407170257.GA1844923@coredump.intra.peff.net> References: <20200407154046.GA15368@aepfle.de> <20200407170257.GA1844923@coredump.intra.peff.net> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, 2020-04-07 at 13:02 -0400, Jeff King wrote: > On Tue, Apr 07, 2020 at 05:40:46PM +0200, Olaf Hering wrote: > > > For me sending patches via git send-email fails because email address > > conversion is failing. Something appends a ')' to x86/lkml@kernel.org. > > I suspect the double '))' in MAINTAINERS is confusing the command. > > I tried to send the trivial patch from v5.0 and v5.6 tag. > > > > Is this a failure in ./scripts/get_maintainer.pl, > > or is this something git does internally? > > I'm sure others use such command on a daily basis, so likely something on > > my end became broken at some point in the past. > > It's a bug in send-email's hand-rolled address parser, which was fixed > in bd869f67b9 (send-email: add and use a local copy of Mail::Address, > 2018-01-05). Upgrade to Git v2.17.0 or newer. Not really. You need to add --norolestats on the get_maintainer command line git send-email expects bare email addresses, not ones annotated with additional content. For instance: $ ./scripts/get_maintainer.pl -f lib/vsprintf.c Petr Mladek (maintainer:VSPRINTF) Steven Rostedt (maintainer:VSPRINTF) Sergey Senozhatsky (maintainer:VSPRINTF) Andy Shevchenko (reviewer:VSPRINTF) Rasmus Villemoes (reviewer:VSPRINTF) linux-kernel@vger.kernel.org (open list) vs: $ ./scripts/get_maintainer.pl -f --norolestats lib/vsprintf.c Petr Mladek Steven Rostedt Sergey Senozhatsky Andy Shevchenko Rasmus Villemoes linux-kernel@vger.kernel.org