[PATCH v3 03/23] safe_create_leading_directories_const(): preserve errno

git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed

From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	David Turner <novalis@novalis.org>,
	Michael Haggerty <mhagger@alum.mit.edu>
Subject: [PATCH v3 03/23] safe_create_leading_directories_const(): preserve errno
Date: Sat, 31 Dec 2016 04:12:43 +0100	[thread overview]
Message-ID: <2d685f4c5cbe17bf1abf2ef3fb2f03fd20a0c23d.1483153436.git.mhagger@alum.mit.edu> (raw)
In-Reply-To: <cover.1483153436.git.mhagger@alum.mit.edu>

Some implementations of free() change errno (even thought they
shouldn't):

  https://sourceware.org/bugzilla/show_bug.cgi?id=17924

So preserve the errno from safe_create_leading_directories() across the
call to free().

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 sha1_file.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sha1_file.c b/sha1_file.c
index 1173071..10395e7 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -166,10 +166,14 @@ enum scld_error safe_create_leading_directories(char *path)
 
 enum scld_error safe_create_leading_directories_const(const char *path)
 {
+	int save_errno;
 	/* path points to cache entries, so xstrdup before messing with it */
 	char *buf = xstrdup(path);
 	enum scld_error result = safe_create_leading_directories(buf);
+
+	save_errno = errno;
 	free(buf);
+	errno = save_errno;
 	return result;
 }
 
-- 
2.9.3

next prev parent reply	other threads:[~2016-12-31  3:13 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-31  3:12 [PATCH v3 00/23] Delete directories left empty after ref deletion Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 01/23] files_rename_ref(): tidy up whitespace Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 02/23] t5505: use "for-each-ref" to test for the non-existence of references Michael Haggerty
2016-12-31  3:12 ` Michael Haggerty [this message]
2016-12-31  3:12 ` [PATCH v3 04/23] safe_create_leading_directories(): set errno on SCLD_EXISTS Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 05/23] raceproof_create_file(): new function Michael Haggerty
2016-12-31  6:11   ` Jeff King
2016-12-31  7:42     ` Michael Haggerty
2017-01-01  2:07       ` Junio C Hamano
2016-12-31  3:12 ` [PATCH v3 06/23] lock_ref_sha1_basic(): inline constant Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 07/23] lock_ref_sha1_basic(): use raceproof_create_file() Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 08/23] rename_tmp_log(): " Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 09/23] rename_tmp_log(): improve error reporting Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 10/23] log_ref_write(): inline function Michael Haggerty
2017-01-01  2:09   ` Junio C Hamano
2017-01-01  8:41     ` Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 11/23] log_ref_setup(): separate code for create vs non-create Michael Haggerty
2016-12-31  6:26   ` Jeff King
2016-12-31  7:52     ` Michael Haggerty
2017-01-01  3:28   ` Junio C Hamano
2017-01-01  8:45     ` Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 12/23] log_ref_setup(): improve robustness against races Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 13/23] log_ref_setup(): pass the open file descriptor back to the caller Michael Haggerty
2016-12-31  6:32   ` Jeff King
2016-12-31  7:58     ` Michael Haggerty
2016-12-31 17:58       ` Jeff King
2017-01-01 10:36         ` Junio C Hamano
2016-12-31  3:12 ` [PATCH v3 14/23] log_ref_write_1(): don't depend on logfile argument Michael Haggerty
2016-12-31  6:35   ` Jeff King
2016-12-31  8:01     ` Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 15/23] log_ref_setup(): manage the name of the reflog file internally Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 16/23] log_ref_write_1(): inline function Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 17/23] delete_ref_loose(): derive loose reference path from lock Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 18/23] delete_ref_loose(): inline function Michael Haggerty
2016-12-31  3:12 ` [PATCH v3 19/23] try_remove_empty_parents(): rename parameter "name" -> "refname" Michael Haggerty
2016-12-31  3:13 ` [PATCH v3 20/23] try_remove_empty_parents(): don't trash argument contents Michael Haggerty
2016-12-31  6:40   ` Jeff King
2017-01-02 16:27     ` Michael Haggerty
2017-01-02 17:10       ` Jeff King
2016-12-31  3:13 ` [PATCH v3 21/23] try_remove_empty_parents(): don't accommodate consecutive slashes Michael Haggerty
2017-01-01  2:30   ` Junio C Hamano
2017-01-01  5:59     ` Jeff King
2017-01-02 18:06       ` Michael Haggerty
2017-01-02 18:26         ` Jeff King
2016-12-31  3:13 ` [PATCH v3 22/23] try_remove_empty_parents(): teach to remove parents of reflogs, too Michael Haggerty
2016-12-31  3:13 ` [PATCH v3 23/23] files_transaction_commit(): clean up empty directories Michael Haggerty
2016-12-31  6:47 ` [PATCH v3 00/23] Delete directories left empty after ref deletion Jeff King
2017-01-01  2:32   ` Junio C Hamano
2017-01-01  9:24     ` Jacob Keller
2017-01-01  9:26       ` Jacob Keller
2017-01-01 12:43       ` Philip Oakley
2017-01-01 20:36         ` Jacob Keller
2017-01-02  4:19           ` Jeff King
2017-01-02 18:14             ` Michael Haggerty
2017-01-02 18:54               ` Jacob Keller

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:1173071 dfblob:10395e7
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d685f4c5cbe17bf1abf2ef3fb2f03fd20a0c23d.1483153436.git.mhagger@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=novalis@novalis.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).