From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 113AD1F54E for ; Fri, 9 Sep 2022 14:35:12 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="cf3i4XXS"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231208AbiIIOdp (ORCPT ); Fri, 9 Sep 2022 10:33:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229876AbiIIOdo (ORCPT ); Fri, 9 Sep 2022 10:33:44 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C983F16CA for ; Fri, 9 Sep 2022 07:33:41 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id bz13so3099236wrb.2 for ; Fri, 09 Sep 2022 07:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date; bh=ewWdgINeDogjbAxyhyHuxTCApDJunU7409v6MqwQtl4=; b=cf3i4XXSRFR6TjpopzvRoMT1cavOKG4YLqipW3RgDBt0mAvgq6QSHIoV9xrIVNYW2L 8L9STi9JFJ1F+zZt8IwSoKBDZjWiZxUXlIhKy39ShkYclF66OJl0N1Cj9vvYw/GflHLj WdctLmQfTUPGHdbruxnInE2qVE6iiXgNZR0jmIVwlEHU9y8NV/uR0SiRImni8pLG6tzx jUxytQMIjRuizcAEOb7GYNLGbGcm0wSrNBFXacefyu91Yz8mVBQyvk7EvMNWlfQw7eG4 DCY6gb2pWnMP8n1gvgzMqVYaeVTNN6KEa5YkBN6SkxEWkGVmX7o2xr2AQVmx5l00u1WH y9FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date; bh=ewWdgINeDogjbAxyhyHuxTCApDJunU7409v6MqwQtl4=; b=Y2sE69iT3WOduacC7StRYeHKRiHBjM6+lf9l5oPtCBIW5zxwtefQW/Gg2sm3sbRcwA ZcWy4GbDKia2m61IIqXDPRmqc4CqBx/8FEJsqiYti1LCkRXLguwtSGDT8Uyj87nQqfM3 mcGmKtI69xVIVD9NK34qZPvdiRIP+NyuBECxIuGFgki7wIT78EeRwyxFrEWs1lrPN4IB qn1EUfEol0UtrgFru/8g1tINUR0durIcWXgrhLwk4W0V6drXyFpBuA5UN2mR6Hw7hE9d NYfjiOrDNgXyRAkcAqGliqQbCceu6am/QhB46nwn7gYzHS89oSM0b/wSrhfyoJrhpSSo FCRw== X-Gm-Message-State: ACgBeo3Dm+VOZOMhdbvXpaji64wjwygC/oT1JSrEN30NEMTfe33EHtFe a+xnZFO8ReWuyaAF4tF8DYbW7l2VIv8= X-Google-Smtp-Source: AA6agR68CyNVpRLHSBlnpUfiBmJcUIwCEK6gjrfDIY0tf99tXjQ2T0GT1YLes/L4MAc64eO7TvO8Sg== X-Received: by 2002:a5d:4c4c:0:b0:22a:35bd:84a9 with SMTP id n12-20020a5d4c4c000000b0022a35bd84a9mr3896044wrt.103.1662734019457; Fri, 09 Sep 2022 07:33:39 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id z13-20020adfd0cd000000b0022587413219sm706303wrh.16.2022.09.09.07.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 07:33:38 -0700 (PDT) Message-Id: <2ca431e6c377f42d70ea9ce0ac74058fc983ea2c.1662734015.git.gitgitgadget@gmail.com> In-Reply-To: References: From: "Derrick Stolee via GitGitGadget" Date: Fri, 09 Sep 2022 14:33:27 +0000 Subject: [PATCH v2 1/9] bundle-uri: short-circuit capability parsing Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: gitster@pobox.com, me@ttaylorr.com, newren@gmail.com, avarab@gmail.com, mjcheetham@outlook.com, steadmon@google.com, Glen Choo , Jonathan Tan , Teng Long , Derrick Stolee , Derrick Stolee Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Derrick Stolee When parsing the capability lines from the 'git remote-https' process, we can stop reading the lines once we notice the 'get' capability. Reported-by: Teng Long Signed-off-by: Derrick Stolee --- bundle-uri.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bundle-uri.c b/bundle-uri.c index 4a8cc74ed05..7173ed065e9 100644 --- a/bundle-uri.c +++ b/bundle-uri.c @@ -56,8 +56,10 @@ static int download_https_uri_to_file(const char *file, const char *uri) while (!strbuf_getline(&line, child_out)) { if (!line.len) break; - if (!strcmp(line.buf, "get")) + if (!strcmp(line.buf, "get")) { found_get = 1; + break; + } } strbuf_release(&line); -- gitgitgadget