From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Jeff King <peff@peff.net>, Jeff Hostetler <git@jeffhostetler.com>
Cc: Taylor Blau <me@ttaylorr.com>, Git Users <git@vger.kernel.org>,
"brian m . carlson" <sandals@crustytoothpaste.net>
Subject: Re: "bad revision" fetch error when fetching missing objects from partial clones
Date: Sat, 15 May 2021 13:52:06 +0700 [thread overview]
Message-ID: <2bd7a4d7-0278-1ab6-9867-a158cd08613f@gmail.com> (raw)
In-Reply-To: <YJz4JTsFjTtL7mE2@coredump.intra.peff.net>
On 13/05/21 16.57, Jeff King wrote:
> I think it is actually a bug with pack-objects not sending the object,
> but it only seems to trigger with bitmaps. This works:
>
> git init repo
> cd repo
>
> echo content >file
> git add file
> git commit -m base
>
> git config uploadpack.allowfilter true
> git clone --no-local --bare --filter=blob:none . clone
>
> cd clone
> git fetch origin $(git rev-parse HEAD:file)
>
> But if I add a "git repack -adb" in the parent repository before the "cd
> clone", then I get:
>
> remote: Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
> fatal: bad revision 'd95f3ad14dee633a758d2e331151e950dd13e4ed'
> error: /home/peff/tmp/repo/. did not send all necessary objects
>
> So presumably this is a bug in the bitmap-aware filtering code that is
> not present in the regular filter-traversing code. But what really
> puzzles me is that the result seems totally broken. Yet the test
> coverage in t5310 passes, and nobody has noticed on major sites like
> GitHub (which supports partial clones and most certainly has bitmaps
> enabled).
I can reproduce using your test case above, thanks.
Anyway, for the moment being, I clone using "git clone --depth <N>" and
then deepen the clone by "git fetch --deepen <N>" iteratively until
complete. I do that because of quota constraints on my network.
--
An old man doll... just what I always wanted! - Clara
prev parent reply other threads:[~2021-05-15 6:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 12:56 "bad revision" fetch error when fetching missing objects from partial clones Bagas Sanjaya
2021-05-11 18:44 ` Jeff Hostetler
2021-05-13 9:57 ` Jeff King
2021-05-13 10:53 ` Jeff King
2021-05-14 7:27 ` Jeff King
2021-05-17 6:03 ` Patrick Steinhardt
2021-05-17 6:31 ` Jeff King
2021-05-17 16:25 ` Derrick Stolee
2021-05-18 8:11 ` Jeff King
2021-05-18 10:14 ` Bagas Sanjaya
2021-05-18 14:04 ` Derrick Stolee
2021-05-15 6:52 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bd7a4d7-0278-1ab6-9867-a158cd08613f@gmail.com \
--to=bagasdotme@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).