From: Jonathan Tan <jonathantanmy@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] sequencer: support folding in rfc2822 footer
Date: Tue, 6 Sep 2016 15:08:05 -0700 [thread overview]
Message-ID: <29cb0f55-f729-80af-cdca-64e927fa97c0@google.com> (raw)
In-Reply-To: <xmqqy439rabb.fsf@gitster.mtv.corp.google.com>
On 09/02/2016 07:23 PM, Junio C Hamano wrote:
> Jonathan Tan <jonathantanmy@google.com> writes:
>
>> Sample-field: multiple-line field body
>> that causes a blank line below
>
> I am not sure this is unconditionally good, or may cause problems to
> those with workflows you did not consider when you wrote this patch.
>
> Not being too lenient here historically has been a deliberate
> decision to avoid misidentification of non "footers". Does Git
> itself produce some folded footer line? If Git itself produced such
> folded lines, I'd be a lot more receptive to this change, but I do
> not think that is the case here.
I don't think Git produces any folded lines, but folded lines do appear
in footers in projects that use Git. For example, some Android commits
have multi-line "Test:" fields (example, [1]) and some Linux commits
have multi-line "Tested-by:" fields (example, [2]).
Taking the Android commit as an example, this would mean that
cherrypicking that commit would create a whole new footer, and tripping
up tools (for example, Gerrit, which looks for "Change-Id:" in the last
paragraph). But this would not happen if "Test:" was single-line instead
of multi-line - which seems inconsistent.
[1]
https://android.googlesource.com/platform/frameworks/base/+/4c5281862f750cbc9d7355a07ef1a5545b9b3523
[2]
https://kernel.googlesource.com/pub/scm/linux/kernel/git/stable/linux-stable/+/69f92f67b68ab7028ffe15f0eea76b59f8859383
> A slightly related tangent. An unconditionally good change you
> could make is to allow folding of in-body headers. I.e. you can
> have e.g.
>
> -- >8 --
> Subject: [PATCH] sequencer: support in-body headers that are
> folded according to RFC2822 rules
>
> The first paragraph after the above long title begins
> here...
>
> in the body of the msssage, and I _think_ we do not fold it properly
> when applying such a patch. We should, as that is something that
> appears in format-patch output (i.e. something Git itself produces,
> unlike the folded "footer").
OK, I'll take a look at this.
next prev parent reply other threads:[~2016-09-06 22:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 19:58 [PATCH] sequencer: support folding in rfc2822 footer Jonathan Tan
2016-09-03 2:23 ` Junio C Hamano
2016-09-06 22:08 ` Jonathan Tan [this message]
2016-09-06 23:30 ` Jonathan Tan
2016-09-07 6:38 ` Jeff King
2016-09-16 17:37 ` [RFC/PATCH 0/3] handle multiline in-body headers Jonathan Tan
2016-09-16 18:29 ` Junio C Hamano
2016-09-16 17:37 ` [RFC/PATCH 1/3] mailinfo: refactor commit message processing Jonathan Tan
2016-09-16 19:12 ` Junio C Hamano
2016-09-16 21:46 ` Jeff King
2016-09-16 17:37 ` [RFC/PATCH 2/3] mailinfo: correct malformed test example Jonathan Tan
2016-09-16 19:19 ` Junio C Hamano
2016-09-16 22:42 ` Jonathan Tan
2016-09-16 22:55 ` Junio C Hamano
2016-09-17 0:31 ` Jonathan Tan
2016-09-17 3:48 ` Junio C Hamano
2016-09-16 17:37 ` [RFC/PATCH 3/3] mailinfo: handle in-body header continuations Jonathan Tan
2016-09-16 20:17 ` Junio C Hamano
2016-09-16 20:49 ` Jonathan Tan
2016-09-16 20:59 ` Junio C Hamano
2016-09-16 22:36 ` Jonathan Tan
2016-09-16 23:04 ` Junio C Hamano
2016-09-17 0:22 ` Jonathan Tan
2016-09-16 21:51 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29cb0f55-f729-80af-cdca-64e927fa97c0@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).