From: "Philip Oakley" <philipoakley@iee.org>
To: "Dale R. Worley" <worley@alum.mit.edu>
Cc: <git@vger.kernel.org>, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [git-users] Problem using detached worktrees with commands implemented in scripts
Date: Wed, 16 Oct 2013 23:39:25 +0100 [thread overview]
Message-ID: <29AA597BEBC146B09E8B370949EC2CE9@PhilipOakley> (raw)
In-Reply-To: xmqqeh7k51vg.fsf@gitster.dls.corp.google.com
From: "Junio C Hamano" <gitster@pobox.com>
> worley@alum.mit.edu (Dale R. Worley) writes:
>
>> In general, Git commands on a repository with a detached worktree can
>> be executed by cd'ing into the directory containing the .git
>> directory, ...
>
> Eh? News to me; it might happened to have appeared to work by
> accident, but that is not by design.
I think it is this part in Dale's original email
"However, this approach does not work with "git filter-branch", which
objects with "You need to run this command from the toplevel of the
working tree."
that is the problem Dale has seen. IIRC there are a few commands that do
require to be run from the toplevel ('git bisect' I think is another),
and the detection process for 'toplevel' may not work properly when in a
separated work-tree environment.
Perhaps something to consider.
Philip
>
> IIRC, the intended use pattern (i.e. the change that introduced
> GIT_DIR and GIT_WORK_TREE environment variables was designed to
> support) for such a working tree is to:
>
> - export GIT_DIR that points at the correct .git directory;
>
> - export GIT_WORK_TREE that points at the correct top-level of such
> a working tree; and then
>
> - run the commands anywhere in the working tree, as if you did not
> export these two environment variables and instead had the .git
> directory at the usual place in the working tree.
>
> It _is_ possible that we may have broken this canonical use pattern
> over time with more recent updates; I do not think we have extensive
> test coverage for "detached worktree" use case in the first place.
>
>> Does anyone have any feedback on this?
>
> Not exporting GIT_DIR variable in sh-setup was done not by accident
> but as a very deliberate design choice, IIRC.
> --
next prev parent reply other threads:[~2013-10-16 22:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 20:03 [git-users] Problem using detached worktrees with commands implemented in scripts Dale R. Worley
2013-10-16 21:42 ` Junio C Hamano
2013-10-16 22:39 ` Philip Oakley [this message]
2013-10-16 23:08 ` Junio C Hamano
2013-10-17 20:11 ` Philip Oakley
2013-10-17 20:50 ` Junio C Hamano
2013-10-17 21:14 ` Philip Oakley
2013-10-17 22:38 ` Philip Oakley
2013-10-17 22:48 ` Jonathan Nieder
2013-10-18 20:40 ` Philip Oakley
2013-10-18 22:54 ` Dale R. Worley
2013-10-17 19:09 ` Dale R. Worley
2013-10-17 20:08 ` Junio C Hamano
2013-10-18 22:25 ` Dale R. Worley
2013-10-18 22:43 ` Junio C Hamano
2013-10-21 18:51 ` Dale R. Worley
2013-10-18 22:50 ` Dale R. Worley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29AA597BEBC146B09E8B370949EC2CE9@PhilipOakley \
--to=philipoakley@iee.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=worley@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).