From: Joachim Durchholz <jo@durchholz.org>
To: git@vger.kernel.org
Subject: Re: [PATCH 0/2] test: Detect *lots* of bugs by adding non-alnum to trash dir names
Date: Sun, 9 Apr 2017 22:37:08 +0200 [thread overview]
Message-ID: <2893d697-735f-537c-241d-910139f2c281@durchholz.org> (raw)
In-Reply-To: <20170409191117.25175-1-avarab@gmail.com>
Am 09.04.2017 um 21:11 schrieb Ævar Arnfjörð Bjarmason:
> This series changes the test library so that we interpolate the result
> of:
>
> perl -e 'print join q[], grep { /[^[:alnum:]]/ and !m<[./]> } map chr, 0x01..0x7f'
>
> Into the trash directory name we generate. Doing this makes 30% of the
> test suite fail.
Wow.
I know that I tend to bring out weird errors in systems, but this is
much deeper than I could have ever expected.
You might want to additionally test directory names like "asdf" and
'asdf' - some shell might try to be smart about such names and
automatically unquote them. This would probably mean running the test
suite multiple times, which some people find offensive (myself included).
There's also high-bit characters that might cause oddness. 0x80 and 0xff
look like interesting edge cases to me.
Note that just appending these bytes is going to cause failures with
filesystems that expect UTF-8 file names, you'd want to use a Unicode
code point that gets encoded using a 0x80 resp. 0xff byte (I suspect
0xff is actually not a valid UTF-8 encoding at all but I'd have to
double-check that).
Is git supposed to run fine under Windows, or under Linux with an ntfs
filesystem driver?
If yes, then I'd expect this patch to cause the other 70% of tests to
crash, because NTFS forbids several non-alnum printable characters,
among them <=>\
prev parent reply other threads:[~2017-04-09 20:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-09 19:11 [PATCH 0/2] test: Detect *lots* of bugs by adding non-alnum to trash dir names Ævar Arnfjörð Bjarmason
2017-04-09 19:11 ` [PATCH 1/2] tests: mark tests that fail when the TEST_DIRECTORY is unusual Ævar Arnfjörð Bjarmason
2017-04-09 19:11 ` [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name Ævar Arnfjörð Bjarmason
2017-04-10 1:47 ` SZEDER Gábor
2017-04-10 8:02 ` Ævar Arnfjörð Bjarmason
2017-04-10 11:19 ` SZEDER Gábor
2017-04-10 11:40 ` Ævar Arnfjörð Bjarmason
2017-04-10 13:38 ` Jeff King
2017-04-10 14:59 ` Joachim Durchholz
2017-04-10 16:57 ` Jeff King
2017-04-10 18:19 ` Joachim Durchholz
2017-04-10 19:22 ` Jeff King
2017-04-10 13:43 ` SZEDER Gábor
2017-04-10 23:23 ` Ævar Arnfjörð Bjarmason
2017-04-11 0:30 ` [PATCH] connect.c: handle errors from split_cmdline Jeff King
2017-04-11 0:35 ` Jeff King
2017-04-11 9:27 ` Ævar Arnfjörð Bjarmason
2017-04-11 10:54 ` Jeff King
2017-04-11 11:06 ` Ævar Arnfjörð Bjarmason
2017-04-17 0:51 ` Junio C Hamano
2017-04-17 0:54 ` Junio C Hamano
2017-04-19 10:59 ` Ævar Arnfjörð Bjarmason
2017-04-11 1:14 ` [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name Jeff King
2017-04-11 6:28 ` Joachim Durchholz
2017-04-09 20:37 ` Joachim Durchholz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2893d697-735f-537c-241d-910139f2c281@durchholz.org \
--to=jo@durchholz.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).