From: Kevin Bracey <kevin@bracey.fi>
To: Jeff King <peff@peff.net>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Git mailing list" <git@vger.kernel.org>
Subject: Re: Weird revision walk behaviour
Date: Thu, 31 May 2018 17:54:07 +0300 [thread overview]
Message-ID: <28359a94-e584-a963-428d-2cf11f2cb895@bracey.fi> (raw)
In-Reply-To: <20180531054355.GA17344@sigill.intra.peff.net>
On 31/05/2018 08:43, Jeff King wrote:
>
> If there are zero parents (neither relevant nor irrelevant), is it still
> TREESAME? I would say in theory yes.
Not sure - I think roots are such a special case that TREESAME
effectively doesn't matter. We always test for roots first.
> So what I was proposing would be to
> rewrite the parents to the empty set.
That feels a bit radical - I believe we need to retain (some) parent
information for modes that show it (eg the dangling unfilled circles in
gitk). And making it a root I think could cause other problems with
making it look like we have a disjoint history. I believe the next
simplification step may be trying to follow down to the common root.
> What next here? It looks like we have a proposed solution. Do you want
> to try to work up a set of tests based on what you wrote earlier?
I was hoping Gábor would carry on, as he's made a start... I was just
planning to back-seat drive.
> I'd also love to hear from Junio as the expert in this area, but I think
> he's been a bit busy with maintainer stuff recently. So maybe I should
> just be patient. :)
>
Likewise - I have been quite deep into this, but it was a quite short
window of investigation a long time ago, and I've not looked at it
since. Would like input from someone with more active knowledge.
Kevin
prev parent reply other threads:[~2018-05-31 15:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 17:10 Weird revision walk behaviour SZEDER Gábor
2018-05-23 17:32 ` Jeff King
2018-05-23 17:35 ` Jeff King
2018-05-24 18:54 ` Kevin Bracey
2018-05-24 20:26 ` Kevin Bracey
2018-05-27 17:37 ` Kevin Bracey
2018-05-28 22:06 ` SZEDER Gábor
2018-05-29 6:11 ` Kevin Bracey
2018-05-29 21:04 ` Jeff King
2018-05-30 8:20 ` Kevin Bracey
2018-05-31 5:43 ` Jeff King
2018-05-31 14:54 ` Kevin Bracey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28359a94-e584-a963-428d-2cf11f2cb895@bracey.fi \
--to=kevin@bracey.fi \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).