From: Stas Bekman <stas@stason.org>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: git silently ignores include directive with single quotes
Date: Sat, 8 Sep 2018 12:44:30 -0700 [thread overview]
Message-ID: <2824cc17-b4a4-8821-331f-1768246f2e6b@stason.org> (raw)
In-Reply-To: <CAN0heSroxfcwiJaVgGFTweq=XKAgGsR-E6SeOgsG4m0rzK4dHQ@mail.gmail.com>
On 2018-09-08 12:30 PM, Martin Ågren wrote:
> Actually, there is a test explicitly testing that 'missing include files
> are ignored'. I couldn't find a motivation for this in 9b25a0b52e
> (config: add include directive, 2012-02-06).
Thank you for the follow up, Martin. And discovering that it is by design.
I suppose this could have been done to optimize run-time performance.
But there must be a way for a user to validate their custom
configuration. So perhaps there should be a specific directive to do so?
One could argue that:
git config --list --show-origin
does exactly that. Except it should probably also indicate that some
configuration file or parts of were ignored - and clearly indicate the
exact nature of the problem. In which case it'd be sufficient.
>> (2) probably allow the quoted location of the file, but it's much less
>> important, as it's easy to rectify once git gives user #1
>
> I don't think this will work. Allowing quoting for just this one item,
> or for all? Any and all quoting or just at the first and last character?
> What about those config items where quotes might legitimately occur,
> i.e., we'd need some escaping? Actually, something like '.gitconfig'
> *with* *those* *quotes* is a valid filename on my machine.
Let's ignore this sub-issue for now. If we can get git to report when
something is mis-configured, this issue can then be easily resolved.
--
________________________________________________
Stas Bekman <'))))>< <'))))><
https://stasosphere.com https://chestofbooks.com
https://experientialsexlab.com https://stason.org
https://stasosphere.com/experience-life/my-books
next prev parent reply other threads:[~2018-09-08 19:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 18:58 git silently ignores include directive with single quotes Stas Bekman
2018-09-08 19:30 ` Martin Ågren
2018-09-08 19:44 ` Stas Bekman [this message]
2018-09-08 19:53 ` Stas Bekman
2018-09-08 20:02 ` Ævar Arnfjörð Bjarmason
2018-09-08 20:13 ` Stas Bekman
2018-09-08 20:28 ` Ævar Arnfjörð Bjarmason
2018-09-08 20:58 ` Stas Bekman
2018-09-09 2:51 ` Paul Smith
2018-09-09 2:57 ` Stas Bekman
2018-09-08 19:54 ` Ævar Arnfjörð Bjarmason
2018-09-08 20:04 ` Stas Bekman
2018-09-08 20:16 ` Ævar Arnfjörð Bjarmason
2018-09-08 21:14 ` Jeff King
2018-09-08 22:10 ` Ramsay Jones
2018-09-09 2:33 ` Jeff King
2018-09-11 20:36 ` Junio C Hamano
2018-09-11 20:57 ` Jeff King
2018-09-23 22:48 ` Stas Bekman
2018-09-24 21:08 ` Ævar Arnfjörð Bjarmason
2018-09-24 23:20 ` Stas Bekman
2018-09-24 22:24 ` [PATCH 0/1] " Philip Oakley
2018-09-24 23:05 ` Stas Bekman
2018-09-24 22:24 ` [PATCH 1/1] config doc: highlight the name=value syntax Philip Oakley
2018-09-25 22:03 ` Junio C Hamano
2018-09-08 22:32 ` git silently ignores include directive with single quotes Ævar Arnfjörð Bjarmason
2018-09-09 2:29 ` Jeff King
2018-09-08 21:22 ` Jeff King
2018-09-08 22:49 ` Stas Bekman
2018-09-09 2:30 ` Jeff King
2018-09-10 17:04 ` Junio C Hamano
2018-09-10 17:14 ` Jonathan Nieder
2018-09-10 18:30 ` Junio C Hamano
2018-09-10 18:35 ` Jonathan Nieder
2018-09-10 19:17 ` Junio C Hamano
2018-09-10 19:52 ` Stas Bekman
2018-09-10 20:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2824cc17-b4a4-8821-331f-1768246f2e6b@stason.org \
--to=stas@stason.org \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).