From: Lundkvist Per <per.lundkvist@saabgroup.com>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Soundness of signature verification excluding unsigned empty merges
Date: Tue, 21 Mar 2023 10:32:01 +0000 [thread overview]
Message-ID: <27a7d2956ed94d7ea8eb6d17f1414525@saabgroup.com> (raw)
Hi,
We are investigating adding commit and tag signatures into our existing
repositories. We currently use the common workflow of developers merging commits
to master using an internal git hosting service after having passed code
review. Non-local merges like this would then be unsigned.
But it seems like if we allow unsigned empty merge commits, i.e. those that
themselves do not introduce any any other change than what its parents
introduce, and require all other commits to be properly validated, then we can
safely validate the whole repository?
A simple naive example of this would look something like this:
rc=0
tags=$(git for-each-ref --format '%(objectname)' refs/tags)
tags_verified=$(for i in $tags; do git verify-tag --format='%(objectname)' "$i"; done)
for i in $(git rev-list HEAD --no-merges --not $tags_verified); do
git verify-commit "$i" || rc=1
done
for i in $(git rev-list HEAD --merges --not $tags_verified); do
diff=$(git show --text --pretty=format: --diff-merges=cc "$i")
git verify-commit "$i" || [ ! "$diff" ] || rc=1
done
exit $rc
Or is this a faulty strategy?
Thanks,
/Per Lundkvist
next reply other threads:[~2023-03-21 11:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 10:32 Lundkvist Per [this message]
2023-03-21 16:43 ` Soundness of signature verification excluding unsigned empty merges Junio C Hamano
2023-03-22 11:50 ` [EXTERNAL] " Lundkvist Per
2023-03-22 1:41 ` Elijah Newren
2023-03-22 12:14 ` [EXTERNAL] " Lundkvist Per
2023-03-23 1:49 ` Elijah Newren
2023-03-23 9:55 ` Lundkvist Per
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27a7d2956ed94d7ea8eb6d17f1414525@saabgroup.com \
--to=per.lundkvist@saabgroup.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).