From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id CDB871F4CE for ; Wed, 6 Apr 2022 15:40:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236195AbiDFPli (ORCPT ); Wed, 6 Apr 2022 11:41:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236253AbiDFPkt (ORCPT ); Wed, 6 Apr 2022 11:40:49 -0400 X-Greylist: delayed 3550 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 06 Apr 2022 06:17:54 PDT Received: from mut-mta1-se01b-zose1-fr.yulpa.io (mut-mta1-se01b-zose1-fr.yulpa.io [185.49.22.247]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7F915AFCB6 for ; Wed, 6 Apr 2022 06:17:54 -0700 (PDT) Received: from [185.217.155.54] (helo=mut-zose1-mta-hub-outmua01a-fr.yulpa.io) by mut-mta1-se01b-fr.yulpa.io with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1nc4Jh-0007vR-J2; Wed, 06 Apr 2022 13:59:19 +0200 Received: from localhost (localhost [127.0.0.1]) by mut-zose1-mta-hub-outmua01a-fr.yulpa.io (Postfix) with ESMTP id CBCF520EF4; Wed, 6 Apr 2022 13:59:15 +0200 (CEST) Received: from mut-zose1-mta-hub-outmua01a-fr.yulpa.io ([127.0.0.1]) by localhost (mut-zose1-mta-hub-outmua01a-fr.yulpa.io [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SDLTXMA4VNq2; Wed, 6 Apr 2022 13:59:14 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mut-zose1-mta-hub-outmua01a-fr.yulpa.io (Postfix) with ESMTP id 2548020F68; Wed, 6 Apr 2022 13:59:14 +0200 (CEST) X-Virus-Scanned: amavisd-new at mut-zose1.yulpa.io Received: from mut-zose1-mta-hub-outmua01a-fr.yulpa.io ([127.0.0.1]) by localhost (mut-zose1-mta-hub-outmua01a-fr.yulpa.io [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qXylxa09FDGT; Wed, 6 Apr 2022 13:59:13 +0200 (CEST) Received: from [140.77.13.114] (dhcp-13-114.lip.ens-lyon.fr [140.77.13.114]) (Authenticated sender: matthieu.moy@matthieu-moy.fr) by mut-zose1-mta-hub-outmua01a-fr.yulpa.io (Postfix) with ESMTPSA id C2CE520F3C; Wed, 6 Apr 2022 13:59:13 +0200 (CEST) Message-ID: <27156ff7-4a8b-d428-0676-5eba002e3659@matthieu-moy.fr> Date: Wed, 6 Apr 2022 13:59:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH V1 1/1] contrib/vscode/: debugging with VS Code and gdb Content-Language: en-US To: COGONI Guillaume , matthieu.moy@univ-lyon1.fr Cc: derrickstolee@github.com, git.jonathan.bressat@gmail.com, git@vger.kernel.org References: <6f4b924d-0a13-b267-6766-a3620936b686@univ-lyon1.fr> <20220405224502.38544-1-cogoni.guillaume@gmail.com> <20220405224502.38544-2-cogoni.guillaume@gmail.com> From: Matthieu Moy In-Reply-To: <20220405224502.38544-2-cogoni.guillaume@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: 185.217.155.54 X-yulPa-Domain: mut-zose1.yulpa.io X-yulPa-Username: 185.217.155.54 Authentication-Results: yulpa.io; auth=pass smtp.auth=185.217.155.54@mut-zose1.yulpa.io X-yulPa-Outgoing-Class: ham X-yulPa-Outgoing-Evidence: Combined (0.03) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT9p8jXmdWHF5NEnstjZdTJhPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5wHzaN0z0Ug1scQLleVAb4gFAkmY/L1vp+E+d4RSLO7Kd2D dpTGFSx+xQOKH8nOUl2dumA+0IBxei0LAzz3JMDV47TzsmUDHzMkiNko+IXxSF1zjlrKRNh1Oj4H PDTzoRYDyHKfJKnhVIKX8Yq8nfvn1y4uVu1VH1tBUKHklzXsdf6ZM0JQVdm1T9bshXNP7sHhtIdB kUNQyNMiiqabnglhfQz2wXpSknCYhPgxD8NXJFY+5adZvWXoGLcQcb78Eui0IJNXBQXnMUXGoxGc h392Wa66MXU858iPFrZCv/0JMqbFc2bT9AciiKU48+dSpFeZAwEzl1K4UZNqPRuuhnzfOHylLosN P/1dYIrW9rhoJjCKx+YBIxO5jv+fSijtd+3yaKrk007dYZTthwA01fJk0EuxhEHVRSxhzQ28OWjf zM5xFf6sLi4v8CS69SSVWadhMKS+BEY488JlJ2GXtEI2WjjGRgbsyoXByRuX6y2O62BJsKCk/oqF gQJ9NXq38lYK2cgP2H8jmt3pFpGZxRZppbAJwM/6JpE3qD+FY7nYKRnUzkBVxCcZpnq/AH8RM8Pb zJ2VtQo+NXdgX4ZbcPelL3nlv4BEmp/1e8634spP3lNYUgHApX6hDqqfIBsx3wklAgFtRQ8XGWpf ZqIb07VbmgaOeS6Fyd/LpgZ3KAT2kxqZR3KVQgqF/fPYYAfEfsjSW+3CXz7XwJ838iy60FJmnVCH Sdboh0jhRR05nbLjqu0ZyYfGulk6NZQIslP0o1OyM5xPyor/JkNCr6eZ2uPt+5Xm+tcJd9z8U1Y2 bD5hr2w9T6D9UCKSJ1YY21dXPvgRFZ4oobg8BBg3Jq+ntzj0lCBt2ojdCe4u7I23BggnnBn6fOeT iFggYOEcmUggFkeus5lpN0RssbTbubg1FYxCIiXXICZYRPZNMgi1Ug7ltrqtc4nPlRbxwor3L1E1 g61uyYbkuVnIvR60i0hDjtD1mx3sX1QMTGj9cMllOHwI+L78/RyqFsVPwhvRA2PEzsIZTXrlO4gb zLzsw+8OYaZDGcCie3rThfAkQmDWjz3BPauDnONeMVij5A2eZiW1A6dAZV6BIj93KzacHpWyigBx WkD6cwdC2L7NmAFzi6Ln74YmiBwG7QcP0uvZj2eh8LkxL7hrJSk60SF3F6RYOYr2 X-Report-Abuse-To: spam@mut-mta1-se01a-fr.yulpa.io Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 4/6/22 00:45, COGONI Guillaume wrote: > The externalConsole=true setting is broken for many users (launching the > debugger with such setting results in VS Code waiting forever without > actually starting the debugger). Also, this setting is a matter of user > preference, and is arguably better set in a "launch" section in the > user-wide settings.json than hardcoded in our script. Remove the line to > use VS Code's default, or the user's setting. > > Add useful links in contrib/vscode/README.md to help the user to > configure VS Code and how to use the debugging feature. > > Add a mention to the README and the init.sh in Documentation/MyFirstContribution.txt > and a part to convince a newcomer that VS Code can help him. You may avoid the gender-specific formulation here, women should be as interested as men in the document. > --- a/Documentation/MyFirstContribution.txt > +++ b/Documentation/MyFirstContribution.txt > @@ -1265,3 +1265,14 @@ against the appropriate GitGitGadget/Git branch. > If you're using `git send-email`, you can use it the same way as before, but you > should generate your diffs from `..` and base your work on > `` instead of `master`. > + > +[[Bonus-useful-tools]] > +== Bonus - useful tools > + > +=== VS Code > + > +Using the integrate debugger can be particularly helpful to understand how Git works internally. > +It can be used to isolate some parts of code, with this you may be able to ask more precises > +question when you are stuck. (See getting-help sections). > +A script that creates the configuration files is available in contrib/vscode/init.sh. Useful links > +and explanation of how to use the script are available in contrib/vscode/README.md. I'd start with the last sentence. People already familiar with VS Code may find the first line boring, and stop reading before reaching the important information. With or without changes, this is Acked-by: Matthieu Moy -- Matthieu Moy https://matthieu-moy.fr/