git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: William Sprent <williams@unity3d.com>
To: Junio C Hamano <gitster@pobox.com>, Elijah Newren <newren@gmail.com>
Cc: "William Sprent via GitGitGadget" <gitgitgadget@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v3] fast-export: fix surprising behavior with --first-parent
Date: Wed, 22 Dec 2021 09:38:15 +0100	[thread overview]
Message-ID: <26316444-9fd2-8f69-10a4-2753c5455e53@unity3d.com> (raw)
In-Reply-To: <xmqq5yrhptqk.fsf@gitster.g>

On 21/12/2021 21.50, Junio C Hamano wrote:
> Elijah Newren <newren@gmail.com> writes:
> 
>>>       * Changed commit message to include the detailed description of the
>>>         problem area as suggested by Elijah. I went back and forth with my
>>>         self about whether the message needs some "lead in", but it ended up
>>>         getting long without adding much.
>>
>> If it feels weird quoting someone else so extensively and just using
>> their words for the commit message, we've used a "Commit-message-by:"
>> trailer in the past; that could be useful here.
> 
> I do not mind tweaking the copy I already have with "Helped-by"
> myself, while ...
> 
>> This version looks good to me:
>>
>> Reviewed-by: Elijah Newren <newren@gmail.com>
> 
> ... adding this one before merging the result to 'next'.
> 
> Thanks, both.

Either way works for me. I'm not too familiar with conventions around 
trailers. Both seem very reasonable to me.

Thanks a bunch for the help. :)

      reply	other threads:[~2021-12-22  8:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 11:28 [PATCH] fast-export: fix surprising behavior with --first-parent William Sprent via GitGitGadget
2021-11-23 13:07 ` Ævar Arnfjörð Bjarmason
2021-11-24 11:57   ` William Sprent
2021-11-23 19:14 ` Elijah Newren
2021-11-24 13:05   ` William Sprent
2021-11-24  0:41 ` Junio C Hamano
2021-11-24 13:05   ` William Sprent
2021-12-09  8:13 ` [PATCH v2] " William Sprent via GitGitGadget
2021-12-10  3:48   ` Elijah Newren
2021-12-10 21:55     ` Junio C Hamano
2021-12-10 22:02       ` Elijah Newren
2021-12-13 15:09     ` William Sprent
2021-12-14  0:31       ` Elijah Newren
2021-12-14 13:11         ` William Sprent
2021-12-16 16:23   ` [PATCH v3] " William Sprent via GitGitGadget
2021-12-21 18:47     ` Elijah Newren
2021-12-21 20:50       ` Junio C Hamano
2021-12-22  8:38         ` William Sprent [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26316444-9fd2-8f69-10a4-2753c5455e53@unity3d.com \
    --to=williams@unity3d.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).