git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Philippe Blain <levraiphilippeblain@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, lenaic@lhuard.fr
Subject: Re: lh/use-gnu-color-in-grep, was Re: What's cooking in git.git (Jan 2022, #01; Mon, 3)
Date: Tue, 4 Jan 2022 13:06:25 -0500	[thread overview]
Message-ID: <25d00bcb-3345-c221-6a38-593f23f942f3@gmail.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2201041458150.7076@tvgsbejvaqbjf.bet>

Hi Junio,

Le 2022-01-04 à 08:59, Johannes Schindelin a écrit :
> Hi Junio,
> 
> On Mon, 3 Jan 2022, Junio C Hamano wrote:
> 
>> * lh/use-gnu-color-in-grep (2021-12-16) 1 commit
>>   - grep: align default colors with GNU grep ones
>>
>>   The color palette used by "git grep" has been updated to match that
>>   of GNU grep.
>>
>>   On hold.
>>   cf. <xmqqh7b88b3o.fsf@gitster.g>
>>   source: <20211216115622.85506-1-lenaic@lhuard.fr>
> 
> FWIW I am in favor of adjusting Git's `grep` colors to GNU's version. From
> the users' perspective, it provides more consistency and less unexpected
> surprises.
> 

For what it's worth, I'm also in favor of that change. It's been in my todo list
of possible enhancements for a little while. I agree with Dscho that it's more consistent
for users to have the same default colors as GNU grep.

Cheers,
Philippe.

  reply	other threads:[~2022-01-04 18:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04  3:46 What's cooking in git.git (Jan 2022, #01; Mon, 3) Junio C Hamano
2022-01-04 12:23 ` jl/subtree-check-parents-argument-passing-fix, was " Johannes Schindelin
2022-01-04 20:05   ` Junio C Hamano
2022-01-04 13:59 ` lh/use-gnu-color-in-grep, " Johannes Schindelin
2022-01-04 18:06   ` Philippe Blain [this message]
2022-01-04 20:11     ` Junio C Hamano
2022-01-04 17:32 ` tb/midx-bitmap-corruption-fix (was: What's cooking in git.git (Jan 2022, #01; Mon, 3)) Taylor Blau
2022-01-04 20:13   ` tb/midx-bitmap-corruption-fix Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25d00bcb-3345-c221-6a38-593f23f942f3@gmail.com \
    --to=levraiphilippeblain@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=lenaic@lhuard.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).