From: Lars Schneider <larsxschneider@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <christian.couder@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Jonathan Tan <jonathantanmy@google.com>,
git <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Ben Peart <Ben.Peart@microsoft.com>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH] sub-process: print the cmd when a capability is unsupported
Date: Thu, 17 Aug 2017 23:34:33 +0200 [thread overview]
Message-ID: <25BB25E4-DD3F-46A5-8CD5-D784CBAB6F52@gmail.com> (raw)
In-Reply-To: <xmqqbmndgb8w.fsf@gitster.mtv.corp.google.com>
> On 17 Aug 2017, at 23:01, Junio C Hamano <gitster@pobox.com> wrote:
>
> Christian Couder <christian.couder@gmail.com> writes:
>
>> ... but I think we should then emphasize more in our test
>> scripts (maybe by giving a good example) and perhaps also in the doc
>> that the filters/sub-processes should really pay attention and not
>> output any capability that are not supported by Git.
>
> Oh, absolutely. If you know there is such a breakage in our test
> script, please do fix it.
>
> Thanks.
Junio's reasoning [1] is spot on from my point of view.
I intentionally did not add the negotiation to the test code to keep
the test as simple as possible. However, I wrote this in the
gitattributes docs [2]:
After the version negotiation Git sends a list of all capabilities that
it supports and a flush packet. Git expects to read a list of desired
capabilities, which must be a subset of the supported capabilities list,
and a flush packet as response:
Maybe we should revive "Documentation/technical/api-sub-process.txt" [3]
after all to explain these kind of things?
- Lars
[1] https://public-inbox.org/git/xmqq8tijpkrv.fsf@gitster.mtv.corp.google.com/
[2] https://github.com/git/git/blob/b3622a4ee94e4916cd05e6d96e41eeb36b941182/Documentation/gitattributes.txt#L408-L411
[3] https://public-inbox.org/git/20170807102136.30b23023@twelve2.svl.corp.google.com/
next prev parent reply other threads:[~2017-08-17 21:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 17:36 [PATCH] sub-process: print the cmd when a capability is unsupported Christian Couder
2017-08-15 18:17 ` Jonathan Tan
2017-08-16 0:22 ` Jonathan Nieder
2017-08-16 12:37 ` Christian Couder
2017-08-16 15:58 ` Junio C Hamano
2017-08-17 5:34 ` Christian Couder
2017-08-17 21:01 ` Junio C Hamano
2017-08-17 21:34 ` Lars Schneider [this message]
2017-08-17 21:49 ` Jonathan Tan
2017-08-15 19:00 ` Lars Schneider
2017-08-15 19:26 ` Junio C Hamano
2017-08-15 19:29 ` Christian Couder
2017-08-15 19:32 ` Christian Couder
2017-08-15 19:35 ` Lars Schneider
2017-08-15 20:30 ` Christian Couder
2017-08-15 19:01 ` Ben Peart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25BB25E4-DD3F-46A5-8CD5-D784CBAB6F52@gmail.com \
--to=larsxschneider@gmail.com \
--cc=Ben.Peart@microsoft.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).