From: Paul Eggert <eggert@cs.ucla.edu>
To: 60690@debbugs.gnu.org
Cc: "Tukusej’s Sirs" <tukusejssirs@protonmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"mega lith01" <megalith01@gmail.com>,
demerphq@gmail.com,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
pcre-dev@exim.org, gitster@pobox.com, git@vger.kernel.org
Subject: -P '\d' in GNU and git grep
Date: Mon, 3 Apr 2023 14:38:42 -0700 [thread overview]
Message-ID: <2554712d-e386-3bab-bc6c-1f0e85d999db@cs.ucla.edu> (raw)
I've recently done some bug-report maintenance about a set of GNU grep
bug reports related to whether whether "grep -P '\d'" should match
non-ASCII digits, and have some thoughts about coordinating GNU grep
with git grep in this department.
GNU Bug#62605[1] "`[\d]` does not work with PCRE" has been fixed on
Savannah's copy of GNU grep, and some sort of fix should appear in the
next grep release. However, I'm leaving the GNU grep bug report open for
now because it's related to Bug#60690[2] "[PATCH v2] grep: correctly
identify utf-8 characters with \{b,w} in -P" and to Bug#62552[3] "Bug
found in latest stable release v3.10 of grep". I merged these related
bug reports, and the oldest one, Bug#60690, is now the representative
displayed in the GNU grep bug list[4].
For this set of grep bug reports there's still a pending issue discussed
in my recent email[5], which proposes a patch so I've tagged Bug#60690
with "patch". The proposal is that GNU grep -P '\d' should revert to the
grep 3.9 behavior, i.e., that in a UTF-8 locale, \d should also match
non-ASCII decimal digits.
In researching this a bit further, I found that on March 23 Git disabled
the use of PCRE2_UCP in PCRE2 10.34 or earlier[6], due to a PCRE2 bug
that can cause a crash when PCRE2_UCP is used[7]. A bug fix[8] should
appear in the next PCRE2 release.
When PCRE2 10.35 comes out, it appears that 'git grep -P' will behave
like 'grep -P' only if GNU grep adopts something like the solution
proposed in [5].
[1]: https://bugs.gnu.org/62605
[2]: https://bugs.gnu.org/60690
[3]: https://bugs.gnu.org/62552
[4]: https://debbugs.gnu.org/cgi/pkgreport.cgi?package=grep
[5]: https://lists.gnu.org/archive/html/grep-devel/2023-04/msg00004.html
[6]:
https://github.com/git/git/commit/14b9a044798ebb3858a1f1a1377309a3d6054ac8
[7]:
https://lore.kernel.org/git/7E83DAA1-F9A9-4151-8D07-D80EA6D59EEA@clumio.com/
[8]:
https://github.com/git/git/commit/14b9a044798ebb3858a1f1a1377309a3d6054ac8
next prev reply other threads:[~2023-04-03 21:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 6:23 [PATCH] grep: correctly identify utf-8 characters with \{b,w} in -P Carlo Marcelo Arenas Belón
2023-01-08 6:39 ` Junio C Hamano
2023-01-08 15:52 ` [PATCH v2] " Carlo Marcelo Arenas Belón
2023-01-09 11:35 ` Ævar Arnfjörð Bjarmason
2023-01-09 18:40 ` bug#60690: [PATCH v2] grep: correctly identify utf-8 characters with \{b, w} " Paul Eggert
2023-01-09 19:51 ` Ævar Arnfjörð Bjarmason
2023-01-09 23:12 ` Paul Eggert
2023-01-10 4:49 ` [PATCH v2] grep: correctly identify utf-8 characters with \{b,w} " Carlo Arenas
2023-01-16 20:48 ` Junio C Hamano
2023-04-03 21:38 ` Paul Eggert [this message]
2023-04-04 3:30 ` bug#60690: -P '\d' in GNU and git grep Jim Meyering
2023-04-04 6:46 ` Paul Eggert
2023-04-04 15:31 ` Jim Meyering
2023-04-04 6:56 ` Carlo Arenas
2023-04-04 18:25 ` bug#60690: " Paul Eggert
2023-04-04 19:31 ` Junio C Hamano
2023-04-05 18:32 ` Paul Eggert
2023-04-05 19:04 ` Paul Eggert
2023-04-05 19:37 ` Junio C Hamano
2023-04-05 19:40 ` Jim Meyering
2023-04-05 20:03 ` Paul Eggert
2023-04-05 21:20 ` Carlo Arenas
2023-04-06 15:45 ` demerphq
2023-04-07 16:48 ` Paul Eggert
2023-04-06 13:39 ` demerphq
2023-04-07 19:00 ` Paul Eggert
2023-04-08 5:01 ` Carlo Arenas
2023-04-08 22:45 ` Paul Eggert
2023-01-17 10:51 ` [PATCH v3] grep: correctly identify utf-8 characters with \{b,w} in -P Carlo Marcelo Arenas Belón
2023-01-17 12:38 ` Ævar Arnfjörð Bjarmason
2023-01-17 15:19 ` Junio C Hamano
2023-01-18 7:35 ` Carlo Arenas
2023-01-18 11:49 ` Ævar Arnfjörð Bjarmason
2023-01-18 16:20 ` Junio C Hamano
2023-01-18 23:06 ` Ævar Arnfjörð Bjarmason
2023-01-18 23:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2554712d-e386-3bab-bc6c-1f0e85d999db@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=60690@debbugs.gnu.org \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=demerphq@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=megalith01@gmail.com \
--cc=pcre-dev@exim.org \
--cc=tukusejssirs@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).