From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Junio C Hamano <gitster@pobox.com>,
Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, Alex <agrambot@gmail.com>
Subject: Re: [PATCH v2] gpg-interface: use more status letters
Date: Wed, 28 Sep 2016 22:09:59 +0100 [thread overview]
Message-ID: <24ecc903-3e5a-47f6-f073-00a1c709d5e8@ramsayjones.plus.com> (raw)
In-Reply-To: <xmqqshsjiyn4.fsf@gitster.mtv.corp.google.com>
On 28/09/16 20:59, Junio C Hamano wrote:
> Michael J Gruber <git@drmicha.warpmail.net> writes:
>> + "X" for a good expired signature, or good signature made by an expired key,
>
> As an attempt to clarify that we cover both EXPSIG and EXPKEYSIG
> cases, I think this is good enough. I may have phrased the former
> slightly differently, though: "a good signature that has expired".
>
> I have no strong opinion if we want to stress that we cover both
> cases, though, which is I think what Ramsay's comment was about.
Kinda! ;-)
I'm not sure that it is a good idea to mash both EXPSIG and EXPKEYSIG
into one status letter, but I was also fishing for some information
about EXPSIG. I was only vaguely aware that a signature could expire
_independently_ of the key used to do the signing. Also, according to
https://www.gnupg.org/documentation/manuals/gnupg/Automated-signature-checking.html
for the EXPSIG case 'Note, that this case is currently not implemented.'
Hmm, I guess these are so closely related that a single status letter
is OK, but I think I would prefer your phrasing; namely:
"X" for a good signature that has expired, or a good signature made with an expired key,
[Although that is still a bit cumbersome.]
ATB,
Ramsay Jones
next prev parent reply other threads:[~2016-09-28 21:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 6:05 Request: Extra case for %G? format Alex
2016-09-26 11:53 ` Michael J Gruber
2016-09-26 17:18 ` Alex
2016-09-27 14:31 ` [PATCH] gpg-interface: use more status letters Michael J Gruber
2016-09-27 17:25 ` Junio C Hamano
2016-09-28 14:24 ` [PATCH v2] " Michael J Gruber
2016-09-28 15:10 ` Ramsay Jones
2016-09-28 19:59 ` Junio C Hamano
2016-09-28 21:09 ` Ramsay Jones [this message]
2016-09-30 9:41 ` Michael J Gruber
2016-09-30 16:16 ` Junio C Hamano
2016-10-06 21:43 ` Junio C Hamano
2016-10-10 12:59 ` Michael J Gruber
2016-10-10 17:58 ` Junio C Hamano
2016-10-12 13:04 ` [PATCH v3] " Michael J Gruber
2016-09-30 9:33 ` [PATCH v2] " Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24ecc903-3e5a-47f6-f073-00a1c709d5e8@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=agrambot@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).