From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wincent Colaiuta Subject: Re: Workflow question Date: Tue, 25 Sep 2007 21:50:34 +0200 Message-ID: <24DF51B9-1BF9-40C0-A1EF-80EF5072570F@wincent.com> References: <46F93A99.5080707@gmail.com> <46F95CCC.4080209@op5.se> <20070925193416.GB8564@coredump.intra.peff.net> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=ISO-8859-1; delsp=yes format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andreas Ericsson , Russ Brown , git@vger.kernel.org To: Jeff King X-From: git-owner@vger.kernel.org Tue Sep 25 21:50:58 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IaGQp-0004Sf-0H for gcvg-git-2@gmane.org; Tue, 25 Sep 2007 21:50:55 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752813AbXIYTus convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Sep 2007 15:50:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752408AbXIYTus (ORCPT ); Tue, 25 Sep 2007 15:50:48 -0400 Received: from wincent.com ([72.3.236.74]:42262 "EHLO s69819.wincent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190AbXIYTur convert rfc822-to-8bit (ORCPT ); Tue, 25 Sep 2007 15:50:47 -0400 Received: from [192.168.0.129] (localhost [127.0.0.1]) (authenticated bits=0) by s69819.wincent.com (8.12.11.20060308/8.12.11) with ESMTP id l8PJobmk003679; Tue, 25 Sep 2007 14:50:38 -0500 In-Reply-To: <20070925193416.GB8564@coredump.intra.peff.net> X-Mailer: Apple Mail (2.752.3) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: El 25/9/2007, a las 21:34, Jeff King escribi=F3: > On Tue, Sep 25, 2007 at 09:09:00PM +0200, Andreas Ericsson wrote: > >> We came to the same conclusion at our workplace. Email works =20 >> great, but >> it's faster and better to just walk over to your colleague and ask =20 >> what >> he/she thinks about something. > > One of the projects I am working on does things this way, but I =20 > have to > admit that I miss the email code-review process. There are often smal= l > fixups (stylistic, minor nits, "I would have done it this way...", =20 > etc) > that are worth pointing out at the time, but are more painful to go =20 > back > and correct much later. > > And documenting those discussions can really help other developers > besides the author and reviewer. Google has a pretty interesting internal code review system: Cheers, Wincent