From: "Philip Oakley" <philipoakley@iee.org>
To: "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Robert Clausecker" <fuz@fuz.su>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Alex Riesen" <raa.lkml@gmail.com>,
"Tanay Abhra" <tanayabh@gmail.com>
Subject: Re: Why doesn't git-fetch obey -c "remote.origin.url" on the command-line?
Date: Mon, 16 Jun 2014 13:48:02 +0100 [thread overview]
Message-ID: <24CCEC485B8B4C65B7785462369CBFF0@PhilipOakley> (raw)
In-Reply-To: 20140613075110.GH7908@sigill.intra.peff.net
From: "Jeff King" <peff@peff.net>
> On Fri, Jun 13, 2014 at 09:37:07AM +0200, Ævar Arnfjörð Bjarmason
> wrote:
>
>> On a git built from the master branch just now:
>>
>> $ ./git config remote.origin.url
>> https://code.google.com/p/git-core/
>> $ ./git -c
>> remote.origin.url=git://git.sourceforge.jp/gitroot/git-core/git.git
>> config remote.origin.url
>> git://git.sourceforge.jp/gitroot/git-core/git.git
>> $ GIT_TRACE=1 ./git -c
>> remote.origin.url=git://git.sourceforge.jp/gitroot/git-core/git.git
>> fetch 2>&1 | head -n 2
>> trace: built-in: git 'fetch'
>> trace: run_command: 'git-remote-https' 'origin'
>> 'https://code.google.com/p/git-core/'
>>
>> I'd expect this to try to fetch from the remote.origin.url I
>> specified
>> on the command-line, but for some reason fetch doesn't pick that up.
>> Isn't this a bug?
If anything, given Peff's clarification below, it's a bug in the way the
documentation has (not) communicated this trap for the unwary.
The question would then become "What warning should be given and where
should it/they be placed?" It should go within the documentation where
folk
look to check that the command innvocations were as expected. (It may
also be a 'common knowledge' issue [2]).
I already see that the git(1) man page for the '-c' option doesn't cover
the mult-value config option case.
The config-api suggests the common priority order where later values
override newer values.
I've done a little documentation patch to cover the current situation.
I've also copied in Robert (fuz) (from [1]) and Tanay (updating the
reading of config files).
>
> I think this is an alternate version of the report in [1].
>
> The short answer is: remote.*.url is a multi-valued config option, and
> you can only append to (not override) such options with "git -c". Try
> using insteadOf.
>
> -Peff
>
> [1] http://article.gmane.org/gmane.comp.version-control.git/250427
> --
[2] "It ain't what you don't know that gets you into trouble. It's what
you know for sure that just ain't so." Mark Twain
prev parent reply other threads:[~2014-06-16 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 7:37 Why doesn't git-fetch obey -c "remote.origin.url" on the command-line? Ævar Arnfjörð Bjarmason
2014-06-13 7:51 ` Jeff King
2014-06-16 12:48 ` Philip Oakley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24CCEC485B8B4C65B7785462369CBFF0@PhilipOakley \
--to=philipoakley@iee.org \
--cc=avarab@gmail.com \
--cc=fuz@fuz.su \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=raa.lkml@gmail.com \
--cc=tanayabh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).