From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 742731F4D7 for ; Fri, 10 Jun 2022 00:26:57 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VIwxPyLM"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345740AbiFJA0q (ORCPT ); Thu, 9 Jun 2022 20:26:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345563AbiFJA0g (ORCPT ); Thu, 9 Jun 2022 20:26:36 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06DD453E3B for ; Thu, 9 Jun 2022 17:26:35 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id q15so10021608wmj.2 for ; Thu, 09 Jun 2022 17:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:in-reply-to:references:from:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=cD/muVBT5qHdmfPGMSd6wZrzp4t9IcPydU/z6WwapO4=; b=VIwxPyLMA4IaynO+ABXBTWobYgptseJPcDKRySLXElIYMaSqR3yjg0dq5bsMC7yX9C 5y+Hounv6/hQ9QiuoV1a1FKD+xO3g1MCQ7Gl0+CAvpO/D8A6NZwsX2/GUwboR/t014Yd ya9oQPFUGGB99GaSww0GL3nxllqnfbJ8ZTcDzPC9634UHPTo5TXc2xvs0bZhkPZWGzca yeRcREGVIG4NJqR156KRb0hKFjQ4p8AVIE/Qt/OmLRMMO868RY0LmrBKbdW7bbxz5zlI K0GJd7JyRJGT652YRBmLME/sarMiDlZdEJV+3LkGc9GuxdTCx0KBqJypEIC/KzbjTPZE xYvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:in-reply-to:references:from:date :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=cD/muVBT5qHdmfPGMSd6wZrzp4t9IcPydU/z6WwapO4=; b=nXPjTYlC1Dz0HW4GsW0+XnrLiTWHf7F4QXR4N+6UQaBhWT5Pt2zLU4M0cjei4l2VuS IKnaeND00gyH3ocrHj8MdgzznDbuyaE1DNeLdN3266sYvkVQn+8xKz6xmo45Dir4onK3 jrmdP409EfoSjbfCTzbpEwtZcEQkWqndrikIKMjnCf8RLEzrYhZfC7d0lJ1DP+Ymu268 O5g1YCVYCHdkaULXlunsyD1ksSd3mEK3m0hE8o4r2kuE+eTmjYdeMaXg/KE6WbCi5w11 hbS1wcuWDpbwkLGnYwiJ72aWqWL8w+rEvmrxCcQTJTm8BT99oKtX05pPR0e2Wx/nCHxV 8M2Q== X-Gm-Message-State: AOAM5320rIz2qwgTpeiOJQvznTC6c4K/9Wtbdvvmnk7IUvPVVunp5wb2 A7dg+ltBuwH95PsquI1AL5CfLaIGADKro5X0 X-Google-Smtp-Source: ABdhPJy02+nLjWBQKtSwvrGGGqHVivCMCaX7qg36XPbOm5tjoMJOGKCzo++rW7S1raggfVE/7dmteA== X-Received: by 2002:a05:600c:1e89:b0:39c:5adb:6bf3 with SMTP id be9-20020a05600c1e8900b0039c5adb6bf3mr5705424wmb.91.1654820793282; Thu, 09 Jun 2022 17:26:33 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id j3-20020adfea43000000b0020d02262664sm25397914wrn.25.2022.06.09.17.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jun 2022 17:26:32 -0700 (PDT) Message-Id: <242d3399dfb4fb533ca6cdca452af2717c316672.1654820781.git.gitgitgadget@gmail.com> In-Reply-To: References: From: "Glen Choo via GitGitGadget" Date: Fri, 10 Jun 2022 00:26:21 +0000 Subject: [PATCH 8/8] submodule update: remove never-used expansion Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: =?UTF-8?Q?=C3=86var_Arnfj=C3=B6r=C3=B0?= Bjarmason , Atharva Raykar , Glen Choo , Glen Choo Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Glen Choo The `prefix` variable is never set, so this conditional expansion is always '' (which does nothing). Signed-off-by: Glen Choo --- git-submodule.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/git-submodule.sh b/git-submodule.sh index e9d93e91d21..2a6ffa8ac34 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -238,7 +238,6 @@ cmd_update() { git ${wt_prefix:+-C "$wt_prefix"} submodule--helper update \ ${wt_prefix:+--prefix "$wt_prefix"} \ - ${prefix:+--recursive-prefix "$prefix"} \ "$@" } -- gitgitgadget