From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, "Eli Schwartz" <eschwartz93@gmail.com>,
"René Scharfe" <l.s.r@web.de>,
"Konstantin Ryabitsev" <konstantin@linuxfoundation.org>,
"Michal Suchánek" <msuchanek@suse.de>,
"Raymond E . Pasco" <ray@ameretat.dev>,
demerphq <demerphq@gmail.com>, "Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [RFC PATCH 1/1] Document a fixed tar format for interoperability
Date: Mon, 06 Feb 2023 23:18:47 +0100 [thread overview]
Message-ID: <230206.86lela4ebq.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <20230205221728.4179674-2-sandals@crustytoothpaste.net>
On Sun, Feb 05 2023, brian m. carlson wrote:
> +The goals for this format are that it is first and foremost reproducible, that
> +identical trees produce identical results, that it is simple and easy to
> +implement correctly, and that it is useful in general. While we don't consider
> +functionality needs beyond Git's at the moment (such as hardlinks, xattrs, or
> +sparse files), there is intense interest in reproducible builds, and so it makes
> +sense to design something that can see general use for software interchange.
I think a goal should be to be bit-for-bit compatible with what we've
had historically, which...
> +Object IDs are not included in this version of the format because this produces
> +non-identical data when identical data is serialized with different hash
> +algorithms.
...this is inherntly at odds with. I had a longer comment about why I
think we can have our cake & eat it too at
https://lore.kernel.org/git/230131.86tu06rkbp.gmgdl@evledraar.gmail.com/
Maybe there are other changes in the proposed spec that put it at odds
with such a goal, it's unclear to me if this is the only difference.
But I don't see why we need bit-for-bit compatible output between SHA-1
and SHA-256 git repos for the reasons noted in the linked-to reply, and
removing this will remove a *really useful* aspect of our tar format,
which is that you can grab an arbitrary tarball, and see what commit
it's produced from.
Even if you want to retain SHA-1 and SHA-256 interop as far as tar is
concerned, an un-discussed alternative is to just stick the SHA-1 OID
into the SHA-256 archive.
For repos that are migrated we envision having such a bi-directional
mapping anyway.
And for those that started out as SHA-256, or where we no longer care
about compatibility with old SHA-1, we can just start including the
SHA-256 OID, as all compatibility concerns have gone away when we
stopped bothering to maintain the mapping, no?
> +|===
> +| Field Name | Value
> +
> +| `name` | the last path component if it fits; otherwise, `path.%d`
> +| `mode` | `0640` (regular file), `0777` (symbolic link), `0750` (directory)
> +| `uid` | `0`
> +| `gid` | `0`
> +| `size` | the size of the data in bytes for regular files if it fits; otherwise, `0`
> +| `mtime` | `0` (the Epoch)
> +| `chksum` | as specified in the standard
This is the nth reference to "the standard". I think this would be
improved by linking to it, isn't it
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/pax.html ?
next prev parent reply other threads:[~2023-02-06 22:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 22:17 [RFC PATCH 0/1] Canonical tar format for Git brian m. carlson
2023-02-05 22:17 ` [RFC PATCH 1/1] Document a fixed tar format for interoperability brian m. carlson
2023-02-06 21:08 ` Junio C Hamano
2023-02-07 22:34 ` brian m. carlson
2023-02-06 22:18 ` Ævar Arnfjörð Bjarmason [this message]
2023-02-07 23:01 ` brian m. carlson
2023-02-08 11:07 ` Ævar Arnfjörð Bjarmason
2023-02-08 23:52 ` brian m. carlson
2023-02-09 0:35 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=230206.86lela4ebq.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=demerphq@gmail.com \
--cc=eschwartz93@gmail.com \
--cc=git@vger.kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=l.s.r@web.de \
--cc=msuchanek@suse.de \
--cc=ray@ameretat.dev \
--cc=sandals@crustytoothpaste.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).