git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Teng Long <dyroneteng@gmail.com>
Cc: git@vger.kernel.org, tenglong.tl@alibaba-inc.com
Subject: Re: [PATCH 5/6] ls-tree: cleanup the redundant SPACE
Date: Thu, 12 Jan 2023 15:53:07 +0100	[thread overview]
Message-ID: <230112.86h6wv248r.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <20230112091135.20050-6-tenglong.tl@alibaba-inc.com>


On Thu, Jan 12 2023, Teng Long wrote:

> From: Teng Long <dyroneteng@gmail.com>
>
> An redundant space was found in ls-tree.c, which is no doubt
> a small change, but it might be OK to make a commit on its own.

No need to update this series for just this, but if you're doing an
update it would be nice to mention that this minor typo/unwanted syntax
has been there since 61fdbcf98b4 (ls-tree: migrate to parse-options,
2009-11-13).

I.e. to clarify that this is rather ancient, and not some fix-up for a
recent topic (or fixing things earlier in this topic itself).

> Signed-off-by: Teng Long <dyroneteng@gmail.com>
> ---
>  builtin/ls-tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/ls-tree.c b/builtin/ls-tree.c
> index a743959f2b3..72eb70823d5 100644
> --- a/builtin/ls-tree.c
> +++ b/builtin/ls-tree.c
> @@ -14,7 +14,7 @@
>  #include "parse-options.h"
>  #include "pathspec.h"
>  
> -static const  char * const ls_tree_usage[] = {
> +static const char * const ls_tree_usage[] = {
>  	N_("git ls-tree [<options>] <tree-ish> [<path>...]"),
>  	NULL
>  };


  reply	other threads:[~2023-01-12 15:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12  9:11 [PATCH 0/6] ls-tree.c: clean-up works Teng Long
2023-01-12  9:11 ` [PATCH 1/6] ls-tree: don't use "show_tree_data" for "fast" callbacks Teng Long
2023-01-12  9:11 ` [PATCH 2/6] ls-tree: use a "struct options" Teng Long
2023-01-12  9:11 ` [PATCH 3/6] ls-tree: fold "show_tree_data" into "cb" struct Teng Long
2023-01-12  9:11 ` [PATCH 4/6] ls-tree: make "line_termination" less generic Teng Long
2023-01-12  9:11 ` [PATCH 5/6] ls-tree: cleanup the redundant SPACE Teng Long
2023-01-12 14:53   ` Ævar Arnfjörð Bjarmason [this message]
2023-01-12  9:11 ` [PATCH 6/6] t3104: remove shift code in 'test_ls_tree_format' Teng Long
2023-01-12 14:56   ` Ævar Arnfjörð Bjarmason
2023-01-12 15:02 ` [PATCH 0/6] ls-tree.c: clean-up works Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=230112.86h6wv248r.gmgdl@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=dyroneteng@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=tenglong.tl@alibaba-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).