From: Ben Peart <peartben@gmail.com>
To: Derrick Stolee <stolee@gmail.com>,
Thomas Gummerer <t.gummerer@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: Git Test Coverage Report (Tuesday, Sept 25)
Date: Thu, 27 Sep 2018 11:21:03 -0400 [thread overview]
Message-ID: <225dc2e3-1aa0-ac19-26e6-59b54dfe871c@gmail.com> (raw)
In-Reply-To: <a7228cb5-5085-e1c7-0731-d37b19cdc3bf@gmail.com>
On 9/26/2018 2:54 PM, Derrick Stolee wrote:
> On 9/26/2018 2:43 PM, Thomas Gummerer wrote:
>> On 09/26, Derrick Stolee wrote:
>>> This is a bit tricky to do, but I will investigate. For some things, the
>>> values can conflict with each other (GIT_TEST_SPLIT_INDEX doesn't play
>>> nicely with other index options, I think).
>> Just commenting on this point. I think all the index options should
>> be playing nicely with eachother. I occasionally run the test suite
>> with some of them turned on, and if something failed that was always
>> an actual bug. The different modes can be used in different
>> combinations in the wild as well, so we should get them to interact
>> nicely in the test suite.
>
> Thanks! I'm still working out details on this, since the test suite is
> broken with GIT_TEST_COMMIT_GRAPH due to a verbosity issue [1], which I
> forgot until I ran the tests with the variable on.
>
> I'll re-run with these variables:
>
> GIT_TEST_SPLIT_INDEX=1
>
> GIT_TEST_FULL_IN_PACK_ARRAY=1
>
> GIT_TEST_OE_SIZE=128
>
> GIT_TEST_OE_DELTA_SIZE=128
>
> GIT_TEST_VALIDATE_INDEX_CACHE_ENTRIES=1
>
> GIT_TEST_FSMONITOR=$PWD/t/t7519/fsmonitor-all
>
> GIT_TEST_INDEX_VERSION=4
>
> GIT_TEST_PRELOAD_INDEX=1
>
> GIT_TEST_DISABLE_EOIE=1
>
> GIT_TEST_INDEX_THREADS=1
>
Because the test repos are so small (ie smaller than 10K files), the
test suite already executes as if GIT_TEST_INDEX_THREADS=1 is set (ie
single threaded). I added the test variable so that the multi-threading
code could be forced to execute in spite of the default minimum number
of files logic.
I'd recommend you set GIT_TEST_INDEX_THREADS=3 instead. (3 because 1
thread is used for loading the index extensions and we need 2 or more
threads available to exercise multi-threaded loading of the index entries).
> Thanks,
>
> -Stolee
>
> [1]
> https://public-inbox.org/git/60aae3d6-35b2-94fb-afd7-6978e935a4f7@gmail.com/
>
>
next prev parent reply other threads:[~2018-09-27 15:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 18:42 Git Test Coverage Report (Tuesday, Sept 25) Derrick Stolee
2018-09-25 21:12 ` Ben Peart
2018-09-26 10:43 ` Derrick Stolee
2018-09-26 10:56 ` Jason Pyeron
2018-09-26 11:03 ` Derrick Stolee
2018-09-26 18:43 ` Thomas Gummerer
2018-09-26 18:54 ` Derrick Stolee
2018-09-27 15:21 ` Ben Peart [this message]
2018-09-27 15:28 ` Derrick Stolee
2018-09-27 15:38 ` Ævar Arnfjörð Bjarmason
2018-09-26 17:59 ` Junio C Hamano
2018-09-26 18:44 ` Derrick Stolee
2018-09-27 15:14 ` Ben Peart
2018-09-27 15:16 ` Derrick Stolee
2018-09-26 18:58 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=225dc2e3-1aa0-ac19-26e6-59b54dfe871c@gmail.com \
--to=peartben@gmail.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).