From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Glen Choo <chooglen@google.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: ab/remove--super-prefix and -rc0 (was What's cooking in git.git (Nov 2022, #07; Tue, 29))
Date: Wed, 30 Nov 2022 20:43:10 +0100 [thread overview]
Message-ID: <221130.864jugi59l.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <kl6lh6ygqphu.fsf@chooglen-macbookpro.roam.corp.google.com>
On Wed, Nov 30 2022, Glen Choo wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Glen Choo <chooglen@google.com> writes:
>>
>>> Hm, it looks like ab/remove--super-prefix missed the preview release..
>>> Per the discussion ending at [1] I think my one-patch fix to "git
>>> fetch" [2] should have made it into the release (it's pretty low-risk
>>> and doesn't introduce too much churn to ab/remove--super-prefix). Is it
>>> too late for that?
>>
>> Nobody seemed to have commented on [2]. Is this fixing recent
>> regressions, or is it more like addressing an "if it hurts, do not
>> do it then" problem?
>
> Ævar did comment on the patch in [2], but unfortunately it happened on
> the thread ending at [1] (and others), so it's not easy to follow.
>
> It's solidly in the latter category. I don't think this has ever worked.
> c.f. https://lore.kernel.org/git/kl6lsfiivcau.fsf@chooglen-macbookpro.roam.corp.google.com/
>
>> The fact alone that these questions need to be asked _now_ is a good
>> indication that it is way too late for this cycle, I would have to
>> say.
>
> At any rate, we shouldn't be rushing review, so this is fair (though
> unfortunate). Let's continue counting on ab/remove--super-prefix and
> ignoring my one patch, then.
For my part I was waiting to see what Junio would do with
"ab/submodule-no-abspath", which is already in "next". Depending on
whether it's ejected or not I'd need to re-roll
"ab/remove--super-prefix" on top of a new "master", as it extends the
tests it added.
You noted in [1] that you strongly preferred seeing
"ab/submodule-no-abspath" ejected. I think you're right that the output
is a bit weird, but:
A. I think it's mainly odd/unintuitive for the recursive cases, I think
outside of our own test suite absorbing repositories recursively
almost never happens.
B. I think it's an improvement in the output compared to the absolute
paths we have now, especially for the common case of non-recursive.
C. Changing it made it easier to test it, which is how it ended up as a
supposedly quick prerequisite for "ab/remove--super-prefix": It's
otherwise changing a test blindspot.
D. As you note in [1] the data we'd need to pass around to make it
sensible (maybe it should always be consistent with "git mv -v"?)
would require passing more state around, some of which is tricky.
I'd prefer to just have it graduate as-is, and build
"ab/remove--super-prefix" on top. We can always further tweak the output
later.
But if you & Junio feel otherwise I think the best way forward would be
to eject both topics, and I'd submit a re-rolled
"ab/remove--super-prefix".
Either would work as a way forward. Just let me know what you both
prefer.
1. https://lore.kernel.org/git/kl6l7czmec10.fsf@chooglen-macbookpro.roam.corp.google.com/
next prev parent reply other threads:[~2022-11-30 19:58 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 9:40 What's cooking in git.git (Nov 2022, #07; Tue, 29) Junio C Hamano
2022-11-29 18:59 ` ab/remove--super-prefix and -rc0 (was What's cooking in git.git (Nov 2022, #07; Tue, 29)) Glen Choo
2022-11-30 3:43 ` Junio C Hamano
2022-11-30 18:14 ` Glen Choo
2022-11-30 19:43 ` Ævar Arnfjörð Bjarmason [this message]
2022-12-01 5:20 ` Junio C Hamano
2022-12-01 17:44 ` Glen Choo
2022-12-01 21:26 ` Junio C Hamano
2022-11-29 19:08 ` What's cooking in git.git (Nov 2022, #07; Tue, 29) Glen Choo
2022-11-30 3:45 ` Junio C Hamano
2022-11-30 18:08 ` Glen Choo
2022-11-29 21:16 ` ds/bundle-uri-4 (was Re: What's cooking in git.git (Nov 2022, #07; Tue, 29)) Derrick Stolee
2022-12-01 15:06 ` Derrick Stolee
2022-12-02 0:25 ` Junio C Hamano
2022-11-30 9:57 ` ab/cmake-nix-and-ci " Phillip Wood
2022-11-30 10:16 ` Ævar Arnfjörð Bjarmason
2022-12-01 14:23 ` Phillip Wood
2022-12-01 16:39 ` [PATCH] test-lib.sh: discover "git" in subdirs of "contrib/buildsystems/out" Ævar Arnfjörð Bjarmason
2022-12-01 16:48 ` Phillip Wood
2022-12-01 17:13 ` Ævar Arnfjörð Bjarmason
2022-12-01 23:00 ` Junio C Hamano
2022-12-02 15:14 ` Phillip Wood
2022-12-02 16:40 ` Ævar Arnfjörð Bjarmason
2022-12-02 23:10 ` Jeff King
2022-12-03 1:12 ` Junio C Hamano
2022-12-03 1:41 ` Ævar Arnfjörð Bjarmason
2022-12-05 9:15 ` Jeff King
2022-12-05 23:34 ` Taylor Blau
2022-12-05 23:46 ` Ævar Arnfjörð Bjarmason
2022-12-06 0:35 ` Taylor Blau
2022-12-06 1:36 ` Jeff King
2022-12-06 1:43 ` Ævar Arnfjörð Bjarmason
2022-12-06 2:05 ` Jeff King
2022-12-06 2:19 ` Ævar Arnfjörð Bjarmason
2022-12-06 3:52 ` Junio C Hamano
2022-12-06 9:54 ` Phillip Wood
2022-12-06 10:57 ` Ævar Arnfjörð Bjarmason
2022-12-08 9:29 ` ab/cmake-nix-and-ci, was " Johannes Schindelin
2022-12-08 11:34 ` Ævar Arnfjörð Bjarmason
2022-12-09 3:48 ` Junio C Hamano
2022-12-09 13:55 ` Ævar Arnfjörð Bjarmason
2022-12-07 1:00 ` Taylor Blau
2022-11-30 10:02 ` What's cooking in git.git (Nov 2022, #07; Tue, 29) Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=221130.864jugi59l.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).