From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Sean Allred via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Sean Allred <code@seanallred.com>,
Sean Allred <allred.sean@gmail.com>
Subject: Re: [PATCH v2 2/2] var: allow GIT_EDITOR to return null
Date: Fri, 25 Nov 2022 23:48:08 +0100 [thread overview]
Message-ID: <221125.86pmdamyv5.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <427cb7b55ac3fead1651cbad7318b9c0bb454b08.1669395151.git.gitgitgadget@gmail.com>
On Fri, Nov 25 2022, Sean Allred via GitGitGadget wrote:
> From: Sean Allred <allred.sean@gmail.com>
> +test_expect_success 'get GIT_EDITOR without configuration' '
> + (
> + sane_unset GIT_EDITOR &&
> + sane_unset VISUAL &&
> + sane_unset EDITOR &&
> + >expect &&
> + ! git var GIT_EDITOR >actual &&
Negate git with "test_must_fail", not "!", this would e.g. hide
segfaults. See t/README's discussion about it.
> + test_cmp expect actual
Looks like this should be:
test_must_fail git ... >out &&
test_must_be_empty out
> +test_expect_success 'get GIT_EDITOR with configuration and environment variable EDITOR' '
> + test_config core.editor foo &&
> + (
> + sane_unset GIT_EDITOR &&
> + sane_unset VISUAL &&
> + sane_unset EDITOR &&
> + echo foo >expect &&
> + EDITOR=bar git var GIT_EDITOR >actual &&
> + test_cmp expect actual
> + )
Perhaps these can all be factored into a helper to hide this repetition
in a function, but maybe not. E.g:
test_git_var () {
cat >expect &&
(
[...common part of subshell ...]
"$@" >actual &&
test_cmp expect actual
)
}
(untested)
next prev parent reply other threads:[~2022-11-25 22:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 20:22 [PATCH 0/3] Improve consistency of git-var Sean Allred via GitGitGadget
2022-11-24 20:22 ` [PATCH 1/3] var: do not print usage() with a correct invocation Sean Allred via GitGitGadget
2022-11-24 20:22 ` [PATCH 2/3] var: remove read_var Sean Allred via GitGitGadget
2022-11-25 5:48 ` Junio C Hamano
2022-11-24 20:22 ` [PATCH 3/3] var: allow GIT_EDITOR to return null Sean Allred via GitGitGadget
2022-11-25 16:52 ` [PATCH v2 0/2] Improve consistency of git-var Sean Allred via GitGitGadget
2022-11-25 16:52 ` [PATCH v2 1/2] var: do not print usage() with a correct invocation Sean Allred via GitGitGadget
2022-11-25 22:45 ` Ævar Arnfjörð Bjarmason
2022-11-26 13:19 ` Sean Allred
2022-11-25 16:52 ` [PATCH v2 2/2] var: allow GIT_EDITOR to return null Sean Allred via GitGitGadget
2022-11-25 22:48 ` Ævar Arnfjörð Bjarmason [this message]
2022-11-26 13:54 ` Sean Allred
2022-11-26 14:17 ` [PATCH v3 0/2] Improve consistency of git-var Sean Allred via GitGitGadget
2022-11-26 14:17 ` [PATCH v3 1/2] var: do not print usage() with a correct invocation Sean Allred via GitGitGadget
2022-11-26 14:17 ` [PATCH v3 2/2] var: allow GIT_EDITOR to return null Sean Allred via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=221125.86pmdamyv5.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=allred.sean@gmail.com \
--cc=code@seanallred.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).