From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 76D3E1F910 for ; Fri, 11 Nov 2022 15:07:47 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Sdi2mPrK"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234813AbiKKPHl (ORCPT ); Fri, 11 Nov 2022 10:07:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234197AbiKKPGg (ORCPT ); Fri, 11 Nov 2022 10:06:36 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A98FB858 for ; Fri, 11 Nov 2022 07:04:22 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id bj12so13065891ejb.13 for ; Fri, 11 Nov 2022 07:04:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to :user-agent:references:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=k42XQOlITmh9pD4Y3vJVdMyKOTJ8yXzsdykg4X8Cv6o=; b=Sdi2mPrKE8/9wjz0UHZ+ZeQuBQmPp5hq2bNJ25AJ9NFIBN/kt59sZScfo2PQNddlV9 BVyxzyWsTEIKJ/bO+ymIv/BI56TvyzyOHz2gR1g9QUr9T8I/fetSVwPYxCjApItKo11C /Rwr2v66T6zYIWBdmvZ9wZpEOmfxy6vNDLd2hQYWnfjHIRr+B1Z/SdDLku3kvZOW1j06 o7fgAYYInjVl+khX1Zd5UY7eq1cOufEx9DgjgwA/V7/6k1mbO1vhN0dAE+IGDse7X2x/ DJJ7xPVeJ12pILWK1uBlo+12URNyd4BUNY37scKRu/sauVBx1PamSycUtD5A+KcgTobU jRWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to :user-agent:references:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=k42XQOlITmh9pD4Y3vJVdMyKOTJ8yXzsdykg4X8Cv6o=; b=NBmprQOemb/KNyaQeJiW+rfBzJrnvQC200RaY7qBVAYCdClgdPeDFe/kHsTFWtoIh7 yygv4bgSbqqToHBufNy8830IV+btykoE3GNYyapjLXPG/rT+6LEONF1/2Jwix0qtvAZu vagFUE/24ZHnDOn2748nLWlY6OrUQZt/EAa3peZ2nQoxb+vDkLt7C4HTuUgsPYIu+Gzi 83ZbE645XO6pNxRWbXosE3EA6uXW2VP990h1Kp1a8Ri2nlW+070MO3PkQdcppFH8mgBo 5m8gh8+5WC5pogZsdVdCqqY+k5apeVkd/ovxrwOOl0UzRcirWWA8xT2+GZMM9V0rc8XB mK9g== X-Gm-Message-State: ANoB5pm2rNMa1u2ZU9aSpH5MxqEcs6n4RWQssHsRbzt+kl+vOaYjkBMk 2Poo9mr4TNLY6pUNFlyR82E= X-Google-Smtp-Source: AA0mqf4uRD2X0l7ydYREAPISy3l4q9P0x8DsQCU62ol1sXGTEaOyYRlpLnG21EIIgv3wLfWpgxw6dQ== X-Received: by 2002:a17:907:9949:b0:7ae:6746:f270 with SMTP id kl9-20020a170907994900b007ae6746f270mr2154199ejc.728.1668179060371; Fri, 11 Nov 2022 07:04:20 -0800 (PST) Received: from gmgdl (j84076.upc-j.chello.nl. [24.132.84.76]) by smtp.gmail.com with ESMTPSA id fg15-20020a1709069c4f00b0078d4ee47c82sm944275ejc.129.2022.11.11.07.04.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 07:04:19 -0800 (PST) Received: from avar by gmgdl with local (Exim 4.96) (envelope-from ) id 1otVZr-001wiL-0X; Fri, 11 Nov 2022 16:04:19 +0100 From: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason To: Eric Sunshine via GitGitGadget Cc: git@vger.kernel.org, Jeff King , Eric Sunshine Subject: Re: [PATCH 0/3] chainlint: emit line numbers alongside test definitions Date: Fri, 11 Nov 2022 16:03:01 +0100 References: User-agent: Debian GNU/Linux bookworm/sid; Emacs 27.1; mu4e 1.9.0 In-reply-to: Message-ID: <221111.861qq9o7m4.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Nov 09 2022, Eric Sunshine via GitGitGadget wrote: > This is atop "es/chainlint-output"[2]. > > (Note to self: Fortify against =C3=86var's nerd-snipe blacklist evasion.) My only regret is not asking for a pony :) This looks great, thanks. I read over the v2 (just commenting on the v1 CL for the above comment). I left a note about a potential follow-up about the color detection, but that's aside from the main change here, so I think it would be good to just get some version of your v2 as-is, unless you're super keen to spend more time fiddling with this...