From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: skrab-sah via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, skrab-sah <skrab.sah@gmail.com>
Subject: Re: [PATCH] abspath.h file is generated by makeheaders tool
Date: Wed, 12 Oct 2022 11:04:52 +0200 [thread overview]
Message-ID: <221012.86r0zdmmq1.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <pull.1353.git.git.1665563819680.gitgitgadget@gmail.com>
On Wed, Oct 12 2022, skrab-sah via GitGitGadget wrote:
> From: skrab-sah <skrab.sah@gmail.com>
>
> 1. We don't need to commit the file.
> 2. Added routin for abspath.c in Makefile.
> 3. Added tool support for makeheaders.
>
> Signed-off-by: skrab-sah <skrab.sah@gmail.com>
Not to repeat earlier feedback, but I really think you need to read &
internalize some of it rather than keep submitting these:
https://lore.kernel.org/git/?q=skrab-sah
Not commenting on much of this, except:
> @@ -1,5 +1,21 @@
> # The default target of this Makefile is...
> -all::
> +all:: hdr
> +
> +
> +# In parallel mode things goes up and down.
> +.NOTPARALLEL:
I think this really goes to what i was pointing out in
https://lore.kernel.org/git/220923.861qs25yr8.gmgdl@evledraar.gmail.com/
You're making very fundimental changes to a subsystem that your changes
themselves show you clearly don't understand that well.
Firstly, we have a lot of things in this makefile which don't require C
compilation, so putting a "hdr" as an "all" dependency is a no-go.
Secondly, you've globally marked our Makefile as "nothing here can run
in parallel", i.e. the single biggest slowdown it's ever had, presumably
because you got some dependency chain wrong, and are usin git as a
workaround.
next prev parent reply other threads:[~2022-10-12 9:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 8:36 [PATCH] abspath.h file is generated by makeheaders tool skrab-sah via GitGitGadget
2022-10-12 9:04 ` Ævar Arnfjörð Bjarmason [this message]
2022-10-13 16:40 ` [PATCH v2] " skrab-sah via GitGitGadget
2022-10-16 9:44 ` Skrab Sah
2022-10-16 13:13 ` Đoàn Trần Công Danh
2022-10-16 16:06 ` Skrab Sah
2022-10-16 16:51 ` Junio C Hamano
2022-10-17 0:34 ` Đoàn Trần Công Danh
2022-10-17 7:55 ` Skrab Sah
2022-10-17 18:39 ` Junio C Hamano
2022-10-18 0:52 ` Skrab Sah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=221012.86r0zdmmq1.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=skrab.sah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).