From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id E35251F54E for ; Thu, 8 Sep 2022 07:49:18 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="O+hdXwaE"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231136AbiIHHs4 (ORCPT ); Thu, 8 Sep 2022 03:48:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbiIHHsv (ORCPT ); Thu, 8 Sep 2022 03:48:51 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2731D51CF for ; Thu, 8 Sep 2022 00:48:50 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id gb36so36048539ejc.10 for ; Thu, 08 Sep 2022 00:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to :user-agent:references:date:subject:cc:to:from:from:to:cc:subject :date; bh=Y+5ZOOCpsoBAH3AMcWY0TCGhrJFK27mF6ZlYVb+CEO0=; b=O+hdXwaE5OIhzfp5YREWAVP0H0JhWZTBqBayOBY8/CF2QDd3pQXetvlAbHLoYe7IDY lwhaR2jftFkdbN8FyI7h0aArl0QyH6cE1w4WlVqsPgAUMlEGSQDE3cHGOW9/M2DreFwE bzrMcPHwyFDLzFakssQ21oQ3QIw+bMizo8T/eX+Cr7Z1VloGnM+w9Gq+bqp7jhitPf4A 62M/cebtGghaQQ+PGT2I45to7QdNLTtkK1J1A3zhAwaaDkBJBFqHrYJdDktw9I1AEOaN A1J2Eo3XzMaAp02XZCQLHtdmWdCzvtwqAs23zDyUggOANdqztxCh7m5B4nGk0mr6nlv1 s/Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to :user-agent:references:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date; bh=Y+5ZOOCpsoBAH3AMcWY0TCGhrJFK27mF6ZlYVb+CEO0=; b=K4mgwhQ0SIHcmeYjN3efQDrGjqPAQJyNcUzi8yI+fzdR+INT5WKmdGDS3ObgpJDyV1 +2NWugJE4n1fEa2X962K6p/vCsd2VINNxKg/p8/4EkYoAzBWtCmucamgngis7eQEsJdl Y/DpAuZ08jdKlevSiRDqC+3Z39nGAeX4YXeyA/jZde5xS6o0gGeyggc+TVPTogKFxWL4 UozXWuz/DusQA/9RYlMnyTMkTynp4VNVyul19OE238d3hPsoVA8gZOeHwyuAM4IrKMZq Bz6HXRRTfDT6puOj3uIDC2Rd4Mak5b59a4P/iOTFd31o/O1L8CGJSkuqkYs8bvMzq+lT O0jA== X-Gm-Message-State: ACgBeo2y4VOwF4odc2KVa/FNC6+Ye6rMi/rGER+eIdTPwSOCMiwF925A XigwVYXacPqngBidcAsH2u0= X-Google-Smtp-Source: AA6agR7WXWlhozuYH/KQLbIA7OW/GUEGDjdizvxtwXUuPowMoPFHSZb5pU3AgXLbxJOW7jymHcJX8Q== X-Received: by 2002:a17:907:2721:b0:741:56e5:6802 with SMTP id d1-20020a170907272100b0074156e56802mr5061806ejl.675.1662623329138; Thu, 08 Sep 2022 00:48:49 -0700 (PDT) Received: from gmgdl (dhcp-077-248-183-071.chello.nl. [77.248.183.71]) by smtp.gmail.com with ESMTPSA id a26-20020aa7d91a000000b0044ee18e5f79sm4411311edr.28.2022.09.08.00.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 00:48:48 -0700 (PDT) Received: from avar by gmgdl with local (Exim 4.96) (envelope-from ) id 1oWCHH-001HR4-29; Thu, 08 Sep 2022 09:48:47 +0200 From: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason To: Junio C Hamano Cc: git@vger.kernel.org, Victoria Dye , Taylor Blau , Emily Shaffer , Jonathan Nieder , John Cai Subject: Re: [PATCH 01/34] CodingGuidelines: update and clarify command-line conventions Date: Thu, 08 Sep 2022 09:46:55 +0200 References: User-agent: Debian GNU/Linux bookworm/sid; Emacs 27.1; mu4e 1.7.12 In-reply-to: Message-ID: <220908.865yhyl31c.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Sep 07 2022, Junio C Hamano wrote: > =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > >> + Use spacing around "|" token(s), but not on the inside of "[]()" >> + tokens: >> + Do: [-q | --quiet] >> + Don't: [-q|--quiet] > > It is unclear what "but not on ..." in the description and it is > still unclear with the examples. Does this mean > > Don't: ( -q | --quiet ) > > In other words, "on the inside of" above is meant to forbid spaces > immediately after opening or before closing a [] or () pair? Yes, that's what I was aiming for, and will obviously need to rephrase. I.e.: Don't: ( -q | --quiet) Do: (-q | --quiet) > Other than that, I think these are good guidelines to have. "Other than that" as in "let's fix that phrasing" or "let's not have that concept as part of these guidelines". I think the phrasing obviously needs to be fixed, here I was just attempting to cover a blind spot where the guidelines said nothing, and I picked whatever was the most common convention (as the rest of the series shows).