From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 6489E1F54E for ; Thu, 1 Sep 2022 12:35:58 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Y0LuEVa4"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232834AbiIAMfy (ORCPT ); Thu, 1 Sep 2022 08:35:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229781AbiIAMfx (ORCPT ); Thu, 1 Sep 2022 08:35:53 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81504A1A59 for ; Thu, 1 Sep 2022 05:35:51 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id r4so22342623edi.8 for ; Thu, 01 Sep 2022 05:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:user-agent:references:date :subject:cc:to:from:from:to:cc:subject:date; bh=uYsGNJR+5tCNZtxFG9ZUk7JnjWp1Ge3Uj7q83JLR/q8=; b=Y0LuEVa4od1Z74WlT5DDDUClS47VfMr6aKBYcfbUeF3oQqEYsQFKX2Tpbr+TRbkwy/ /LrgLTZmBihcgmmA3RVPaYLm9izPb6tdq+KgnELve68Qg5P1wLq43GDQqVoJjo1XAw7O QDTCx2A63jA4IcjtVKlaGOlyECRKvYbDuia9IPfuii5U3xNo/IGj0cOkbz5axzUK6TIK 372/NP4SACvbRQC25bjpmq+0OzEIP80PkVSFS1+s/oLF+VGcmqgMdQcNxJSJiyt/dsED p82c3f4toWfSX19desYCplcy5Fx1ylN//GA8VfSccrc3CraPfD/Axvc0XmxK9x9waEHn aK8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:user-agent:references:date :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=uYsGNJR+5tCNZtxFG9ZUk7JnjWp1Ge3Uj7q83JLR/q8=; b=MrAVcrE6tAh3ZXgQ4NX/Sb5m6eVgva2LOxqODnO4x3txjBUqNL19gfa60WDXvdL4cM eViiuLcSNXvpfN/tL5oFNVRDf6FWbFZSsj2efM6fzxn58MNzr9cN/yfq8G68JMJYvdHt h5buL2AgetHjF8vRBsi0SFc+NXW1Z/KTUMDgN5eAFT+44kWqTvelrYpAcCGOfQenA35O NztYGPVlk/gVIkQemnxHeK7V4gLTd2uTKgtWJpcBHksapF/yQl1txkYvKAJST7CRvbCZ TfN3OId/56OqrZFoDb8g8ZVeM93egVC0gER3qrcgGLEQmmlc5tVTzV7+4DcLmzz4xml9 0coA== X-Gm-Message-State: ACgBeo1oZvtfowFsoYHCVkKm35S4XssAj/q+o4R8WC5R2aSfx4NuiqZF wGmw+lJ6sNMkccJXrJrTvi3PBAC+UPG5qA== X-Google-Smtp-Source: AA6agR6Z/C2pXWyzeEPVfezFEp1Ljj/ISAtn95fY6n6ctVrE8E7u80LRCfpFrP0NBcbLb5ivf119Cw== X-Received: by 2002:a05:6402:2901:b0:448:3a53:c206 with SMTP id ee1-20020a056402290100b004483a53c206mr18922183edb.323.1662035749625; Thu, 01 Sep 2022 05:35:49 -0700 (PDT) Received: from gmgdl (dhcp-077-248-183-071.chello.nl. [77.248.183.71]) by smtp.gmail.com with ESMTPSA id lw5-20020a170906bcc500b00730a1c73288sm8322338ejb.49.2022.09.01.05.35.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Sep 2022 05:35:49 -0700 (PDT) Received: from avar by gmgdl with local (Exim 4.96) (envelope-from ) id 1oTjQC-0009oQ-17; Thu, 01 Sep 2022 14:35:48 +0200 From: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason To: Eric Sunshine via GitGitGadget Cc: git@vger.kernel.org, Jeff King , Elijah Newren , Fabian Stelzer , Johannes Schindelin , Eric Sunshine Subject: Re: [PATCH 02/18] chainlint.pl: add POSIX shell lexical analyzer Date: Thu, 01 Sep 2022 14:32:49 +0200 References: User-agent: Debian GNU/Linux bookworm/sid; Emacs 27.1; mu4e 1.7.12 In-reply-to: Message-ID: <220901.86fshbjmqj.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Sep 01 2022, Eric Sunshine via GitGitGadget wrote: > From: Eric Sunshine Just generally on this series: > + $tag =~ s/['"\\]//g; I think this would be a *lot* easier to read if all of these little regex decls could be split out into some "grammar" class, or other helper module/namespace. So e.g.: my $SCRIPT_QUOTE_RX = qr/['"\\]/; Then: > + return $cc if $cc =~ /^(?:&&|\|\||>>|;;|<&|>&|<>|>\|)$/; my $SCRIPT_WHATEVER_RX = qr/ ^(?: && | \|\| [...] /x; etc., i.e. we could then make use of /x to add inline comments to these.