From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: jk/unused-annotation + ab/unused-annotation (was: What's cooking in git.git (Aug 2022, #10; Tue, 30))
Date: Wed, 31 Aug 2022 10:00:50 +0200 [thread overview]
Message-ID: <220831.86fshcal32.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqilm9k0bc.fsf@gitster.g>
On Tue, Aug 30 2022, Junio C Hamano wrote:
> * jk/unused-annotation (2022-08-19) 11 commits
> (merged to 'next' on 2022-08-24 at 2174b8c75d)
> + is_path_owned_by_current_uid(): mark "report" parameter as unused
> + run-command: mark unused async callback parameters
> + mark unused read_tree_recursive() callback parameters
> + hashmap: mark unused callback parameters
> + config: mark unused callback parameters
> + streaming: mark unused virtual method parameters
> + transport: mark bundle transport_options as unused
> + refs: mark unused virtual method parameters
> + refs: mark unused reflog callback parameters
> + refs: mark unused each_ref_fn parameters
> + git-compat-util: add UNUSED macro
>
> Annotate function parameters that are not used (but cannot be
> removed for structural reasons), to prepare us to later compile
> with -Wunused warning turned on.
>
> Will revert; coccinelle cannot even parse the annotation correctly.
> cf. <Ywh7ppVFk6VK1Ybs@coredump.intra.peff.net>
> cf. <xmqqy1v7r3so.fsf@gitster.g>
> source: <Yv9gxqH6nK2KYnNj@coredump.intra.peff.net>
I see you did this already in 4f464a7b54a (Revert "Merge branch
'jk/unused-annotation' into next", 2022-08-30), per [1] and [2] you &
Jeff seemed to agree on my approach in [3] as a way forward.
The ab/unused-annotation in "seen" (not in this WC E-Mail) is a rebased
version of 1/2 of that series. Without the 2/2 [4] it won't catch the
accidental use of parameters.
Were you planning on picking that up, or would you like it submitted
separately? I know there were reservations about (ab)using "deprecated"
for this, but per the rationale in [4] and Jeff's [2] it seemed like
there was consensus to go that route.
1. https://lore.kernel.org/git/xmqqy1v7r3so.fsf@gitster.g/
2. https://lore.kernel.org/git/Ywh7ppVFk6VK1Ybs@coredump.intra.peff.net/
3. https://lore.kernel.org/git/cover-0.2-00000000000-20220825T170709Z-avarab@gmail.com/
4. https://lore.kernel.org/git/patch-2.2-0f603594e5e-20220825T170709Z-avarab@gmail.com/
next prev parent reply other threads:[~2022-08-31 8:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 19:17 What's cooking in git.git (Aug 2022, #10; Tue, 30) Junio C Hamano
2022-08-30 20:40 ` js/bisect-in-c, was " Johannes Schindelin
2022-08-31 8:00 ` Ævar Arnfjörð Bjarmason [this message]
2022-08-31 15:27 ` jk/unused-annotation + ab/unused-annotation (was: What's cooking in git.git (Aug 2022, #10; Tue, 30)) Jeff King
2022-08-31 16:23 ` jk/unused-annotation + ab/unused-annotation Junio C Hamano
2022-08-31 17:21 ` Ævar Arnfjörð Bjarmason
2022-08-31 8:29 ` js/add-p-diff-parsing-fix (was: What's cooking in git.git (Aug 2022, #10; Tue, 30)) Ævar Arnfjörð Bjarmason
2022-08-31 9:31 ` Phillip Wood
2022-08-31 19:54 ` Johannes Schindelin
2022-08-31 20:15 ` js/add-p-diff-parsing-fix Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220831.86fshcal32.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).