From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id B60C21F54E for ; Thu, 18 Aug 2022 18:46:01 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YDUVKGOR"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345543AbiHRSpI (ORCPT ); Thu, 18 Aug 2022 14:45:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345077AbiHRSo1 (ORCPT ); Thu, 18 Aug 2022 14:44:27 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2050ABCC18 for ; Thu, 18 Aug 2022 11:44:26 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id x21so2994863edd.3 for ; Thu, 18 Aug 2022 11:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:user-agent:references:date :subject:cc:to:from:from:to:cc; bh=/lc+EHTP9hwfZ0FryosE3e23YhxjMHNP/xTOLqADTbU=; b=YDUVKGORfNiXDHlyij/XTxE5m62iCyhryA6xTgqeVq/OZ7j56rW6Y1i+sMM3OPyk0/ tqB3yhsI7MF1Wx/n2XsRbf3Kgyf9U4r/cXXuoRjFR8FuCqrjzaUHsM5LWYESIK1HY51e +v7pyEYaIcRd0jyEt2RqJGoYry1Z7AOXu8rTse4nck0aNwIh6YhiRQ1e9gsUfu3c3J/m wARBbc1RsdYbcpOiC6ddxv6t0ApRAXEJvmpEhUccvgHtXDJT6FICwCtDI0Z2ABQ8l7fG V3bHOkun4Gs+nxlPRWzBj3Lfyxx2dZnr2nrQ/lRFKLH+ArrOrJcIwDUngsitUQuS7eFY e94Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:user-agent:references:date :subject:cc:to:from:x-gm-message-state:from:to:cc; bh=/lc+EHTP9hwfZ0FryosE3e23YhxjMHNP/xTOLqADTbU=; b=q6Gyo9NPM6enyZySyuB5260g+WkmNO6BrnP9II4a5toDcDtN/pyuDpIO/NUJeC7Cuq 08aM0GMb9Y3uByLxrwZ3PA5H6+1gTjy3CfgE+Z6+atlgED/10upaeeHjJ7GaW1mu7qgS 6LnnW3WXw1QX6WyrjKKwLrh5JEVI/L1TkJYbfm+JN2WZAsE4NOjfWS0llH03/fRVgpGf Wb48rGUv5qbdMyIp91mBFXH1mgCicUK2YlB4PDrjDPpqMIm7PjKaQ9c7K6s2rJuMo2wu QoxoOSUkwajrcscZAcS/1yfh+bF+uttX5F0/i7BxSmbUZDqrNa5Gfd5iThJ7RrCelK6t E3DQ== X-Gm-Message-State: ACgBeo0MQqr0V0NK53b6rpPE7HwfX3hO8kHbA0PZD6TLTXqRUUO5kn2Y 55iy0UJzqxQYqytHbZMgiQk= X-Google-Smtp-Source: AA6agR5V7GnWvc9gaH00BaDDccF8KdLMCNeS1QcyiijN9jycjWX9gp8WJYqmXVBSnCiL2zD8KPf+XA== X-Received: by 2002:a05:6402:254a:b0:43d:a634:a0ab with SMTP id l10-20020a056402254a00b0043da634a0abmr3221315edb.298.1660848264589; Thu, 18 Aug 2022 11:44:24 -0700 (PDT) Received: from gmgdl ([109.37.153.249]) by smtp.gmail.com with ESMTPSA id u17-20020a1709061db100b0073065767404sm1191409ejh.34.2022.08.18.11.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Aug 2022 11:44:23 -0700 (PDT) Received: from avar by gmgdl with local (Exim 4.96) (envelope-from ) id 1oOkVB-000Nbu-0b; Thu, 18 Aug 2022 20:44:21 +0200 From: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason To: Victoria Dye via GitGitGadget Cc: git@vger.kernel.org, derrickstolee@github.com, johannes.schindelin@gmx.de, Victoria Dye Subject: Re: [PATCH v4 07/11] builtin/diagnose.c: create 'git diagnose' builtin Date: Thu, 18 Aug 2022 20:43:22 +0200 References: User-agent: Debian GNU/Linux bookworm/sid; Emacs 27.1; mu4e 1.7.12 In-reply-to: Message-ID: <220818.86edxd8k8q.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Aug 12 2022, Victoria Dye via GitGitGadget wrote: > From: Victoria Dye > [...] This is correct: > +'git diagnose' [(-o | --output-directory) ] [(-s | --suffix) ] ... > + N_("git diagnose [-o|--output-directory ] [-s|--suffix ]"), But this is not, it's missing () around the short v.s. long option, and we should have a space surrounding the "|" as well.