From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 7CAD51F54E for ; Thu, 4 Aug 2022 07:58:30 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="iOM1En0d"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239402AbiHDHzb (ORCPT ); Thu, 4 Aug 2022 03:55:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239384AbiHDHzX (ORCPT ); Thu, 4 Aug 2022 03:55:23 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73E241276F for ; Thu, 4 Aug 2022 00:55:21 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id e13so5328241edj.12 for ; Thu, 04 Aug 2022 00:55:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to :user-agent:references:date:subject:cc:to:from:from:to:cc; bh=WAIGEO480DxzCRb1+m3LHtcE0+qZUPTDYoJC6jfcp14=; b=iOM1En0daMFrUg1f3kojFqyAN7xgCM5Vf7dFj0Wg9zkYBM2PaljPXFeFbwvDOFz+Mj glD+XEUjtsAvJtIw5BAdSOw+ACeoQYT72NxrB+TiqDGlXKaCGftdLmA0MFzlBjYms5np JFA3pDSvVZrMLdti3tIq/9PJcEFYs+mtbjnEEVxge/4giMLSzApAT2zI5q0C/wwspFkM md9SFvyU9ZMpGnJzB7fJpfQvtHO45NvuxnS5dtQi8QfLzEYFVOhETU7Pu+CPp+ea5rv1 Ny+VKaQ/QCylyU2WTs1MCEwX+NdNxKzz6U7Y/1Xmb5lWVr6JVm2tLf0MjmGnWQtp9el5 iAUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to :user-agent:references:date:subject:cc:to:from:x-gm-message-state :from:to:cc; bh=WAIGEO480DxzCRb1+m3LHtcE0+qZUPTDYoJC6jfcp14=; b=eE/jj2qPMy0Kx8WbYyrRaEnyaLS2isNreeCXeU76y7B59KUyFo5q4KlgDmcr3T1c8b 5MaYq1Hzn1Tw/AACTNPT+4nRSzsVSDIXmG3nevl8Y0hUTf0p2uOwlTwoO1NOYpogd2R2 UT0XMJYRQEsczu13DEBpC1BXzbl2g4IY3p9h7xm7q8RYySYNFWkYtc/hLkg3sMmc3YXG Xbsbv7B9XWPL4V84juHXNl6sRQvKBFd6LiSHjxmaWj9CQYTaUQmtBC10S6baBU9tDu1D dZncyHS+UTScTttuNQZEjh26fLQWgPkst21mbSC/MMolRr4ZbSXiqWRTwB4maobf8qFb pkOA== X-Gm-Message-State: ACgBeo1R7yXK/n/AR5TopzNdbEst3hh5HuOEUzANrDSxcK0Tng4ZJtB4 iE7z0qGp66/x01EXh812KRvn1wq/bm4= X-Google-Smtp-Source: AA6agR5cpzWXM0IU/+uR2Zu5U3o7JY99Lf9lT/0evvCijnhPhyzeC0xFgOZeM6WzHMP5EVM/bo9o7g== X-Received: by 2002:a05:6402:23a1:b0:43d:9477:4d57 with SMTP id j33-20020a05640223a100b0043d94774d57mr772639eda.168.1659599719570; Thu, 04 Aug 2022 00:55:19 -0700 (PDT) Received: from gmgdl (dhcp-077-248-183-071.chello.nl. [77.248.183.71]) by smtp.gmail.com with ESMTPSA id kx16-20020a170907775000b00724261b592esm36051ejc.186.2022.08.04.00.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Aug 2022 00:55:18 -0700 (PDT) Received: from avar by gmgdl with local (Exim 4.96) (envelope-from ) id 1oJVhO-009g54-0l; Thu, 04 Aug 2022 09:55:18 +0200 From: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason To: Junio C Hamano Cc: git@vger.kernel.org, Jeff King , Eric Sunshine Subject: Re: [PATCH v3 4/6] log: refactor "rev.pending" code in cmd_show() Date: Thu, 04 Aug 2022 09:51:41 +0200 References: User-agent: Debian GNU/Linux bookworm/sid; Emacs 27.1; mu4e 1.7.12 In-reply-to: Message-ID: <220804.865yj8e93t.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Aug 03 2022, Junio C Hamano wrote: > =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > >> Refactor the juggling of "rev.pending" and our replacement for it >> amended in the preceding commit so that: >> ... >> Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason >> Helped-by: Jeff King > > List trailer lines chronologically, please. Willdo. > I may have said this earlier, but once we start using the "prepare a > blank one, copy it to clear another" pattern, we should stop using > memcpy() and use structure assignment, especially if we are trying to > make our intent clear. Yeah, I saw that. I took it as we should consider changing this more generally (e.g. with coccicheck etc.). This was mentioned in one of the original threads about the memcpy() idiom, but IIRC there was some reason to think that it wasn't as widely supported, or in any case we'd want to re-rest that the compilers we care about similarly optimize it. So I think it's best to just use the more widely used pattern for now, and if we'd like change them all in some follow-up change...