From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: js/bisect-in-c, was Re: What's cooking in git.git (Jul 2022, #03; Mon, 11)
Date: Thu, 14 Jul 2022 02:22:13 +0200 [thread overview]
Message-ID: <220714.86fsj4356l.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqtu7ldmrz.fsf@gitster.g>
On Wed, Jul 13 2022, Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> I'm not claiming that we always use 129 when we're fed bad options etc.,
>> but rather that that's what parse_options() does, so at this point most
>> commands do that consistently.
>>
>> ./git --blah >/dev/null 2>&1; echo $?
>> 129
>> ./git status --blah >/dev/null 2>&1; echo $?
>> 129
>>
>> But yes, you can find exceptions still, e.g. try that with "git log" and
>> it'll return 128.
>
> Yup, that was my understanding as well. We may have existing
> breakage that we shouldn't be actively imitating when we do not have
> to.
>
>> Which, I'm not saying should hold this series up, but just that having
>> reviewed it for a few iterations I'm not comfortable saying we haven't
>> missed something else, and given the nature of the past whack-a-mole
>> fixes it looks like you haven't really looked it either.
>
> "We haven't missed" is not something we can comfortably say, ever,
> aobut a series with any meaningful size. I am not so worried about
> it, if it is your only worries. Would it make it less likely to
> have introduced unintended bugs if we find a way to keep using
> parse-options?
I started writing something here, but found myself rewriting the last 3
paragraphs of [1] seen in the context below, so I'll just refer to that.
FWIW ejecting 11-14/16, i.e. these patches:
- Turn `git bisect` into a full built-in
- bisect: move even the command-line parsing to `bisect--helper`
- bisect: teach the `bisect--helper` command to show the correct usage strings
- bisect--helper: return only correct exit codes in `cmd_*()`
Yields a result that I've got no concerns about whatsoever, and reduces
the diffstat from:
7 files changed, 110 insertions(+), 207 deletions(-)
To just:
4 files changed, 71 insertions(+), 67 deletions(-)
Which I think might be worth considering, similar to how the submodule
migration is happening in multi-step fashion. I.e. advancing the parts
that don't migrate it away from parse_options(), since I showed a way to
keep using it in [1] (while changing less code).
Or just merge it down, up to you :)
>> I'm referring to e.g. the thread ending at [3], where I pointed out that
>> "git <subcommand> -h" was broken, you apparently tested one of the
>> subcommands and concluded it wasn't broken, but clearly not all of them.
>>
>> Which, I'd be less concerned about if as pointed out in [1] we don't
>> have entirte bisect sub-commands that don't have any test coverage at
>> all, so whatever coverage we have probably has major gaps.
>>
>> 1. https://lore.kernel.org/git/220627.86mtdxhnwk.gmgdl@evledraar.gmail.com/
>> 2. https://lore.kernel.org/git/220523.865ylwzgji.gmgdl@evledraar.gmail.com/
>> 3. https://lore.kernel.org/git/220225.86ilt27uln.gmgdl@evledraar.gmail.com/
next prev parent reply other threads:[~2022-07-14 0:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 17:07 What's cooking in git.git (Jul 2022, #03; Mon, 11) Junio C Hamano
2022-07-12 22:19 ` gc/bare-repo-discovery (was Re: What's cooking in git.git (Jul 2022, #03; Mon, 11)) Glen Choo
2022-07-13 16:29 ` Junio C Hamano
2022-07-14 16:17 ` Johannes Schindelin
2022-07-14 18:27 ` Junio C Hamano
2022-07-12 22:29 ` What's cooking in git.git (Jul 2022, #03; Mon, 11) Philip Oakley
2022-07-13 16:31 ` Junio C Hamano
2022-07-12 23:28 ` ac/bitmap-lookup-table (was: Re: What's cooking in git.git (Jul 2022, #03; Mon, 11)) Taylor Blau
2022-07-13 16:42 ` ac/bitmap-lookup-table Junio C Hamano
2022-07-13 11:10 ` js/bisect-in-c, was Re: What's cooking in git.git (Jul 2022, #03; Mon, 11) Johannes Schindelin
2022-07-13 11:18 ` Ævar Arnfjörð Bjarmason
2022-07-13 16:01 ` Junio C Hamano
2022-07-14 0:22 ` Ævar Arnfjörð Bjarmason [this message]
2022-07-14 19:35 ` Johannes Schindelin
2022-07-14 21:09 ` Ævar Arnfjörð Bjarmason
2022-08-16 8:51 ` Johannes Schindelin
2022-08-17 0:49 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220714.86fsj4356l.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).