From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Glen Choo <chooglen@google.com>
Subject: gc/submodule-use-super-prefix & ab/submodule-cleanup (was: What's cooking in git.git (Jul 2022, #01; Fri, 1))
Date: Mon, 04 Jul 2022 10:12:19 +0200 [thread overview]
Message-ID: <220704.8635fhb84h.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqo7y85t44.fsf@gitster.g>
On Fri, Jul 01 2022, Junio C Hamano wrote:
> * gc/submodule-use-super-prefix (2022-06-30) 8 commits
> - submodule--helper: remove display path helper
> - submodule--helper update: use --super-prefix
> - submodule--helper: remove unused SUPPORT_SUPER_PREFIX flags
> - submodule--helper: use correct display path helper
> - submodule--helper: don't recreate recursive prefix
> - submodule--helper update: use display path helper
> - submodule--helper tests: add missing "display path" coverage
> - Merge branch 'ab/submodule-cleanup' into gc/submodule-use-super-prefix
> (this branch uses ab/submodule-cleanup.)
>
> Another step to rewrite more parts of "git submodule" in C.
>
> Will merge to 'next'?
> source: <20220701021157.88858-1-chooglen@google.com>
[...]
> * ab/submodule-cleanup (2022-06-28) 12 commits
> - git-sh-setup.sh: remove "say" function, change last users
> - git-submodule.sh: use "$quiet", not "$GIT_QUIET"
> - submodule--helper: eliminate internal "--update" option
> - submodule--helper: understand --checkout, --merge and --rebase synonyms
> - submodule--helper: report "submodule" as our name in some "-h" output
> - submodule--helper: rename "absorb-git-dirs" to "absorbgitdirs"
> - submodule update: remove "-v" option
> - submodule--helper: have --require-init imply --init
> - git-submodule.sh: remove unused top-level "--branch" argument
> - git-submodule.sh: make the "$cached" variable a boolean
> - git-submodule.sh: remove unused $prefix variable
> - git-submodule.sh: remove unused sanitize_submodule_env()
> (this branch is used by gc/submodule-use-super-prefix.)
>
> Further preparation to turn git-submodule.sh into a builtin.
>
> Will merge to 'next'.
> source: <cover-v4-00.12-00000000000-20220628T095914Z-avarab@gmail.com>
Thanks, with regards to gc/submodule-use-super-prefix that series gets
my enthusiastic (if it helps):
Reviewed-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Likewise the ab/submodule-cleanup parent topic has Glen's:
Reviewed-by: Glen Choo <chooglen@google.com>
Per [1] and [2]. I.e. the latest is the v4, but the Reviewed-By was
given to v3 in [1], and [4] notes on v4 that the one remaining concern
was addressed.
Thanks both, it's great to see us this close to getting rid of another
*.sh built-in. I plan to submit the migration to the builtin/submodule.c
after these two land, possibly after some memory leak fixes to
builtin/submodule--helper.c.
1. https://lore.kernel.org/git/kl6lh74aivc6.fsf@chooglen-macbookpro.roam.corp.google.com/
2. https://lore.kernel.org/git/kl6l1qv8ivcs.fsf@chooglen-macbookpro.roam.corp.google.com/
next prev parent reply other threads:[~2022-07-04 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 23:08 What's cooking in git.git (Jul 2022, #01; Fri, 1) Junio C Hamano
2022-07-04 8:12 ` Ævar Arnfjörð Bjarmason [this message]
2022-07-06 16:57 ` gc/submodule-use-super-prefix & ab/submodule-cleanup (was: What's cooking in git.git (Jul 2022, #01; Fri, 1)) Glen Choo
2022-07-04 13:15 ` ds/rebase-update-re (was " Derrick Stolee
2022-07-04 15:59 ` Junio C Hamano
2022-07-04 16:58 ` Elijah Newren
2022-07-04 20:17 ` Derrick Stolee
2022-07-05 1:31 ` en/merge-dual-dir-renames-fix (Was: " Elijah Newren
2022-07-06 17:56 ` gc/bare-repo-discovery (was " Glen Choo
2022-07-06 22:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220704.8635fhb84h.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).