Test Failure t5516.113 RE: [ANNOUNCE] Git v2.37.0-rc0

Test Failure t5516.113 RE: [ANNOUNCE] Git v2.37.0-rc0

[rsbecker]

On June 13, 2022 9:46 PM, Junio C Hamano wrote:
>An early preview release Git v2.37.0-rc0 is now available for testing at the usual
>places.  It is comprised of 339 non-merge commits since v2.36.0, contributed by 59
>people, 18 of which are new faces [*].  There are a few topics that we may want to
>merge before the final release, which will be in -rc1 that is planned to be tagged at
>around the end of the week.

This one keeps showing up occasionally. I am not sure why, but I am not certain bash likes ! grep. This only happens on our NonStop x86 build, which is a more recent platform than the ia64, where the construct succeeds. Have we not moved away from that?

not ok 113 - fetch warns or fails when using username:password
#	
#		message="URL 'https://username:<redacted>@localhost/' uses plaintext credentials" &&
#		test_must_fail git -c fetch.credentialsInUrl=allow fetch https://username:password@localhost 2>err &&
#		! grep "$message" err &&
#	
#		test_must_fail git -c fetch.credentialsInUrl=warn fetch https://username:password@localhost 2>err &&
#		grep "warning: $message" err >warnings &&
#		test_line_count = 3 warnings &&
#	
#		test_must_fail git -c fetch.credentialsInUrl=die fetch https://username:password@localhost 2>err &&
#		grep "fatal: $message" err >warnings &&
#		test_line_count = 1 warnings &&
#	
#		test_must_fail git -c fetch.credentialsInUrl=die fetch https://username:@localhost 2>err &&
#		grep "fatal: $message" err >warnings &&
#		test_line_count = 1 warnings
#	

Thanks,
Randall

Re: Test Failure t5516.113 RE: [ANNOUNCE] Git v2.37.0-rc0

[Ævar Arnfjörð Bjarmason]

On Wed, Jun 15 2022, rsbecker@nexbridge.com wrote:

> On June 13, 2022 9:46 PM, Junio C Hamano wrote:
>>An early preview release Git v2.37.0-rc0 is now available for testing at the usual
>>places.  It is comprised of 339 non-merge commits since v2.36.0, contributed by 59
>>people, 18 of which are new faces [*].  There are a few topics that we may want to
>>merge before the final release, which will be in -rc1 that is planned to be tagged at
>>around the end of the week.
>
> This one keeps showing up occasionally. I am not sure why, but I am
> not certain bash likes ! grep. This only happens on our NonStop x86
> build, which is a more recent platform than the ia64, where the
> construct succeeds. Have we not moved away from that?
>
> not ok 113 - fetch warns or fails when using username:password
> #	
> #		message="URL 'https://username:<redacted>@localhost/' uses plaintext credentials" &&
> #		test_must_fail git -c fetch.credentialsInUrl=allow fetch https://username:password@localhost 2>err &&
> #		! grep "$message" err &&
> #	
> #		test_must_fail git -c fetch.credentialsInUrl=warn fetch https://username:password@localhost 2>err &&
> #		grep "warning: $message" err >warnings &&
> #		test_line_count = 3 warnings &&
> #	
> #		test_must_fail git -c fetch.credentialsInUrl=die fetch https://username:password@localhost 2>err &&
> #		grep "fatal: $message" err >warnings &&
> #		test_line_count = 1 warnings &&
> #	
> #		test_must_fail git -c fetch.credentialsInUrl=die fetch https://username:@localhost 2>err &&
> #		grep "fatal: $message" err >warnings &&
> #		test_line_count = 1 warnings
> #	

I've submitted
https://lore.kernel.org/git/cover-0.1-00000000000-20220615T103609Z-avarab@gmail.com
to fix this (but spotted this thread just afterwards, I fixed the bug
yesterday).

This happens on all platforms, you just happen to have NO_CURL=Y only in
your nonstop build.