From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: jc/http-clear-finished-pointer (was: What's cooking in git.git (May 2022, #07; Wed, 25))
Date: Thu, 26 May 2022 20:51:23 +0200 [thread overview]
Message-ID: <220526.86v8ts3z2k.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqzgj41ya2.fsf@gitster.g>
On Thu, May 26 2022, Junio C Hamano wrote:
> * jc/http-clear-finished-pointer (2022-05-24) 1 commit
> - http.c: clear the 'finished' member once we are done with it
>
> Meant to go with js/ci-gcc-12-fixes
>
> Will merge to 'next'?
> source: <xmqqczgqjr8y.fsf_-_@gitster.g>
The end of the proposed commit message says:
[...]Clear the finished member before the control leaves the
function, which has a side effect of unconfusing compilers like
recent GCC 12 that is over-eager to warn against such an assignment.
I cannot reproduce this suppressing the warning as noted in past
exchanges, it's not affected by this "clear if we set it" pattern. It
needs to be unconditionally cleared.
So I don't think this actively makes anything worse, but I don't think
it's doing what you're expecting it to do either.
next prev parent reply other threads:[~2022-05-26 18:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 8:41 What's cooking in git.git (May 2022, #07; Wed, 25) Junio C Hamano
2022-05-26 16:02 ` Victoria Dye
2022-05-26 17:23 ` Junio C Hamano
2022-05-26 18:02 ` Ævar Arnfjörð Bjarmason
2022-05-26 18:30 ` Victoria Dye
2022-05-26 18:40 ` Ævar Arnfjörð Bjarmason
2022-05-26 23:10 ` Junio C Hamano
2022-05-26 18:08 ` tb/cruft-packs (was Re: What's cooking in git.git (May 2022, #07; Wed, 25)) Taylor Blau
2022-05-26 18:10 ` What's cooking in git.git (May 2022, #07; Wed, 25) Taylor Blau
2022-05-26 20:17 ` Junio C Hamano
2022-05-26 18:11 ` tb/midx-race-in-pack-objects (was Re: What's cooking in git.git (May 2022, #07; Wed, 25)) Taylor Blau
2022-05-26 18:49 ` sg/build-gitweb (was: " Ævar Arnfjörð Bjarmason
2022-05-26 19:06 ` sg/build-gitweb Junio C Hamano
2022-05-26 18:51 ` Ævar Arnfjörð Bjarmason [this message]
2022-05-26 19:37 ` Re* jc/http-clear-finished-pointer Junio C Hamano
2022-05-27 20:41 ` Johannes Schindelin
2022-05-27 21:35 ` Junio C Hamano
2022-06-01 7:26 ` Ævar Arnfjörð Bjarmason
2022-06-01 15:48 ` Junio C Hamano
2022-05-26 18:54 ` js/bisect-in-c (was: What's cooking in git.git (May 2022, #07; Wed, 25)) Ævar Arnfjörð Bjarmason
2022-05-26 19:38 ` js/bisect-in-c Junio C Hamano
2022-05-26 20:00 ` js/bisect-in-c Junio C Hamano
2022-05-27 12:52 ` js/bisect-in-c Ævar Arnfjörð Bjarmason
2022-05-26 18:57 ` jx/l10n-workflow-change (was: What's cooking in git.git (May 2022, #07; Wed, 25)) Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220526.86v8ts3z2k.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).