From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] ci: lock "pedantic" job into fedora 35 and other cleanup
Date: Fri, 15 Apr 2022 15:17:09 +0200 [thread overview]
Message-ID: <220415.86wnfqbhsf.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <20220415123922.30926-1-carenas@gmail.com>
On Fri, Apr 15 2022, Carlo Marcelo Arenas Belón wrote:
> Fedora 36 is scheduled to be released in Apr 19th, but it includes
> a prerelease of gcc 12 that has known issues[1] with our codebase
> and therefore requires extra changes to not break a DEVELOPER=1
> build.
>
> Lock the CI job to the current release image, and while at it rename
> the job to better reflect what it is currently doing, instead of its
> original objective.
The CI job was added in your cebead1ebfb (ci: run a pedantic build as
part of the GitHub workflow, 2021-08-08), and later in 6a8cbc41bac
(developer: enable pedantic by default, 2021-09-03) we made "pedantic"
the default.
Is there any point in having this job at all anymore, or is it just a
"does it compile on Fedora?" now?
Your cebead1ebfb notes that its gcc is ahead of the curve, if that's
what we actually want perhaps s/fedora/linux-newer-gcc/ ?
I think this change would be much clearer if we first delete the
now-redundant pedantic flag, and then later do whatever else that's
needed...
> [...]
> This merges fine to master, maint and next but will need some work to
> get into seen.
>
> Alternatively, the fixes to fix the build could be merged instead, but
> it will still require at least one temporary change to disable a flag
> as the underlying bug[3] is yet to be addressed in gcc (or somewhere
> else in Fedora).
I get the same thing on GCC12 on Debian.
Wouldn't a much more useful thing be to upgrade to gcc12 anyway, and
just set -Wno-error=stringop-overread on gcc12 for dir.(o|s|sp)? Then
we'd find any future issues, and blacklist this one known issue...
Or just set -O1 under the same condition.
> diff --git a/ci/install-docker-dependencies.sh b/ci/install-docker-dependencies.sh
> index 78b7e326da6..660e25d1d26 100755
> --- a/ci/install-docker-dependencies.sh
> +++ b/ci/install-docker-dependencies.sh
> @@ -15,8 +15,8 @@ linux-musl)
> apk add --update build-base curl-dev openssl-dev expat-dev gettext \
> pcre2-dev python3 musl-libintl perl-utils ncurses >/dev/null
> ;;
> -pedantic)
> +fedora)
> dnf -yq update >/dev/null &&
> - dnf -yq install make gcc findutils diffutils perl python3 gettext zlib-devel expat-devel openssl-devel curl-devel pcre2-devel >/dev/null
> + dnf -yq install make gcc git findutils diffutils perl python3 gettext zlib-devel expat-devel openssl-devel curl-devel pcre2-devel >/dev/null
Why do we need to install "git" now, I'd think because we're upgrading,
but here we're pinning the old version, what changed?
> ;;
> esac
> diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
> index 280dda7d285..de0f8d36d7c 100755
> --- a/ci/run-build-and-tests.sh
> +++ b/ci/run-build-and-tests.sh
> @@ -37,10 +37,9 @@ linux-clang)
> linux-sha256)
> export GIT_TEST_DEFAULT_HASH=sha256
> ;;
> -pedantic)
> +fedora)
> # Don't run the tests; we only care about whether Git can be
> # built.
> - export DEVOPTS=pedantic
> export MAKE_TARGETS=all
> ;;
> esac
next prev parent reply other threads:[~2022-04-15 13:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 12:39 [PATCH] ci: lock "pedantic" job into fedora 35 and other cleanup Carlo Marcelo Arenas Belón
2022-04-15 13:17 ` Ævar Arnfjörð Bjarmason [this message]
2022-04-15 13:50 ` Phillip Wood
2022-04-15 18:31 ` Junio C Hamano
2022-04-15 21:03 ` Carlo Arenas
2022-04-15 22:20 ` Junio C Hamano
2022-04-15 23:13 ` [PATCH 0/2] ci: avoid failures for pedantic job with fedora 36 Carlo Marcelo Arenas Belón
2022-04-15 23:13 ` [PATCH 1/2] config.mak.dev: workaround gcc 12 bug affecting "pedantic" CI job Carlo Marcelo Arenas Belón
2022-04-15 23:41 ` Ævar Arnfjörð Bjarmason
2022-04-16 0:08 ` Carlo Arenas
2022-04-16 0:55 ` Ævar Arnfjörð Bjarmason
2022-04-16 5:56 ` Junio C Hamano
2022-04-16 12:33 ` Ævar Arnfjörð Bjarmason
2022-04-16 0:19 ` Junio C Hamano
2022-04-15 23:56 ` Junio C Hamano
2022-04-15 23:13 ` [PATCH 2/2] config.mak.dev: alternative workaround to gcc 12 warning in http.c Carlo Marcelo Arenas Belón
2022-04-15 23:34 ` Junio C Hamano
2022-04-16 0:02 ` Carlo Arenas
2022-04-16 0:28 ` Junio C Hamano
2022-04-16 0:51 ` Carlo Arenas
2022-04-16 1:00 ` Junio C Hamano
2022-04-16 12:50 ` Ævar Arnfjörð Bjarmason
2022-04-16 1:20 ` Ævar Arnfjörð Bjarmason
2022-04-16 14:23 ` Junio C Hamano
2022-04-16 1:08 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220415.86wnfqbhsf.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).