From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 9FE941F4CE for ; Fri, 1 Apr 2022 08:06:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344171AbiDAIHi (ORCPT ); Fri, 1 Apr 2022 04:07:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344170AbiDAIHe (ORCPT ); Fri, 1 Apr 2022 04:07:34 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 413732675B6 for ; Fri, 1 Apr 2022 01:05:45 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id bg10so4191753ejb.4 for ; Fri, 01 Apr 2022 01:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:references:user-agent:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=8d1B/E80vSKUrCz3Phw0NLZ+foQaHDh5mudwyXqey6I=; b=lliGJ8RLFaijb1hrH6PgFdsGDbS4zZ6Mo2BN8AWbPu/XwN6ToMYvwVTWrZ5VAtm+DT l1/NHqHysakrRRXj4qbS+9eAwilURRmu4uL1ccM8Qr9tt7yGQnFBC9EG/w8JTLsh07+T PET30E0AofH639mV4Gk7RXCPT8XkBswTydIiGeDYTrkvkk4Y0pA9GSIs2WDXNLtrQLn7 MIUlITMHugu+masLGCXTGX2pOAxOgU2lXv1gJdFyMGNW/RuxtkyJp9UlP+ru1R3LktAS 5uoDfLjcVHGpvQgfq+FvZCkKHmhYN8AiM4Jzmx3TkRJe3EN6RgVbWH/JN9XrCEqrrcio sNdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:references:user-agent :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=8d1B/E80vSKUrCz3Phw0NLZ+foQaHDh5mudwyXqey6I=; b=znPNfnEbUZesJrBjixSz3CL3VErjGDLbKA8BWRJ6C+D4XHBe2BQQ+AEXMI4hDiRCfu tuzpTUlo95TTex7CRoss4WgoD7e/uoB0E1vEmpavufeMXf3GRw8oW/YRv57G3O2WwHgt wL//Xx77CMjI7cRzb+LBLQyiD7emolY9pfbZUMUfRnTidGSx4cKzsPV2vKzj1DRN/yeF hxrqcDiVTrzQMiab5/UWBYhaULehXlPO18x9nTJ6w0GzYbdlMuu9FtVsBm1kiO+c8s9Q zARAwgxTL88UiMMwEHB6MCMBkCKNYMs2bCSarr2vfybt4EnHTK3lnpUCxzgNfw1kMw14 f1Iw== X-Gm-Message-State: AOAM530WVbhZ9xtHZXqccIc6WQvci8idxYlLFR79yH84WpdkZgQe81ZJ CcI5W52Z8ZHPBRTKTnkKefA= X-Google-Smtp-Source: ABdhPJyTirApvzLdv7sT184fwU4TzCXQKZcct0TT2i0H8xx9f4giyDCjOXnrbHPqn+RO5lnpMepfLA== X-Received: by 2002:a17:907:c00b:b0:6df:cd40:afc4 with SMTP id ss11-20020a170907c00b00b006dfcd40afc4mr8231508ejc.629.1648800343537; Fri, 01 Apr 2022 01:05:43 -0700 (PDT) Received: from gmgdl (j120189.upc-j.chello.nl. [24.132.120.189]) by smtp.gmail.com with ESMTPSA id g16-20020a170906521000b006d58773e992sm740556ejm.188.2022.04.01.01.05.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 01:05:42 -0700 (PDT) Received: from avar by gmgdl with local (Exim 4.95) (envelope-from ) id 1naCHu-000w2N-8U; Fri, 01 Apr 2022 10:05:42 +0200 From: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason To: Shaoxuan Yuan Cc: git@vger.kernel.org, vdye@github.com, derrickstolee@github.com, gitster@pobox.com, Tao Klerks Subject: Re: [WIP v1 3/4] mv: add advise_to_reapply hint for moving file into cone Date: Fri, 01 Apr 2022 10:02:56 +0200 References: <20220331091755.385961-1-shaoxuan.yuan02@gmail.com> <20220331091755.385961-4-shaoxuan.yuan02@gmail.com> <220331.86ilruqup6.gmgdl@evledraar.gmail.com> User-agent: Debian GNU/Linux bookworm/sid; Emacs 27.1; mu4e 1.7.12 In-reply-to: Message-ID: <220401.867d89p6sp.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Apr 01 2022, Shaoxuan Yuan wrote: > On Thu, Mar 31, 2022 at 6:31 PM =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason > wrote: >> >> More odd indentation, and the braces aren't needed. > > Got me again :-( Will make a change. > >> > } >> > >> > if (gitmodules_modified) >> > @@ -392,6 +398,9 @@ int cmd_mv(int argc, const char **argv, const char= *prefix) >> > COMMIT_LOCK | SKIP_IF_UNCHANGED)) >> > die(_("Unable to write new index file")); >> > >> > + if (advise_to_reapply) >> > + printf(_("Please use \"git sparse-checkout reapply\" to = reapply the sparsity.\n")); >> > + >> >> Please see 93026558512 (tracking branches: add advice to ambiguous >> refspec error, 2022-03-28) (the OID may change after I send this, as >> it's in "seen") for how to add new advise, i.e. we use advise(), add an >> enum field, config var etc. > > I actually did use advise(), but I noticed that it prints to stderr > and ... nevermind, > I realized that printing to stderr is OK. But can I print to stdout > since I think users should > be "reminded" instead of "warned"? > > Anyway, I think using advice() is probably better. We've typically used stderr in git not to mean "error", but to distinguish "chatty" and non-primary output from non-chatty. So (leaving aside that we're unlikely to add advice to plumbing) if you emitted a warning() or advice from git-ls-tree you should be able to run something like: git ls-tree -r HEAD >output-for-a-script And get the advise() on stderr, while the "primary" output is on stdout. There's a recent-ish (last year or so) thread where I think Jeff King explained this better than I'm doing here, but I couldn't find it with a quick search. In other words, you can just use advise() here, don't worry about it writing to stderr.