mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <>
To: Christian Couder <>
Cc: Jayati Shrivastava <>,
	Hariom verma <>,
	Git List <>
Subject: Re: Having grep support the -o option
Date: Tue, 22 Mar 2022 11:50:10 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Mar 22 2022, Christian Couder wrote:

> On Sun, Mar 20, 2022 at 8:14 PM Jayati Shrivastava <> wrote:
>> On Sat, Mar 19, 2022 at 9:49 PM Ævar Arnfjörð Bjarmason
>> <> wrote:
>> >
>> >
>> > One thing I'd *really* like to see is the bits of %(if) %(then)
>> > etc. extracted from ref-filter.c into some general API other commands
>> > could use with strbuf_expand() and friends.
>> >
>> > I.e. if you could in addition to the strbuf_expand() callback define
>> > what verbs you support for "if" and the like, or have callbacks for
>> > their comparison functions.
>> >
>> > Then have that machinery drive the whole format expansion, which
>> > eventually would expand your %(some-custom-thing) via a callback.
>> >
>> > I.e. the whole "valid_atom" state machine in ref-filter.c.
>> So, the end goal is to design a formatting API that can be used by any
>> command that takes --format option?
> It might be nice if we get closer to this after your GSoC project, but
> I don't think it should become the main goal of the GSoC.

Agreed. FWIW this is off-list discussion between Jayati and myself which
started with her asking (and this was omitted in the context that made
it on list:

    [...] Infact, I'll be excited to work on anything you suggest even
    if its not related to the project, as it will help me get familiar
    with the codebase and the contribution process at Git.

So that suggestion of mine of generalizing ref-filter.c wasn't meant to
distract from the GSoC project, I understood her to be looking for
suggestions for things to work on that were *not* part of the GSoC

So I suggested that ref-filter.c task, which is orthagonal, but relates
to some of the same code.

  reply	other threads:[~2022-03-22 10:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-17 21:20 [GSoC] Some #leftoverbits for anyone looking for little projects Ævar Arnfjörð Bjarmason
2019-05-20 18:23 ` Matheus Tavares
2019-05-20 23:49   ` Ævar Arnfjörð Bjarmason
2019-05-21  4:38     ` Matheus Tavares Bernardino
2019-05-28 10:37   ` Johannes Schindelin
2019-05-28 17:37     ` Matheus Tavares Bernardino
2019-05-28 18:16       ` Johannes Schindelin
2019-05-29  9:38 ` Johannes Schindelin
2019-05-29  9:40   ` Johannes Schindelin
     [not found] ` <>
     [not found]   ` <>
     [not found]     ` <>
     [not found]       ` <>
     [not found]         ` <>
     [not found]           ` <>
2022-03-20 19:14             ` Having grep support the -o option Jayati Shrivastava
2022-03-22  6:08               ` Christian Couder
2022-03-22 10:50                 ` Ævar Arnfjörð Bjarmason [this message]
2022-03-23 17:45                   ` Jayati Shrivastava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).