Re: [PATCH 0/5] refs: designated init & missing debug in ps/fetch-mirror-optim

["Ævar Arnfjörð Bjarmason" <avarab@gmail.com>]

On Thu, Mar 17 2022, Han-Wen Nienhuys wrote:

> On Thu, Mar 17, 2022 at 6:27 PM Ævar Arnfjörð Bjarmason
> <avarab@gmail.com> wrote:
>> Aside: It seems that the GIT_TRACE_REFS facility has been broken since
>> it was added, i.e. running the test site with e.g.:
>>
>>     GIT_TRACE_REFS=/tmp/log.txt make test
>
> I wasn't aware that this is even possible. I've only used it with
> GIT_TRACE_REFS=1

Yes, it's possible with all the GIT_TRACE* variables. To clarify the
failure has nothing to do with the "log to file" feature of it, the same
happens e.g. with this on master:

    GIT_TRACE_REFS=1 ./t1400-update-ref.sh -vx --run=1-46,55-169

I.e. here I skipped some tests that would fail because we emitted the
output on stderr, but this one fails due to the debug tracing and
transactions (I think, but not 100% sure) tripping over one another
somehow.

> I looked over your patches and they LGTM.

Thanks!