From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] scalar: accept -C and -c options before the subcommand
Date: Thu, 27 Jan 2022 03:55:58 +0100 [thread overview]
Message-ID: <220127.86v8y5dgus.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <pull.1130.git.1643195729608.gitgitgadget@gmail.com>
On Wed, Jan 26 2022, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> The `git` executable has these two very useful options:
>
> -C <directory>:
> switch to the specified directory before performing any actions
>
> -c <key>=<value>:
> temporarily configure this setting for the duration of the
> specified scalar subcommand
>
> With this commit, we teach the `scalar` executable the same trick.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> scalar: accept -C and -c options
>
> This makes the scalar command a bit more handy by offering the same -c
> <key>=<value> and -C <directory> options as the git command.
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1130%2Fdscho%2Fscalar-c-and-C-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1130/dscho/scalar-c-and-C-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1130
I think it would help for context to note that this patch had at least 6
submissions on the ML already as part of early versions of the scalar
series.
Here's the CL of the iteration that ejected it:
https://lore.kernel.org/git/pull.1005.v7.git.1637158762.gitgitgadget@gmail.com/
Where you summarized:
* The patch that adds support for -c <key>=<value> and -C <directory> was
moved to its own add-on patch series: While it is obvious that those
options are valuable to have, an open question is whether there are other
"pre-command" options in git that would be useful, too, and I would like
to postpone that discussion to that date.
Having been involved in those discussions I can't remember what the
pre-command options you're referring to there are, but it seems "that
date" is probably upon us.
next prev parent reply other threads:[~2022-01-27 2:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 11:15 [PATCH] scalar: accept -C and -c options before the subcommand Johannes Schindelin via GitGitGadget
2022-01-26 20:53 ` Taylor Blau
2022-01-28 11:43 ` Johannes Schindelin
2022-01-27 2:55 ` Ævar Arnfjörð Bjarmason [this message]
2022-01-27 14:46 ` Derrick Stolee
2022-01-28 11:27 ` Johannes Schindelin
2022-01-28 18:21 ` Ævar Arnfjörð Bjarmason
2022-01-28 19:52 ` Derrick Stolee
2022-01-29 6:39 ` Ævar Arnfjörð Bjarmason
2022-01-28 19:37 ` Derrick Stolee
2022-01-28 18:05 ` Junio C Hamano
2022-01-28 19:38 ` Derrick Stolee
2022-01-28 14:31 ` [PATCH v2] " Johannes Schindelin via GitGitGadget
2022-01-28 19:40 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220127.86v8y5dgus.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).