git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Greg Hurrell <greg@hurrell.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] docs: Fix bad whitespace in Documentation/config/pgp.txt
Date: Tue, 25 Jan 2022 18:09:57 +0100	[thread overview]
Message-ID: <220125.861r0vhh8r.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <20220125123716.66991-2-greg@hurrell.net>


On Tue, Jan 25 2022, Greg Hurrell wrote:

nit @ subject: I'd suggest:

	Documentation/config/pgp.txt: replace stray <TAB> character with <SPC>

Or something, i.e. the "docs" can just be replaced by the filename, so
we don't need to put it at the end.

As general style, we tend to not have the <msg> part of "<subsystem>:
<msg>" start with a capital letter, i.e. "fix" not "Fix".

> Signed-off-by: Greg Hurrell <greg@hurrell.net>
> ---
>  Documentation/config/gpg.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/config/gpg.txt b/Documentation/config/gpg.txt
> index 0cb189a077..abfabd6d62 100644
> --- a/Documentation/config/gpg.txt
> +++ b/Documentation/config/gpg.txt
> @@ -37,7 +37,7 @@ gpg.minTrustLevel::
>  gpg.ssh.defaultKeyCommand::
>  	This command that will be run when user.signingkey is not set and a ssh
>  	signature is requested. On successful exit a valid ssh public key is
> -	expected in the	first line of its output. To automatically use the first
> +	expected in the first line of its output. To automatically use the first

Since I had to look it's a s/\t/ / of a tab between "the" and "first" in
the pre-image>

  reply	other threads:[~2022-01-25 17:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 12:37 [PATCH 0/2] docs: apply minor fixes to Documentation/config/pgp.txt Greg Hurrell
2022-01-25 12:37 ` [PATCH 1/2] docs: Fix bad whitespace in Documentation/config/pgp.txt Greg Hurrell
2022-01-25 17:09   ` Ævar Arnfjörð Bjarmason [this message]
2022-01-26 12:14     ` [PATCH v2 0/2] Apply minor fixes to Documentation/config/pgp.txt Greg Hurrell
2022-01-26 12:14       ` [PATCH v2 1/2] Documentation/config/pgp.txt: replace stray <TAB> character with <SPC> Greg Hurrell
2022-01-27  2:30         ` Junio C Hamano
2022-01-27  8:20           ` Greg Hurrell
2022-01-27 17:50             ` Junio C Hamano
2022-01-26 12:14       ` [PATCH 2/2] Documentation/config/pgp.txt: add missing apostrophe Greg Hurrell
2022-01-27  2:30         ` Junio C Hamano
2022-01-25 12:37 ` [PATCH 2/2] docs: add missing apostrophe to Documentation/config/gpg.txt Greg Hurrell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=220125.861r0vhh8r.gmgdl@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=greg@hurrell.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).