From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 4C1881F852 for ; Fri, 21 Jan 2022 12:06:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350406AbiAUMGl (ORCPT ); Fri, 21 Jan 2022 07:06:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380310AbiAUMGc (ORCPT ); Fri, 21 Jan 2022 07:06:32 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C62CC061574 for ; Fri, 21 Jan 2022 04:06:32 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id f21so42127618eds.11 for ; Fri, 21 Jan 2022 04:06:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:references:user-agent:in-reply-to :message-id:mime-version; bh=NH0l6Bs6r/cIN3xOk2N4GJwfJ+3VgDpBFMlNxPz6W2c=; b=bYo244vOg0HsITt517cwVRdN5wiGNFVl4fovQ/4GBhtFtfRSHSQF1gagujJyrcOL6R XhXDEcMad/a2e2YRD2JYbsaFwCep0AlAD8gGfUIp3jrMjtKt7IeqIZcY5G/Jq4sfjWOQ wA/gPgt8HqS/X2stC9QOBXJTg1Oq4XKbKpYsLTh7u6Q7uJaNB5Y1lMO351qBpAOb9/d2 Ai8OKFLOy97qPzWbLYsexT884MeYTS1UljbOsg/FONuzAScSxUBmzCueivLYH/pmOj8Z Ze/KEe6KkAei9PX2l4FLd0ZEMJI9GcAoTsZIK/3gXSM/EY+0jJAWw47AZVWBjOTjDffF 5DYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:references:user-agent :in-reply-to:message-id:mime-version; bh=NH0l6Bs6r/cIN3xOk2N4GJwfJ+3VgDpBFMlNxPz6W2c=; b=yjKF7hu7mcLcJLCIiRFwWKyzTA+SIYMO/OoWnff6lDLhDDyiFsXyBCARL28PU9UNUt mRExRPZn2V/9gmc9dAlZjJ47bpv1hPq1SvyHoVVpArD0FAxPF4uUO11h+wtmTcaP0wsU NlXBGqgGvaHGFJlACUhMKOHWYXGWCjRLo59WqSn67MRxkUO1LbqGSQEtV6drJBb7Oed9 Vi/UHnXlqaRPRMniuJ4QhMOxk5cwraVM+y4UqKxFBU9Yb+CYpEi7jzGohJHNx81xp/gm Zl92XsQx94zwTEwzIuGkIDQdz4IJDpBYGgu5w+snygmxnxSRknwNC50jF8mtLd2tbiUU ksQA== X-Gm-Message-State: AOAM5323zNc/dEA77fTq6o2XnlPeQl6YJhBdl6J4+JmefH8/a0Pa3ooQ rlEZw7ayV6gmJsP192KCW1WhtNakfkJonA== X-Google-Smtp-Source: ABdhPJxnWFTbifGgR7zmnf3XSjx9wVOWH90sdMQwI0izUJKDp+bR9rz53KvzeFBm1/dQIMZv/NlfbQ== X-Received: by 2002:a17:906:f01:: with SMTP id z1mr3102726eji.346.1642766790334; Fri, 21 Jan 2022 04:06:30 -0800 (PST) Received: from gmgdl (j120189.upc-j.chello.nl. [24.132.120.189]) by smtp.gmail.com with ESMTPSA id l3sm2000835ejg.44.2022.01.21.04.06.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 04:06:29 -0800 (PST) Received: from avar by gmgdl with local (Exim 4.95) (envelope-from ) id 1nAsgX-00281i-Ab; Fri, 21 Jan 2022 13:06:29 +0100 From: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason To: Han-Wen Nienhuys via GitGitGadget Cc: git@vger.kernel.org, Jeff King , =?utf-8?Q?Ren=C3=A9?= Scharfe , "brian m. carlson" , Johannes Schindelin , Neeraj Singh , Han-Wen Nienhuys , Han-Wen Nienhuys Subject: Re: [PATCH v6 13/15] reftable: remove outdated file reftable.c Date: Fri, 21 Jan 2022 13:05:43 +0100 References: <69c4a55488209f96ae605047ecd1709678518fa5.1642691534.git.gitgitgadget@gmail.com> User-agent: Debian GNU/Linux bookworm/sid; Emacs 27.1; mu4e 1.6.10 In-reply-to: <69c4a55488209f96ae605047ecd1709678518fa5.1642691534.git.gitgitgadget@gmail.com> Message-ID: <220121.86k0etjnsq.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Jan 20 2022, Han-Wen Nienhuys via GitGitGadget wrote: > From: Han-Wen Nienhuys > > This was renamed to generic.c, but the origin was never removed I thought "hrm, didn't I have a way to assert this?" before I remembered that yes, we could use $(wildcard) in the Makefile to avoid this class of problem in the future: https://lore.kernel.org/git/220121.86o845jnvv.gmgdl@evledraar.gmail.com/ Just food for thought :) The change itself LGTM.