From: "Peter Kästle" <peter.kaestle@nokia.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com, pc44800@gmail.com
Subject: Re: [PATCH v4 1/2] t7400: add a testcase for submodule status on empty dirs
Date: Tue, 28 Jan 2020 09:16:39 +0100 [thread overview]
Message-ID: <2181f9d5-7556-90e8-14a5-0ca86f2c2c97@nokia.com> (raw)
In-Reply-To: <xmqqzhe8bwab.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On 27.01.20 19:15, Junio C Hamano wrote:
> Peter Kaestle <peter.kaestle@nokia.com> writes:
>
>> We have test coverage for "git submodule status" output in
>> various cases, i.e.
>>
>> 1) not-init, not-cloned: status should initially be "missing"
>> 2) init, not-cloned: status should be "missing"
>> 3) not-init, cloned:
>> 4) init, cloned:'status should be "up-to-date" after update
>> 4.1) + modified: status should be "modified" after submodule commit
>> 4.2) + modified, committed: status should be "up-to-date" after update
>>
>> Case 2) will be covered by this patch. Case 3) remains uncovered.
>>
>> Test that submodule status reports initialized but not cloned
>> submodules as missing to fill the gap in test coverage.
>
> Thanks for an update.
>
Sure, welcome. Will you include those patches, or do you need further
refinement?
- Thanks a lot for your guidance and mentoring. It was a pleasure to
learn from you.
--
kind regards,
--peter;
next prev parent reply other threads:[~2020-01-28 8:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 14:02 [PATCH] Fix submodule status of dirs initialized but empty Peter Kästle
2020-01-21 10:12 ` [PATCH v2] Fix status of initialized but not cloned submodules Peter Kaestle
2020-01-23 21:12 ` Junio C Hamano
2020-01-24 10:34 ` [PATCH v3 1/2] Testcase for submodule status on empty dirs Peter Kaestle
2020-01-24 10:34 ` [PATCH v3 2/2] Fix status of initialized but not cloned submodules Peter Kaestle
2020-01-24 17:35 ` [PATCH v3 1/2] Testcase for submodule status on empty dirs Junio C Hamano
2020-01-27 9:06 ` [PATCH v4 1/2] t7400: add a testcase " Peter Kaestle
2020-01-27 9:06 ` [PATCH v4 2/2] Fix status of initialized but not cloned submodules Peter Kaestle
2020-01-27 18:15 ` [PATCH v4 1/2] t7400: add a testcase for submodule status on empty dirs Junio C Hamano
2020-01-28 8:16 ` Peter Kästle [this message]
2020-02-02 23:32 ` [PATCH] t7400: testcase for submodule status on unregistered inner git repos Peter Kaestle
2020-01-24 11:55 ` [PATCH v2] Fix status of initialized but not cloned submodules Peter Kästle
2020-01-24 17:16 ` Junio C Hamano
2020-01-27 8:52 ` Peter Kästle
2020-01-27 18:18 ` Junio C Hamano
2020-02-02 23:16 ` Peter Kästle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2181f9d5-7556-90e8-14a5-0ca86f2c2c97@nokia.com \
--to=peter.kaestle@nokia.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pc44800@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).