mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Mkrtchyan, Tigran" <>
To: Junio C Hamano <>
Cc: git <>, Jonathan Nieder <>,
	Johannes Schindelin <>
Subject: Re: [PATCH v3] tag: add tag.gpgSign config option to force all tags be GPG-signed
Date: Wed, 5 Jun 2019 23:09:56 +0200 (CEST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

----- Original Message -----
> From: "Junio C Hamano" <>
> To: "Tigran Mkrtchyan" <>
> Cc: "git" <>, "Jonathan Nieder" <>, "Johannes Schindelin"
> <>
> Sent: Wednesday, June 5, 2019 10:57:34 PM
> Subject: Re: [PATCH v3] tag: add tag.gpgSign config option to force all tags be GPG-signed

> Junio C Hamano <> writes:
>> "Mkrtchyan, Tigran" <> writes:
>>>> But more importantly, I think we should justify why this "not
>>>> allowed" makes sense as the design of the feature. A plausible
>>>> alternative design would simply follow the "last one wins" paradigm,
>>>> ...
>>> This is matter of convention.
>> Oh, if you put it that way, it is quite clear that we should redo
>> this part, as the rest of Git command line processing all pretty
>> much follow "last one wins".  I was mostly curious if there was any
>> strong reason why this combination has to be different.
> One reason why "last one wins" aka "you have a chance to correct
> yourself" is so useful is because people can then use alias to
> define leading options, e.g. with
>    [alias] myfoo = foo --option1 --option2 --option3
> a user can say "git myfoo" to save typing, but in a rare occasion
> where only options 2 and 3 (but not option 1) are desired, can use
> "git myfoo --no-option1" to countermand it.
> Unfortunately, I do not think we can use the same technique for
> options that is given to the "git" potty, e.g. with
>    [alias] paged-status = --paginate status
> you can say "git paged-status" to have your "git status" output sent
> to the pager, but you cannot say "git paged-status --no-pager" to
> defeat that leading option.  We may want to find a way to correct
> it, but it is rather low on the priority scale ;-)

Makes sense. Thanks for that use case, which I actually use myself :).

BTW, `--no-sign` currently doesn't affects `-u <key>` in any order:

    if (keyid) {
        opt.sign = 1;

IOW, `-u <key>` is another way to enable signing, what is, actually,
consistent with man page:

       -u <keyid>, --local-user=<keyid>
           Make a GPG-signed tag, using the given key.

I will leave it as-is, I will just describe that tag.gpgSign options
doesn't affect '-u' behavior.


  reply	other threads:[~2019-06-05 21:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2019-06-04 11:43 ` config option to force all tags be GPG-signed - comeback Tigran Mkrtchyan
2019-06-04 11:43   ` [PATCH v2] tag: add tag.gpgSign config option to force all tags be GPG-signed Tigran Mkrtchyan
2019-06-04 14:33     ` Johannes Schindelin
2019-06-04 16:04       ` Mkrtchyan, Tigran
2019-06-05 15:53         ` [PATCH v3] " Tigran Mkrtchyan
2019-06-05 16:21           ` Todd Zullinger
2019-06-05 16:25           ` Junio C Hamano
2019-06-05 20:12             ` Mkrtchyan, Tigran
2019-06-05 20:46               ` Junio C Hamano
2019-06-05 20:50                 ` Mkrtchyan, Tigran
2019-06-05 20:57                 ` Junio C Hamano
2019-06-05 21:09                   ` Mkrtchyan, Tigran [this message]
2019-06-05 21:33                     ` [PATCH v4] " Tigran Mkrtchyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).