git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, me@ttaylorr.com, gitster@pobox.com,
	Jeff King <peff@peff.net>, Derrick Stolee <stolee@gmail.com>,
	Derrick Stolee <derrickstolee@github.com>
Subject: Re: [PATCH v2 0/2] Two small 'git repack' fixes
Date: Mon, 20 Dec 2021 20:01:20 +0100	[thread overview]
Message-ID: <211220.86r1a7t7xd.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <pull.1098.v2.git.1640011691.gitgitgadget@gmail.com>


On Mon, Dec 20 2021, Derrick Stolee via GitGitGadget wrote:

> I was experimenting with some ideas in 'git repack' and discovered these two
> bugs.

This iteration looks good to me.

>      + ## Documentation/git-repack.txt ##
>      +@@ Documentation/git-repack.txt: to the new separate pack will be written.
>      + 	linkgit:git-pack-objects[1].
>      + 
>      + -q::
>      +-	Pass the `-q` option to 'git pack-objects'. See
>      +-	linkgit:git-pack-objects[1].
>      ++--quiet::
>      ++	Show no progress over the standard error stream and pass the `-q`
>      ++	option to 'git pack-objects'. See linkgit:git-pack-objects[1].
>      + 
>      + -n::
>      + 	Do not update the server information with
>      +

Nit: I think the addition of --quiet here is good, but also wouldn't
mind a prep change to add it as a separate step.

FWIW it appears to have been an unintended/hidden effect of a1bbc6c0176
(repack: rewrite the shell script in C, 2013-09-15), i.e. we started
using OPT__QUIET() which added "--quiet", but the shellscript just
supported -q.

Here we update the docs, but the SYNOPSIS stillj just lists -q.

I think all of that's fine & this v2 is good enough. Just braindumping
notes/observations while reading along/checking the v1->v2 diff.

      parent reply	other threads:[~2021-12-20 19:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 16:28 [PATCH 0/2] Two small 'git repack' fixes Derrick Stolee via GitGitGadget
2021-12-17 16:28 ` [PATCH 1/2] repack: respect kept objects with '--write-midx -b' Derrick Stolee via GitGitGadget
2021-12-17 17:24   ` Jeff King
2021-12-20 13:40     ` Derrick Stolee
2021-12-20 13:50       ` Jeff King
2021-12-18  9:58   ` Ævar Arnfjörð Bjarmason
2021-12-17 16:28 ` [PATCH 2/2] repack: make '--quiet' disable progress Derrick Stolee via GitGitGadget
2021-12-17 18:10   ` Jeff King
2021-12-20 13:37     ` Derrick Stolee
2021-12-20 13:49       ` Jeff King
2021-12-20 14:46         ` Derrick Stolee
2021-12-18  9:55   ` Ævar Arnfjörð Bjarmason
2021-12-20 13:38     ` Derrick Stolee
2021-12-20 14:48 ` [PATCH v2 0/2] Two small 'git repack' fixes Derrick Stolee via GitGitGadget
2021-12-20 14:48   ` [PATCH v2 1/2] repack: respect kept objects with '--write-midx -b' Derrick Stolee via GitGitGadget
2021-12-20 14:48   ` [PATCH v2 2/2] repack: make '--quiet' disable progress Derrick Stolee via GitGitGadget
2021-12-20 19:01   ` Ævar Arnfjörð Bjarmason [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=211220.86r1a7t7xd.gmgdl@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).