From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com> To: "SZEDER Gábor" <szeder.dev@gmail.com> Cc: "Junio C Hamano" <gitster@pobox.com>, git@vger.kernel.org, "René Scharfe" <l.s.r@web.de>, "Emily Shaffer" <emilyshaffer@google.com> Subject: Re: [PATCH v3 10/10] progress.c: add & assert a "global_progress" variable Date: Fri, 03 Dec 2021 11:29:26 +0100 [thread overview] Message-ID: <211203.868rx2t0hv.gmgdl@evledraar.gmail.com> (raw) In-Reply-To: <20211202231421.GA624717@szeder.dev> On Fri, Dec 03 2021, SZEDER Gábor wrote: > On Mon, Oct 25, 2021 at 02:38:04AM -0700, Junio C Hamano wrote: >> SZEDER Gábor <szeder.dev@gmail.com> writes: >> >> > I still very much dislike the idea of a BUG() in the progress code >> > that can trigger outside of the test suite, because the progress line >> > is only a UI gimmick and not a crucial part of any Git operation, and >> > even though a progress line might be buggy, the underlying Git >> > operation is not affected by it and would still finish successfully, >> > as was the case with the dozen of so progress line bugs in the past. >> >> I too recall that we have fixed numerous bugs in the past year in >> the area, but weren't they kind of obvious ones _once_ they are >> pointed out at you (e.g. progress never reaching to 100%)? Yet the >> developers have failed to catch them because their eyes would coast >> over without paying attention to them, exactly because the progress >> bar is merely a UI gimmick. >> >> I haven't formed a firm opinion on this yet, but I think the idea >> behind these BUG() is to help such problems be caught while they are >> still in the lab. You may not notice when your live progress bar >> behaved a bit funny, but if you hit a BUG(), that would be squarely >> in your face and you cannot ignore it. > > The "outside of the test suite" part is important. Running the test > suite with a GIT_TEST_CHECK_PROGRESS knob is sufficient to catch these > issues as my inital two patch series have shown at the very beginning > of this thread before Ævar hijacked them. FWIW I didn't hijack and adjust your patches to be BUG() instead of a test mode. We came up with more-or-less the same thing independently around the same time. You submitted yours on the 20th of June, but I hacked up mine on top af on already-WIP series I had ~5 days earlier in response to another discussion about progress.c[1]. You submitter yours first, and I then replied to the effect of "here's a similar thing I had locally, RFC"[2]. Or do you mean the smaller "fix bogus counting" fixed that are now landed[3]? I just wanted to push that forward since it seemed you weren't per[4]. Sorry if I stepped on any toes there... > Interested Git developers > can even enable it in their .profile if they wish; I did so with > GIT_TEST_SPLIT_INDEX for a while to expose some of my patches to more > real-world use. > > However, I think it's conceptually a bad idea to abort with a BUG() an > otherwise successful Git operation by default, when that bug happens > to be in such an ancillary component as the progress display, and find > the justifications given in the commit message unconvincing. I think it's important to get to the root of what we really disagree about here. We hard die on all sorts of trivial things in BUG() already, as paging through this shows: git grep -w -F 'BUG(' I.e. the general criteria for BUG() isn't whether we could hypothetically recover from the scenario. Which, if you adjust the code around many existing BUG()s to trigger the "bad thing" (as it were..) is the case. I haven't done any exhaustive checking, but I'd bet it's more common than not, or at least something like 1/4 or 1/8 of them. Rather it's a combination of: A. This should absolutely not happen B. We are sure (or are sure as we can be) that it doesn't C. We think if it does, we'll know/really want to know via tests/early integration testing. D. We mark it with a BUG() because we're as confident as we reasonably can be in A and B I took your earlier comments to mean that you agreed on "A", but you weren't so sure about "B". I agree that without confidence about "B" that having "D" would be overzealous. But here with your mention of "conceptually a bad idea to[...]" I'm not so sure, i.e. it seems like you're saying that you're categorically opposed to such use of BUG(). I think that's a fair stance to take if that's what you're going for, but per the above I also think it's true to say that a lot of our existing use of that API doesn't match that worldview. I.e. it's not an UNRECOVARABLE_BUG(), but SHOULD_NOT_ESCAPE_DEVELOPMENT_BUG(). I think that in this case we should be confident that we've got "B", as explained in detail in the upthread patch[5]. I would be exceedingly paranoid about more exhaustive checks, e.g. I don't think we've got enough coverage to have BUG() checks for some of the things you added test-only asserts (which would be good) for in your initial series. I.e. asserting whether we hit 99% and not 100%, whether display_progress() "misses" updates, or if we miss a call to stop_progress(), or whatever else one might assert. I've been running my personal git with many of those sorts of pedantic assertions for a while now, but I'm still not confident those changes are OK to submit for inclusion. I very much share your concerns in that area. But I think (and [5] argues) that it's *much* easier to be confident about the narrow BUG() assertion being added here. I.e. it's trivial to discover that almost all callers of progress.c are never going to start more than one progress bar ever, so we can discard those out of hand. For the rest they're rather easily auditable. But clearly you disagree, and I thinks it helps neither of us to just repeat our points, which is not what I'm trying to do here, but to get to the following: - Can you cite specifically what about [5] you think wouldn't catch any cases where we couldn't be certain about the BUG(). I.e. it outlines the sort of testing I did, which involved forcing all hidden progress bars to ignore their existing isatty() checks, adding more pedantic asserts to narrow down potentially affected callers etc. Do you think that testing could have missed something? How & why? - Related to that, are there cases where you would agree that we've got "B", as opposed to others where we don't? As I've argued I do think these patches are ready as-is, but one alternative way forward with them would be to add the BUG() to everything, but whitelist those current callers that have >1 progress bar. Then as a (slow) follow-up proceed to un-whitelist those one at a time. I'm not familiar with the GIT_TEST_SPLIT_INDEX changes you're mentioning, but I'd think that those cases would have been more complex (the code flow around index-related stuff) than the progress API users. 1. https://lore.kernel.org/git/87o8c8z105.fsf@evledraar.gmail.com/ 2. https://lore.kernel.org/git/cover-00.25-00000000000-20210623T155626Z-avarab@gmail.com/ 3. https://lore.kernel.org/git/cover-v4-0.2-00000000000-20210909T010722Z-avarab@gmail.com/ 4. https://lore.kernel.org/git/cover-0.3-0000000000-20210722T121801Z-avarab@gmail.com/ 5. https://lore.kernel.org/git/patch-v6-8.8-bff919994b5-20211102T122507Z-avarab@gmail.com/
next prev parent reply other threads:[~2021-12-03 11:02 UTC|newest] Thread overview: 197+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-20 20:02 [PATCH 0/7] progress: verify progress counters in the test suite SZEDER Gábor 2021-06-20 20:02 ` [PATCH 1/7] progress: introduce GIT_TEST_CHECK_PROGRESS to verify progress counters SZEDER Gábor 2021-06-21 7:09 ` Ævar Arnfjörð Bjarmason 2021-06-22 15:55 ` Taylor Blau 2021-06-20 20:02 ` [PATCH 2/7] progress: catch nested/overlapping progresses with GIT_TEST_CHECK_PROGRESS SZEDER Gábor 2021-06-22 16:00 ` Taylor Blau 2021-08-30 21:15 ` SZEDER Gábor 2021-06-20 20:02 ` [PATCH 3/7] progress: catch backwards counting " SZEDER Gábor 2021-06-20 20:03 ` [PATCH 4/7] commit-graph: fix bogus counter in "Scanning merged commits" progress line SZEDER Gábor 2021-06-20 22:13 ` Ævar Arnfjörð Bjarmason 2021-06-21 18:32 ` René Scharfe 2021-06-21 20:08 ` Ævar Arnfjörð Bjarmason 2021-06-26 8:27 ` René Scharfe 2021-06-26 14:11 ` Ævar Arnfjörð Bjarmason 2021-06-26 20:22 ` René Scharfe 2021-06-26 21:38 ` Ævar Arnfjörð Bjarmason 2021-07-04 12:15 ` René Scharfe 2021-07-05 14:09 ` Junio C Hamano 2021-07-05 23:28 ` Ævar Arnfjörð Bjarmason 2021-07-06 16:02 ` René Scharfe 2021-06-27 17:31 ` Felipe Contreras 2021-06-20 20:03 ` [PATCH 5/7] entry: show finer-grained counter in "Filtering content" " SZEDER Gábor 2021-06-20 20:03 ` [PATCH 6/7] [RFC] entry: don't show "Filtering content: ... done." line in case of errors SZEDER Gábor 2021-06-21 18:32 ` René Scharfe 2021-06-23 1:52 ` Taylor Blau 2021-08-30 21:17 ` SZEDER Gábor 2021-06-20 20:03 ` [PATCH 7/7] test-lib: enable GIT_TEST_CHECK_PROGRESS by default SZEDER Gábor 2021-06-21 0:59 ` [PATCH 0/7] progress: verify progress counters in the test suite Ævar Arnfjörð Bjarmason 2021-06-23 2:04 ` Taylor Blau 2021-06-23 17:48 ` [PATCH 00/25] progress.c: various fixes + SZEDER's RFC code Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 01/25] progress.c tests: fix breakage with COLUMNS != 80 Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 02/25] progress.c tests: make start/stop verbs on stdin Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 03/25] progress.c tests: test some invalid usage Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 04/25] progress.c tests: add a "signal" verb Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 05/25] progress.c: move signal handler functions lower Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 06/25] progress.c: call progress_interval() from progress_test_force_update() Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 07/25] progress.c: stop eagerly fflush(stderr) when not a terminal Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 08/25] progress.c: add temporary variable from progress struct Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 09/25] midx perf: add a perf test for multi-pack-index Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 10/25] progress.c: remove the "sparse" mode nano-optimization Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 11/25] pack-bitmap-write.c: add a missing stop_progress() Ævar Arnfjörð Bjarmason 2021-09-17 5:14 ` SZEDER Gábor 2021-09-17 5:56 ` Ævar Arnfjörð Bjarmason 2021-09-17 21:38 ` SZEDER Gábor 2021-06-23 17:48 ` [PATCH 12/25] progress.c: add & assert a "global_progress" variable Ævar Arnfjörð Bjarmason 2021-09-16 18:31 ` SZEDER Gábor 2021-06-23 17:48 ` [PATCH 13/25] progress.[ch]: move the "struct progress" to the header Ævar Arnfjörð Bjarmason 2021-09-16 19:42 ` SZEDER Gábor 2021-06-23 17:48 ` [PATCH 14/25] progress.[ch]: move test-only code away from "extern" variables Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 15/25] progress.c: pass "is done?" (again) to display() Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 16/25] progress.[ch]: convert "title" to "struct strbuf" Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 17/25] progress.c: refactor display() for less confusion, and fix bug Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 18/25] progress.c: emit progress on first signal, show "stalled" Ævar Arnfjörð Bjarmason 2021-09-16 18:37 ` SZEDER Gábor 2021-06-23 17:48 ` [PATCH 19/25] commit-graph: fix bogus counter in "Scanning merged commits" progress line Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 20/25] midx: don't provide a total for QSORT() progress Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 21/25] entry: show finer-grained counter in "Filtering content" progress line Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [PATCH 22/25] progress.c: add a stop_progress_early() function Ævar Arnfjörð Bjarmason 2021-06-24 10:35 ` Ævar Arnfjörð Bjarmason 2021-06-25 1:24 ` Andrei Rybak 2021-06-23 17:48 ` [PATCH 23/25] entry: deal with unexpected "Filtering content" total Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [RFC/PATCH 24/25] progress: assert last update in stop_progress() Ævar Arnfjörð Bjarmason 2021-06-23 17:48 ` [RFC/PATCH 25/25] progress: assert counting upwards in display() Ævar Arnfjörð Bjarmason 2021-06-23 17:59 ` [PATCH 00/25] progress.c: various fixes + SZEDER's RFC code Randall S. Becker 2021-06-23 20:01 ` Ævar Arnfjörð Bjarmason 2021-06-23 20:25 ` Randall S. Becker 2021-06-23 21:57 ` [PATCH 0/4] WIP/POC check isatty(2)-protected progress lines SZEDER Gábor 2021-06-23 21:57 ` [PATCH 1/4] WIP progress, isatty(2), hidden progress lnies for GIT_TEST_CHECK_PROGRESS SZEDER Gábor 2021-06-23 21:57 ` [PATCH 2/4] blame: fix progress total with line ranges SZEDER Gábor 2021-06-23 21:57 ` [PATCH 3/4] read-cache: avoid overlapping progress lines SZEDER Gábor 2021-06-23 21:57 ` [PATCH 4/4] preload-index: fix "Refreshing index" progress line SZEDER Gábor 2021-06-23 22:11 ` [PATCH 0/4] WIP/POC check isatty(2)-protected progress lines SZEDER Gábor 2021-06-24 10:43 ` Ævar Arnfjörð Bjarmason 2021-06-24 10:45 ` Ævar Arnfjörð Bjarmason 2021-07-22 12:20 ` [PATCH 0/3] progress.c API users: fix bogus counting Ævar Arnfjörð Bjarmason 2021-07-22 12:20 ` [PATCH 1/3] commit-graph: fix bogus counter in "Scanning merged commits" progress line Ævar Arnfjörð Bjarmason 2021-07-23 21:55 ` Junio C Hamano 2021-08-02 21:07 ` SZEDER Gábor 2021-07-22 12:20 ` [PATCH 2/3] midx: don't provide a total for QSORT() progress Ævar Arnfjörð Bjarmason 2021-07-23 21:56 ` Junio C Hamano 2021-08-05 15:07 ` Phillip Wood 2021-08-05 19:07 ` Ævar Arnfjörð Bjarmason 2021-07-22 12:20 ` [PATCH 3/3] entry: show finer-grained counter in "Filtering content" progress line Ævar Arnfjörð Bjarmason 2021-07-23 22:01 ` Junio C Hamano 2021-08-02 22:05 ` SZEDER Gábor 2021-08-02 21:48 ` SZEDER Gábor 2021-08-05 11:01 ` [PATCH v2 0/3] progress.c API users: fix bogus counting Ævar Arnfjörð Bjarmason 2021-08-05 11:01 ` [PATCH v2 1/3] commit-graph: fix bogus counter in "Scanning merged commits" progress line Ævar Arnfjörð Bjarmason 2021-08-05 11:01 ` [PATCH v2 2/3] midx: don't provide a total for QSORT() progress Ævar Arnfjörð Bjarmason 2021-08-05 11:01 ` [PATCH v2 3/3] entry: show finer-grained counter in "Filtering content" progress line Ævar Arnfjörð Bjarmason 2021-08-23 10:29 ` [PATCH v3 0/2] progress.c API users: fix bogus counting Ævar Arnfjörð Bjarmason 2021-08-23 10:29 ` [PATCH v3 1/2] commit-graph: fix bogus counter in "Scanning merged commits" progress line Ævar Arnfjörð Bjarmason 2021-08-23 10:29 ` [PATCH v3 2/2] entry: show finer-grained counter in "Filtering content" " Ævar Arnfjörð Bjarmason 2021-09-09 1:10 ` [PATCH v4 0/2] progress.c API users: fix bogus counting Ævar Arnfjörð Bjarmason 2021-09-09 1:10 ` [PATCH v4 1/2] commit-graph: fix bogus counter in "Scanning merged commits" progress line Ævar Arnfjörð Bjarmason 2021-09-09 1:10 ` [PATCH v4 2/2] entry: show finer-grained counter in "Filtering content" " Ævar Arnfjörð Bjarmason 2021-09-09 20:02 ` [PATCH v4 0/2] progress.c API users: fix bogus counting Junio C Hamano 2021-07-22 12:54 ` [PATCH 0/8] progress: assert "global_progress" + test fixes / cleanup Ævar Arnfjörð Bjarmason 2021-07-22 12:54 ` [PATCH 1/8] progress.c tests: make start/stop verbs on stdin Ævar Arnfjörð Bjarmason 2021-07-22 12:55 ` [PATCH 2/8] progress.c tests: test some invalid usage Ævar Arnfjörð Bjarmason 2021-07-22 12:55 ` [PATCH 3/8] progress.c: move signal handler functions lower Ævar Arnfjörð Bjarmason 2021-07-22 12:55 ` [PATCH 4/8] progress.c: call progress_interval() from progress_test_force_update() Ævar Arnfjörð Bjarmason 2021-07-22 12:55 ` [PATCH 5/8] progress.c: stop eagerly fflush(stderr) when not a terminal Ævar Arnfjörð Bjarmason 2021-07-22 12:55 ` [PATCH 6/8] progress.c: add temporary variable from progress struct Ævar Arnfjörð Bjarmason 2021-07-22 12:55 ` [PATCH 7/8] pack-bitmap-write.c: add a missing stop_progress() Ævar Arnfjörð Bjarmason 2021-07-22 12:55 ` [PATCH 8/8] progress.c: add & assert a "global_progress" variable Ævar Arnfjörð Bjarmason 2021-09-16 21:34 ` [PATCH 12/25] " Ævar Arnfjörð Bjarmason 2021-07-23 22:02 ` [PATCH 0/8] progress: assert "global_progress" + test fixes / cleanup Junio C Hamano 2021-09-20 23:09 ` [PATCH v2 " Ævar Arnfjörð Bjarmason 2021-09-20 23:09 ` [PATCH v2 1/8] progress.c tests: make start/stop verbs on stdin Ævar Arnfjörð Bjarmason 2021-10-08 3:43 ` Emily Shaffer 2021-09-20 23:09 ` [PATCH v2 2/8] progress.c tests: test some invalid usage Ævar Arnfjörð Bjarmason 2021-10-08 3:53 ` Emily Shaffer 2021-09-20 23:09 ` [PATCH v2 3/8] progress.c: move signal handler functions lower Ævar Arnfjörð Bjarmason 2021-09-20 23:09 ` [PATCH v2 4/8] progress.c: call progress_interval() from progress_test_force_update() Ævar Arnfjörð Bjarmason 2021-09-20 23:09 ` [PATCH v2 5/8] progress.c: stop eagerly fflush(stderr) when not a terminal Ævar Arnfjörð Bjarmason 2021-10-08 3:59 ` Emily Shaffer 2021-10-08 7:01 ` Ævar Arnfjörð Bjarmason 2021-09-20 23:09 ` [PATCH v2 6/8] progress.c: add temporary variable from progress struct Ævar Arnfjörð Bjarmason 2021-10-08 4:02 ` Emily Shaffer 2021-09-20 23:09 ` [PATCH v2 7/8] pack-bitmap-write.c: add a missing stop_progress() Ævar Arnfjörð Bjarmason 2021-10-08 4:04 ` Emily Shaffer 2021-10-08 12:14 ` Ævar Arnfjörð Bjarmason 2021-10-10 21:29 ` SZEDER Gábor 2021-09-20 23:09 ` [PATCH v2 8/8] progress.c: add & assert a "global_progress" variable Ævar Arnfjörð Bjarmason 2021-10-08 4:18 ` Emily Shaffer 2021-10-08 7:15 ` Ævar Arnfjörð Bjarmason 2021-10-13 22:28 ` [PATCH v3 00/10] progress: assert "global_progress" + test fixes / cleanup Ævar Arnfjörð Bjarmason 2021-10-13 22:28 ` [PATCH v3 01/10] leak tests: fix a memory leaks in "test-progress" helper Ævar Arnfjörð Bjarmason 2021-10-13 22:28 ` [PATCH v3 02/10] progress.c test helper: add missing braces Ævar Arnfjörð Bjarmason 2021-10-13 22:28 ` [PATCH v3 03/10] progress.c tests: make start/stop verbs on stdin Ævar Arnfjörð Bjarmason 2021-10-21 22:30 ` SZEDER Gábor 2021-10-22 14:18 ` Ævar Arnfjörð Bjarmason 2021-10-22 22:14 ` Taylor Blau 2021-10-24 20:10 ` SZEDER Gábor 2021-10-22 3:34 ` Emily Shaffer 2021-10-13 22:28 ` [PATCH v3 04/10] progress.c tests: test some invalid usage Ævar Arnfjörð Bjarmason 2021-10-13 22:28 ` [PATCH v3 05/10] progress.c: move signal handler functions lower Ævar Arnfjörð Bjarmason 2021-10-13 22:28 ` [PATCH v3 06/10] progress.c: call progress_interval() from progress_test_force_update() Ævar Arnfjörð Bjarmason 2021-10-22 22:28 ` Taylor Blau 2021-10-13 22:28 ` [PATCH v3 07/10] progress.c: add temporary variable from progress struct Ævar Arnfjörð Bjarmason 2021-10-22 22:37 ` Taylor Blau 2021-10-13 22:28 ` [PATCH v3 08/10] pack-bitmap-write.c: don't return without stop_progress() Ævar Arnfjörð Bjarmason 2021-10-22 3:37 ` Emily Shaffer 2021-10-22 22:47 ` Taylor Blau 2021-10-13 22:28 ` [PATCH v3 09/10] various *.c: use isatty(1|2), not isatty(STDIN_FILENO|STDERR_FILENO) Ævar Arnfjörð Bjarmason 2021-10-22 3:39 ` Emily Shaffer 2021-10-13 22:28 ` [PATCH v3 10/10] progress.c: add & assert a "global_progress" variable Ævar Arnfjörð Bjarmason 2021-10-22 3:42 ` Emily Shaffer 2021-10-25 5:02 ` SZEDER Gábor 2021-10-25 9:38 ` Junio C Hamano 2021-12-02 23:14 ` SZEDER Gábor 2021-12-03 10:29 ` Ævar Arnfjörð Bjarmason [this message] 2021-10-25 11:06 ` Ævar Arnfjörð Bjarmason 2021-10-22 3:44 ` [PATCH v3 00/10] progress: assert "global_progress" + test fixes / cleanup Emily Shaffer 2021-10-22 14:21 ` Ævar Arnfjörð Bjarmason 2021-10-25 11:24 ` [PATCH v4 0/8] " Ævar Arnfjörð Bjarmason 2021-10-25 11:25 ` [PATCH v4 1/8] leak tests: fix a memory leaks in "test-progress" helper Ævar Arnfjörð Bjarmason 2021-10-25 11:25 ` [PATCH v4 2/8] progress.c test helper: add missing braces Ævar Arnfjörð Bjarmason 2021-10-25 11:25 ` [PATCH v4 3/8] progress.c tests: make start/stop commands on stdin Ævar Arnfjörð Bjarmason 2021-10-25 11:25 ` [PATCH v4 4/8] progress.c tests: test some invalid usage Ævar Arnfjörð Bjarmason 2021-10-25 11:25 ` [PATCH v4 5/8] progress.c: add temporary variable from progress struct Ævar Arnfjörð Bjarmason 2021-10-25 11:25 ` [PATCH v4 6/8] pack-bitmap-write.c: don't return without stop_progress() Ævar Arnfjörð Bjarmason 2021-10-25 11:25 ` [PATCH v4 7/8] various *.c: use isatty(1|2), not isatty(STDIN_FILENO|STDERR_FILENO) Ævar Arnfjörð Bjarmason 2021-10-25 11:25 ` [PATCH v4 8/8] progress.c: add & assert a "global_progress" variable Ævar Arnfjörð Bjarmason 2021-10-25 11:53 ` Johannes Sixt 2021-10-25 12:29 ` Ævar Arnfjörð Bjarmason 2021-11-01 19:09 ` [PATCH v5 0/8] progress: assert "global_progress" + test fixes / cleanup Ævar Arnfjörð Bjarmason 2021-11-01 19:09 ` [PATCH v5 1/8] leak tests: fix a memory leaks in "test-progress" helper Ævar Arnfjörð Bjarmason 2021-11-01 19:09 ` [PATCH v5 2/8] progress.c test helper: add missing braces Ævar Arnfjörð Bjarmason 2021-11-01 19:09 ` [PATCH v5 3/8] progress.c tests: make start/stop commands on stdin Ævar Arnfjörð Bjarmason 2021-11-01 19:09 ` [PATCH v5 4/8] progress.c tests: test some invalid usage Ævar Arnfjörð Bjarmason 2021-11-01 19:09 ` [PATCH v5 5/8] progress.c: add temporary variable from progress struct Ævar Arnfjörð Bjarmason 2021-11-01 19:09 ` [PATCH v5 6/8] pack-bitmap-write.c: don't return without stop_progress() Ævar Arnfjörð Bjarmason 2021-11-01 19:09 ` [PATCH v5 7/8] various *.c: use isatty(1|2), not isatty(STDIN_FILENO|STDERR_FILENO) Ævar Arnfjörð Bjarmason 2021-11-02 0:58 ` Carlo Arenas 2021-11-01 19:09 ` [PATCH v5 8/8] progress.c: add & assert a "global_progress" variable Ævar Arnfjörð Bjarmason 2021-11-02 12:27 ` [PATCH v6 0/8] progress: assert "global_progress" + test fixes / cleanup Ævar Arnfjörð Bjarmason 2021-11-02 12:27 ` [PATCH v6 1/8] leak tests: fix a memory leaks in "test-progress" helper Ævar Arnfjörð Bjarmason 2021-11-02 12:27 ` [PATCH v6 2/8] progress.c test helper: add missing braces Ævar Arnfjörð Bjarmason 2021-11-02 12:27 ` [PATCH v6 3/8] progress.c tests: make start/stop commands on stdin Ævar Arnfjörð Bjarmason 2021-11-02 12:27 ` [PATCH v6 4/8] progress.c tests: test some invalid usage Ævar Arnfjörð Bjarmason 2021-11-02 12:27 ` [PATCH v6 5/8] progress.c: add temporary variable from progress struct Ævar Arnfjörð Bjarmason 2021-11-02 12:27 ` [PATCH v6 6/8] pack-bitmap-write.c: don't return without stop_progress() Ævar Arnfjörð Bjarmason 2021-11-02 12:27 ` [PATCH v6 7/8] various *.c: use isatty(0|2), not isatty(STDIN_FILENO|STDERR_FILENO) Ævar Arnfjörð Bjarmason 2021-11-02 12:27 ` [PATCH v6 8/8] progress.c: add & assert a "global_progress" variable Ævar Arnfjörð Bjarmason 2022-02-03 21:40 ` [PATCH v9 0/9] progress: test fixes / cleanup Ævar Arnfjörð Bjarmason 2022-02-03 21:40 ` [PATCH v9 1/9] leak tests: fix a memory leak in "test-progress" helper Ævar Arnfjörð Bjarmason 2022-02-03 21:40 ` [PATCH v9 2/9] progress.c test helper: add missing braces Ævar Arnfjörð Bjarmason 2022-02-03 21:40 ` [PATCH v9 3/9] progress.c tests: make start/stop commands on stdin Ævar Arnfjörð Bjarmason 2022-02-03 21:40 ` [PATCH v9 4/9] progress.c tests: test some invalid usage Ævar Arnfjörð Bjarmason 2022-02-03 21:40 ` [PATCH v9 5/9] progress.h: format and be consistent with progress.c naming Ævar Arnfjörð Bjarmason 2022-02-03 21:40 ` [PATCH v9 6/9] progress.c: use dereferenced "progress" variable, not "(*p_progress)" Ævar Arnfjörð Bjarmason 2022-02-03 21:40 ` [PATCH v9 7/9] progress.c: refactor stop_progress{,_msg}() to use helpers Ævar Arnfjörð Bjarmason 2022-02-03 21:40 ` [PATCH v9 8/9] progress API: unify stop_progress{,_msg}(), fix trace2 bug Ævar Arnfjörð Bjarmason 2022-02-03 21:40 ` [PATCH v9 9/9] pack-bitmap-write.c: don't return without stop_progress() Ævar Arnfjörð Bjarmason 2022-02-03 23:39 ` [PATCH v9 0/9] progress: test fixes / cleanup Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=211203.868rx2t0hv.gmgdl@evledraar.gmail.com \ --to=avarab@gmail.com \ --cc=emilyshaffer@google.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=l.s.r@web.de \ --cc=szeder.dev@gmail.com \ --subject='Re: [PATCH v3 10/10] progress.c: add & assert a "global_progress" variable' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).