From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, newren@gmail.com,
vdye@github.com, Derrick Stolee <derrickstolee@github.com>
Subject: Re: [PATCH 0/2] Sparse index: fetch, pull, ls-files
Date: Tue, 23 Nov 2021 02:57:33 +0100 [thread overview]
Message-ID: <211123.86lf1fwrq5.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <pull.1080.git.1637077083.gitgitgadget@gmail.com>
On Tue, Nov 16 2021, Derrick Stolee via GitGitGadget wrote:
> The 'ls-files' builtin is useful when debugging the index, and some scripts
> use it, too. We are not changing the default behavior which expands a sparse
> index in order to show all of the cached blobs. Instead, we add a '--sparse'
> option that allows us to see the sparse directory entries upon request.
> Combined with --debug, we can see a lot of index details, such as:
>
> $ git ls-files --debug --sparse
> LICENSE
> ctime: 1634910503:287405820
> mtime: 1634910503:287405820
> dev: 16777220 ino: 119325319
> uid: 501 gid: 20
> size: 1098 flags: 200000
> README.md
> ctime: 1634910503:288090279
> mtime: 1634910503:288090279
> dev: 16777220 ino: 119325320
> uid: 501 gid: 20
> size: 934 flags: 200000
> bin/index.js
> ctime: 1634910767:828434033
> mtime: 1634910767:828434033
> dev: 16777220 ino: 119325520
> uid: 501 gid: 20
> size: 7292 flags: 200000
> examples/
> ctime: 0:0
> mtime: 0:0
> dev: 0 ino: 0
> uid: 0 gid: 0
> size: 0 flags: 40004000
> package.json
> ctime: 1634910503:288676330
> mtime: 1634910503:288676330
> dev: 16777220 ino: 119325321
> uid: 501 gid: 20
> size: 680 flags: 200000
>
>
> (In this example, the 'examples/' directory is sparse.)
>
> Thanks!
That's useful, and seems to be closing the same feature gap that the RFC
series I sent back in March[1], but at the time you went with adding
this ability to t/helper/test-read-cache.c.
With your series diffing the two with the data used in your new test
shows that we had this with the helper beore:
diff -u <(t/helper/test-tool -C sparse-index read-cache --table) <(t/helper/test-tool -C sparse-index read-cache --table --expand)
--- /dev/fd/63 2021-11-23 02:57:00.980651400 +0100
+++ /dev/fd/62 2021-11-23 02:57:00.980651400 +0100
@@ -13,9 +13,13 @@
100644 blob cebd1739abee3e524d72ca9f51465a94d5a71daf e
100644 blob e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 folder1-
100644 blob e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 folder1.x
-040000 tree e0f2d30b633eb781d675fedd78808135103fe1a0 folder1/
+100644 blob 8b137891791fe96927ad78e64b0aad7bded08bdc folder1/0/0/0
+100644 blob e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 folder1/0/1
+100644 blob 78981922613b2afb6025042ff6bd878ac1994e85 folder1/a
100644 blob e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 folder10
-040000 tree 123706f6fc38949628eaf0483edbf97ba21123ae folder2/
+100644 blob e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 folder2/0/0/0
+100644 blob 8b137891791fe96927ad78e64b0aad7bded08bdc folder2/0/1
+100644 blob 78981922613b2afb6025042ff6bd878ac1994e85 folder2/a
100644 blob 18912c9a915632d7b3344ec25f349dc8b4b9bf27 g
-040000 tree aaff74984cccd156a469afa7d9ab10e4777beb24 x/
+100644 blob 78981922613b2afb6025042ff6bd878ac1994e85 x/a
100644 blob 2d8c856aebeb20da61bd5112d6fa46ff3f56a9e8 z
Which we can now get out of ls-files:
$ diff -u <(git -C sparse-index ls-files --stage --sparse) <(git -C sparse-index ls-files --stage)
--- /dev/fd/63 2021-11-23 02:55:13.329613255 +0100
+++ /dev/fd/62 2021-11-23 02:55:13.329613255 +0100
@@ -13,9 +13,13 @@
100644 cebd1739abee3e524d72ca9f51465a94d5a71daf 0 e
100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0 folder1-
100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0 folder1.x
-040000 e0f2d30b633eb781d675fedd78808135103fe1a0 0 folder1/
+100644 8b137891791fe96927ad78e64b0aad7bded08bdc 0 folder1/0/0/0
+100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0 folder1/0/1
+100644 78981922613b2afb6025042ff6bd878ac1994e85 0 folder1/a
100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0 folder10
-040000 123706f6fc38949628eaf0483edbf97ba21123ae 0 folder2/
+100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0 folder2/0/0/0
+100644 8b137891791fe96927ad78e64b0aad7bded08bdc 0 folder2/0/1
+100644 78981922613b2afb6025042ff6bd878ac1994e85 0 folder2/a
100644 18912c9a915632d7b3344ec25f349dc8b4b9bf27 0 g
-040000 aaff74984cccd156a469afa7d9ab10e4777beb24 0 x/
+100644 78981922613b2afb6025042ff6bd878ac1994e85 0 x/a
100644 2d8c856aebeb20da61bd5112d6fa46ff3f56a9e8 0 z
So that's neat, but unless I'm wrong about there still being some
special-sauce in t/helper/test-read-cache.c that's needed this series
seems incomplete without migrating the existing test users of it to this
new ls-files --sparse, followed by a cherry-pick (or equivalent) of [2].
Is there any reason we wouldn't use ls-files instead of the test-tool in
the tests now? I understood from you at the time that the reason for the
that mode of the test-tool existing was an interim state until ls-files
learned to emit this sort of output, but that you wanted to add that
later. It seems we've arrived at that "later" :)
1. https://lore.kernel.org/git/20210317132814.30175-1-avarab@gmail.com/
2. https://lore.kernel.org/git/20210317132814.30175-5-avarab@gmail.com/
next prev parent reply other threads:[~2021-11-23 2:06 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 15:38 [PATCH 0/2] Sparse index: fetch, pull, ls-files Derrick Stolee via GitGitGadget
2021-11-16 15:38 ` [PATCH 1/2] fetch/pull: use the sparse index Derrick Stolee via GitGitGadget
2021-11-16 15:38 ` [PATCH 2/2] ls-files: add --sparse option Derrick Stolee via GitGitGadget
2021-11-22 18:36 ` Elijah Newren
2021-11-22 19:44 ` Derrick Stolee
2021-11-23 2:07 ` Ævar Arnfjörð Bjarmason
2021-12-08 15:14 ` Derrick Stolee
2021-12-08 15:20 ` Derrick Stolee
2021-12-08 17:04 ` Elijah Newren
2021-12-08 18:23 ` Derrick Stolee
2021-12-08 18:36 ` Elijah Newren
2021-12-08 19:06 ` Derrick Stolee
2021-12-09 12:50 ` Ævar Arnfjörð Bjarmason
2021-12-10 13:57 ` Derrick Stolee
2021-12-10 15:13 ` Ævar Arnfjörð Bjarmason
2021-12-13 19:16 ` Junio C Hamano
2021-12-16 14:11 ` Derrick Stolee
2021-11-17 9:29 ` [PATCH 0/2] Sparse index: fetch, pull, ls-files Junio C Hamano
2021-11-17 15:28 ` Derrick Stolee
2021-11-18 22:13 ` Junio C Hamano
2021-11-23 1:57 ` Ævar Arnfjörð Bjarmason [this message]
2021-12-08 19:39 ` [PATCH v2 0/5] " Derrick Stolee via GitGitGadget
2021-12-08 19:39 ` [PATCH v2 1/5] fetch/pull: use the sparse index Derrick Stolee via GitGitGadget
2021-12-08 19:39 ` [PATCH v2 2/5] ls-files: add --sparse option Derrick Stolee via GitGitGadget
2021-12-09 5:08 ` Elijah Newren
2021-12-10 13:51 ` Derrick Stolee
2021-12-08 19:39 ` [PATCH v2 3/5] t1092: replace 'read-cache --table' with 'ls-files --sparse' Derrick Stolee via GitGitGadget
2021-12-09 5:19 ` Elijah Newren
2021-12-08 19:39 ` [PATCH v2 4/5] t1091/t3705: remove 'test-tool read-cache --table' Derrick Stolee via GitGitGadget
2021-12-09 5:20 ` Elijah Newren
2021-12-08 19:39 ` [PATCH v2 5/5] test-read-cache: remove --table, --expand options Derrick Stolee via GitGitGadget
2021-12-09 5:23 ` [PATCH v2 0/5] Sparse index: fetch, pull, ls-files Elijah Newren
2021-12-10 15:13 ` [PATCH v3 " Derrick Stolee via GitGitGadget
2021-12-10 15:13 ` [PATCH v3 1/5] fetch/pull: use the sparse index Derrick Stolee via GitGitGadget
2021-12-10 15:13 ` [PATCH v3 2/5] ls-files: add --sparse option Derrick Stolee via GitGitGadget
2021-12-10 15:13 ` [PATCH v3 3/5] t1092: replace 'read-cache --table' with 'ls-files --sparse' Derrick Stolee via GitGitGadget
2021-12-10 15:13 ` [PATCH v3 4/5] t1091/t3705: remove 'test-tool read-cache --table' Derrick Stolee via GitGitGadget
2021-12-10 15:13 ` [PATCH v3 5/5] test-read-cache: remove --table, --expand options Derrick Stolee via GitGitGadget
2021-12-10 16:16 ` [PATCH v3 0/5] Sparse index: fetch, pull, ls-files Ævar Arnfjörð Bjarmason
2021-12-10 18:45 ` Elijah Newren
2021-12-11 2:24 ` Ævar Arnfjörð Bjarmason
2021-12-11 4:45 ` Elijah Newren
2021-12-10 18:53 ` Elijah Newren
2021-12-22 14:20 ` [PATCH v4 " Derrick Stolee via GitGitGadget
2021-12-22 14:20 ` [PATCH v4 1/5] fetch/pull: use the sparse index Derrick Stolee via GitGitGadget
2021-12-22 14:20 ` [PATCH v4 2/5] ls-files: add --sparse option Derrick Stolee via GitGitGadget
2021-12-22 14:20 ` [PATCH v4 3/5] t1092: replace 'read-cache --table' with 'ls-files --sparse' Derrick Stolee via GitGitGadget
2021-12-22 14:20 ` [PATCH v4 4/5] t1091/t3705: remove 'test-tool read-cache --table' Derrick Stolee via GitGitGadget
2021-12-22 14:20 ` [PATCH v4 5/5] test-read-cache: remove --table, --expand options Derrick Stolee via GitGitGadget
2021-12-22 19:17 ` [PATCH v4 0/5] Sparse index: fetch, pull, ls-files Elijah Newren
2021-12-22 23:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=211123.86lf1fwrq5.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).