From: Derrick Stolee <stolee@gmail.com>
To: Josh Steadmon <steadmon@google.com>, git@vger.kernel.org
Cc: git@jeffhostetler.com
Subject: Re: [PATCH] trace2: fix incorrect function pointer check
Date: Thu, 25 Apr 2019 14:46:40 -0400 [thread overview]
Message-ID: <20ceb5c3-f64f-be77-2d11-cb41a7045642@gmail.com> (raw)
In-Reply-To: <548a9b833f4569c526cf94c048ae115a76d54be9.1556211995.git.steadmon@google.com>
On 4/25/2019 1:08 PM, Josh Steadmon wrote:
> Fix trace2_data_json_fl() to check for the presence of pfn_data_json_fl
> in its targets, rather than pfn_data_fl, which is not actually called.
[snip]
> for_each_wanted_builtin (j, tgt_j)
> - if (tgt_j->pfn_data_fl)
> + if (tgt_j->pfn_data_json_fl)
> tgt_j->pfn_data_json_fl(file, line, us_elapsed_absolute,
Seems obviously correct. Thanks!
-Stolee
next prev parent reply other threads:[~2019-04-25 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 17:08 [PATCH] trace2: fix incorrect function pointer check Josh Steadmon
2019-04-25 18:46 ` Derrick Stolee [this message]
2019-04-26 2:42 ` Junio C Hamano
2019-04-29 13:01 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20ceb5c3-f64f-be77-2d11-cb41a7045642@gmail.com \
--to=stolee@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).