From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id A05201F9FC for ; Sun, 28 Mar 2021 08:57:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230180AbhC1I4o (ORCPT ); Sun, 28 Mar 2021 04:56:44 -0400 Received: from bsmtp1.bon.at ([213.33.87.15]:26294 "EHLO bsmtp1.bon.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbhC1I4j (ORCPT ); Sun, 28 Mar 2021 04:56:39 -0400 X-Greylist: delayed 33023 seconds by postgrey-1.27 at vger.kernel.org; Sun, 28 Mar 2021 04:56:39 EDT Received: from [192.168.0.98] (unknown [93.83.142.38]) by bsmtp1.bon.at (Postfix) with ESMTPSA id 4F7V1j0sgGz5tlB; Sun, 28 Mar 2021 10:56:24 +0200 (CEST) Subject: Re: [PATCH 4/5] fsck: improve the error on invalid object types To: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Cc: git@vger.kernel.org, Junio C Hamano , Jeff King References: From: Johannes Sixt Message-ID: <20ba35a4-6510-1a48-2ce6-5022e96926bd@kdbg.org> Date: Sun, 28 Mar 2021 10:56:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org A note on the subject line: we are all pretty sure that you want to improve the code, not disimprove it. Therefore, the word "improve" carries not meaning and only takes away space that could be used better. Perhaps fsck: report invalid types recorded in objects or something. Ditto for 5/5. -- Hannes